From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AB3C433FE for ; Thu, 24 Nov 2022 11:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38D336B0074; Thu, 24 Nov 2022 06:39:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33D326B0075; Thu, 24 Nov 2022 06:39:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 204946B0078; Thu, 24 Nov 2022 06:39:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 127546B0074 for ; Thu, 24 Nov 2022 06:39:04 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DE40A4135F for ; Thu, 24 Nov 2022 11:39:03 +0000 (UTC) X-FDA: 80168139366.04.C62D395 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 820CAA0015 for ; Thu, 24 Nov 2022 11:39:03 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id z26so1442474pff.1 for ; Thu, 24 Nov 2022 03:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+5EcPqvErNguuUSXQjM4Gsm5NRO9cAbvO2IWMkYz6pI=; b=SOJw3pGmknQGOs+cKA4lwYKRAW23GcKLpXI9bEcqXWNIZQmj6qZgdaeAgW05Rnk5dc WhjgRoHta5X4f1roJmi0k+NF6085ffRp8wWbmxxYvuOoIjK9sr5+LvgZzdqjfMl6yIg+ Xf8hDCmBAfcJ209YFFw0LR09iN2AQ+/+2K4/BuHnK7hymbqFRZa3aCGBW+KbAGkgX8Ir 7TYe9cW84y2OSlc6te7WF3uPvtw/VwhP5V+eJ1+34SQ12F9m5BlSCk24SXS/howNODnc 5pUXdgbG4YKP8ViGGHEvYP69ji6BO1ElS1MW+4CXwbAxFUxPUpVdRmQiSzEjQn+UuitS sxsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+5EcPqvErNguuUSXQjM4Gsm5NRO9cAbvO2IWMkYz6pI=; b=UzkXLG5mjJ9xFd/ihPMghfsIcWU0vGDmlCZfK1gkZGvCDNH5hDgA048yth7BGDt2TI AwU3HKb2PvpgXowFHhIZ322lB7Tkt17OX+blJGVkq8G2uakkbwthE48A7lILGIQfr6RV eNBw9GXMevhHb3vq8UGSnNnCBzRKhW79CBqeca2jLEi/7m6OW6dIQhGobI4BmnRsbILL cIhUJqHnNBB2N+Tr/MixB8aDp0+h1x20OVsBAyaDhh2RaIWKS/rVSAlyMEuRF2A4o4E3 jknKeSs+qQozzGzMNi7EOoTIkq54oj4DdISFwja4R0277yIzq6Rdh7aU5l+Da7IT8tbL anCw== X-Gm-Message-State: ANoB5pnqSn/NU7VyDmDcloPHIaTQNGyBNSksnahoIt2rmktFWIhZDbXe E9n9i13MUr78I9/mIBJVrBU= X-Google-Smtp-Source: AA0mqf6DoxIbI42ZFR91whRSV72DkyTzPOXE08yKJHXysCt+s0YkgN8Huvbe8ojyWrwoVjgC2BICdA== X-Received: by 2002:a62:6083:0:b0:56d:3180:c7fc with SMTP id u125-20020a626083000000b0056d3180c7fcmr16238203pfb.41.1669289942391; Thu, 24 Nov 2022 03:39:02 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id f15-20020a170902684f00b00177e5d83d3esm1098955pln.88.2022.11.24.03.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 03:39:01 -0800 (PST) Date: Thu, 24 Nov 2022 20:38:55 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , Linus Torvalds , Matthew Wilcox , patches@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/12] mm, slub: retain no free slabs on partial list with CONFIG_SLUB_TINY Message-ID: References: <20221121171202.22080-1-vbabka@suse.cz> <20221121171202.22080-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221121171202.22080-5-vbabka@suse.cz> ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SOJw3pGm; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669289943; a=rsa-sha256; cv=none; b=zJZr74eeWct4LDWjBZ8k8crz/zqvfv7TzaWHUAeB1K5aA+crxpNZDqIq1mfhxQhK7SmPD9 QKTNIOMTaXUKHGHMaznrPm4qnSMLFOxJoZI6mhv7iuCVE7KCiPJtnO0M5PGSgZEsTKnWlG M0o01wjAf4OUf9szvGRrkIywvgsoMMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669289943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+5EcPqvErNguuUSXQjM4Gsm5NRO9cAbvO2IWMkYz6pI=; b=jLOfePf6qBbLxgsoY8N1mj+roBo1JoGUK//oc1OC30XUiwX/O18dziixN7ClOYd2I6JPyw tExWbIY/AcSwfEd6dagPQ5U2nNHDU7TvQNZlDM5a0pcaPoWbsZ5k920gkfUfiXVuSC8YlS rCnr7n8+RtIXf+Ko2+YdEq/yMf41sek= X-Rspamd-Queue-Id: 820CAA0015 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SOJw3pGm; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Stat-Signature: uph4f489oe8ez5e6s8cwiuauo9dg1xe1 X-HE-Tag: 1669289943-532919 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 06:11:54PM +0100, Vlastimil Babka wrote: > SLUB will leave a number of slabs on the partial list even if they are > empty, to avoid some slab freeing and reallocation. The goal of > CONFIG_SLUB_TINY is to minimize memory overhead, so set the limits to 0 > for immediate slab page freeing. > > Signed-off-by: Vlastimil Babka > --- > mm/slub.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index ab085aa2f1f0..917b79278bad 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -241,6 +241,7 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) > /* Enable to log cmpxchg failures */ > #undef SLUB_DEBUG_CMPXCHG > > +#ifndef CONFIG_SLUB_TINY > /* > * Minimum number of partial slabs. These will be left on the partial > * lists even if they are empty. kmem_cache_shrink may reclaim them. > @@ -253,6 +254,10 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) > * sort the partial list by the number of objects in use. > */ > #define MAX_PARTIAL 10 > +#else > +#define MIN_PARTIAL 0 > +#define MAX_PARTIAL 0 > +#endif > > #define DEBUG_DEFAULT_FLAGS (SLAB_CONSISTENCY_CHECKS | SLAB_RED_ZONE | \ > SLAB_POISON | SLAB_STORE_USER) > -- > 2.38.1 > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon