From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BDCC4332F for ; Thu, 24 Nov 2022 03:32:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5221F6B0071; Wed, 23 Nov 2022 22:32:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AC756B0072; Wed, 23 Nov 2022 22:32:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34BAB6B0074; Wed, 23 Nov 2022 22:32:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 21A256B0071 for ; Wed, 23 Nov 2022 22:32:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E43C38019A for ; Thu, 24 Nov 2022 03:32:51 +0000 (UTC) X-FDA: 80166914142.28.56DA39F Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 951A6C0009 for ; Thu, 24 Nov 2022 03:32:51 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id y10so353926plp.3 for ; Wed, 23 Nov 2022 19:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6BBzplv4usyuEIMVAm0qSmS4cJi8RTr3YYpBQBevHpg=; b=Cj7WMrasPvkvyAb/qeIh9ngQl6+RCuho//7eFZusoZVJ+Dg6U4nya27EHYYL9dHEOt wp3QavtAJPimFmg+vgztmtcV0c0QobHpI/wSh5hI6++bBO3RJwFp6wEXjjjBh+MaOGZa p41Qf5Kc/CgTRiL31j8YucyoUcuQminmXTDRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6BBzplv4usyuEIMVAm0qSmS4cJi8RTr3YYpBQBevHpg=; b=WignZLp0Xj90YbEiryVKm+xI+9oMA2zG6cQQqvcKJtN1qxUxcUZQZw8EAxNAHv+iyJ ddRbuhmX5RR5CqzQkNLan5u8FmvftQEQf+XDg+ezushxdhS1Z/nmoUS1HdveCCeS+jHQ swQszSDPppjp0lsF2rikcH44+vu6zcT/cB1MA7+BM0aEiJXYnP1zY0gM9ZJsXwQ3jsaX IKR+3JKcabJ4BKHRb5gk23zq3kyjR7adbGMnDk7hE2TtPEw0AbzJ7AmOlMpLfzIuv14t sOmqoW2E6P+iHkQr3ujLTMml239Y8UTL1tazhESWXKNo2tvQL+ZpksjkGreC4P2pvlyy DMGA== X-Gm-Message-State: ANoB5pmvu5vfmx8kfwmTXb4CLqsll3+I9iarTPGcdh/0bq0innibQm95 ti4h+Uxmjxcx4DW9A6Bhvm8yxg== X-Google-Smtp-Source: AA0mqf4fe4gZPOdvRZh5wCh+8bjwt8ps/uLJ8zufhsVLYPfKWMDwdrHoEcEuOPcAieWUxRD0uL3SqQ== X-Received: by 2002:a17:903:264c:b0:186:6fde:e9f5 with SMTP id je12-20020a170903264c00b001866fdee9f5mr17083278plb.139.1669260770615; Wed, 23 Nov 2022 19:32:50 -0800 (PST) Received: from google.com ([240f:75:7537:3187:438d:8b02:662d:50b3]) by smtp.gmail.com with ESMTPSA id f11-20020a65550b000000b00460c67afbd5sm122401pgr.7.2022.11.23.19.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 19:32:50 -0800 (PST) Date: Thu, 24 Nov 2022 12:32:45 +0900 From: Sergey Senozhatsky To: Johannes Weiner , Nhat Pham Cc: Andrew Morton , Seth Jennings , Dan Streetman , Vitaly Wool , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] zswap: do not allocate from atomic pool Message-ID: References: <20221122013338.3696079-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669260771; a=rsa-sha256; cv=none; b=QZyRgGNnxCJX2AWvD3J96hXutDf+VAeZYbV8YBYeLFpH2tsojHV+/C5USotanA4jZaaBdx 6EVwKYLtu+x2e19QTvZsc+DJE7dpLuHV3eP0OBuSX7bwXDfojpR45Xi9IL1OzU5lCTb+gH /6SYmY7zAD+6EqvSrme0tYCmOshjXFk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Cj7WMras; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669260771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6BBzplv4usyuEIMVAm0qSmS4cJi8RTr3YYpBQBevHpg=; b=3D3sb+PlUpeLHVUBGl6w4zlBFYUi49iUvOMbbrkTpkqmOmomWr4UQ8noz9n880QHJyXLi5 x8z7IKiCpjNsJn7axBxnSoiI5z44OaIwurtXAzipHbwBMN6BijlSj9GQp6m+QTpzOlDY9q lf4x1Jg3n/E4r28gt1TEEUZpmRHpRyE= X-Rspam-User: X-Stat-Signature: c45sbqpar48sm744ib6mi3iuxt3jair7 X-Rspamd-Queue-Id: 951A6C0009 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Cj7WMras; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-HE-Tag: 1669260771-314648 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/22 12:30), Sergey Senozhatsky wrote: > zswap_frontswap_load() should be called from preemptible > context (we even call mutex_lock() there) and it does not > look like we need to do GFP_ATOMIC allocaion for temp > buffer. The same applies to zswap_writeback_entry(). > > Use GFP_KERNEL for temporary buffer allocation in both > cases. > > Signed-off-by: Johannes Weiner > Signed-off-by: Nhat Pham > Signed-off-by: Sergey Senozhatsky > --- Folks, how do we want to proceed with this? One of the hunks here conflicts with https://lore.kernel.org/lkml/20221119001536.2086599-2-nphamcs@gmail.com/ Do we want to remove conflicting hunk from "[PATCH 1/6] zswap: fix writeback lock ordering for zsmalloc" and pick this patch up? > diff --git a/mm/zpool.c b/mm/zpool.c > index 68facc193496..f46c0d5e766c 100644 > --- a/mm/zpool.c > +++ b/mm/zpool.c > @@ -387,6 +387,13 @@ bool zpool_evictable(struct zpool *zpool) > * zpool_can_sleep_mapped - Test if zpool can sleep when do mapped. > * @zpool: The zpool to test > * > + * Some allocators enter non-preemptible context in ->map() callback (e.g. > + * disable pagefaults) and exit that context in ->unmap(), which limits what > + * we can do with the mapped object. For instance, we cannot wait for > + * asynchronous crypto API to decompress such an object or take mutexes > + * since those will call into the scheduler. This function tells us whether > + * we use such an allocator. > + * > * Returns: true if zpool can sleep; false otherwise. > */ > bool zpool_can_sleep_mapped(struct zpool *zpool) > diff --git a/mm/zswap.c b/mm/zswap.c > index 2d48fd59cc7a..3019f0bde194 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -958,7 +958,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle) > }; > > if (!zpool_can_sleep_mapped(pool)) { > - tmp = kmalloc(PAGE_SIZE, GFP_ATOMIC); > + tmp = kmalloc(PAGE_SIZE, GFP_KERNEL); > if (!tmp) > return -ENOMEM; > } > @@ -1311,7 +1311,7 @@ static int zswap_frontswap_load(unsigned type, pgoff_t offset, > } > > if (!zpool_can_sleep_mapped(entry->pool->zpool)) { > - tmp = kmalloc(entry->length, GFP_ATOMIC); > + tmp = kmalloc(entry->length, GFP_KERNEL); > if (!tmp) { > ret = -ENOMEM; > goto freeentry; > -- > 2.38.1.584.g0f3c55d4c2-goog >