From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFF7C433FE for ; Wed, 23 Nov 2022 21:22:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6E6F6B0071; Wed, 23 Nov 2022 16:22:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1D816B0072; Wed, 23 Nov 2022 16:22:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E6226B0074; Wed, 23 Nov 2022 16:22:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8EC626B0071 for ; Wed, 23 Nov 2022 16:22:07 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5CE971A086F for ; Wed, 23 Nov 2022 21:22:07 +0000 (UTC) X-FDA: 80165979894.11.ADC392E Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf02.hostedemail.com (Postfix) with ESMTP id D35A380006 for ; Wed, 23 Nov 2022 21:22:06 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id z17so13365701qki.11 for ; Wed, 23 Nov 2022 13:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=fELMiNAAnzjxMhrhiZt4CATnthWy6giZnkz2zXGp5/6n8EoC1LuU8oQfUfEcVQoLA/ QichA/k207xrB80yyoNaf6+Tc6xJWRMTitzk6yAa5opT9pLOQT8wvAuJEAXSJePCzD1w P1cHz58W5dAAqh7AjcFl5B+evStoCtfUo/QXjnjllQ2Q64hRJfOI0JNS7wJdfKKTg9Xw pIr4EV4lXRRTewtoWKmDfsV/KVTYBib80VzDNbshHWyjyAUJnzLjamQI1lZwjr3d5Oo3 LEr00TLTaUa5wfDOmxqWAXothKMITL8f1kDbUtzGHBJDRgCkI2aXdf/FUy+cJ5cKtYnu K3mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=XnEnAW1KWPaNUivabc2KJMJwk2x7a2v8Hr61cWmsatquw0amf+xOWR/fIBwvIoSWPe Ejt/fVYrTeurhtks7TXsyK+4fXoKz3CelxpKajbOClk78xXKgiQsfGaUIHbmL0RMby9j 4kdnk5JDEf0j7H2X4tj53vj/VvtvbujGnAgtEkEeDfvGD6C3fmOXputsWl/x3SlxIbrc 9bPsZRGBzbth7V7HTHGpw0tUaAADMfrCrCloNzybgNqij4/vyO5R3Cn8eOtnpUUJ92Q/ U26hv+6gJOtACLf5mjMEMWQON2Iw2xRX9pZ550uld9QQ5xdelnErmi4qVoXmutcghG/I KYlA== X-Gm-Message-State: ANoB5plqEBNOSXCRUfEUcsdwMKtavyqBZs/ZO7Rs0swqWo3tPmWv3GqI uhfY0BlbJLqFz8loYx57r2MihA== X-Google-Smtp-Source: AA0mqf6Fm5ciQ4wtKxYph7OV6JtS/phXFgRnDvE6jcyPWG1R+idx88hHtrCa8QNdTRhn8Fb+kIVYhg== X-Received: by 2002:a05:620a:10b4:b0:6fb:f17e:c8f8 with SMTP id h20-20020a05620a10b400b006fbf17ec8f8mr16670583qkk.404.1669238526028; Wed, 23 Nov 2022 13:22:06 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id c12-20020ac8054c000000b003995f6513b9sm10148797qth.95.2022.11.23.13.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 13:22:05 -0800 (PST) Date: Wed, 23 Nov 2022 16:22:31 -0500 From: Johannes Weiner To: Yu Zhao Cc: Ivan Babrou , Linux MM , Linux Kernel Network Developers , linux-kernel , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , cgroups@vger.kernel.org, kernel-team Subject: Re: Low TCP throughput due to vmpressure with swap enabled Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=fELMiNAA; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669238527; a=rsa-sha256; cv=none; b=H6TqaH8lhKS0XbEYFjEiUMmVuJHZAzaCF4xqtVuT96NF8Rgm7HjSUmRS+7kem/XmQo8aU2 j9Qt2m66R4A88atJe1svvwOSxZ1fcZYE+RDdG8JDUAJzkLky6Cr9fDofMR8g/y2Gt6LkCB iwnjeohxMvD9hesEqK4MQYbKOX94dd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669238527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=MsXlC8p8uvuWlla3Bi0ppWeL3ucAU21BmGWWuiLZfLRPQAyQTnDdgtjTnR8A8xmdGkqH6c vrCxUtSdHOrdrWUnPcnKCoKSxpAt4oavoLqqPDIMUOOOXJFB3apcXl+nZyk6b1RvoGDVCc FTe2CU9la6ywLdb2qNjQqKJ5PNUnFxE= X-Stat-Signature: srd45nzdcam5yath7k7qi15nkeaufdsz X-Rspamd-Server: rspam08 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=fELMiNAA; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Queue-Id: D35A380006 X-HE-Tag: 1669238526-465634 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 05:44:44PM -0700, Yu Zhao wrote: > Hi Johannes, > > Do you think it makes sense to have the below for both the baseline and > MGLRU or it's some behavior change that the baseline doesn't want to > risk? It looks good to me. Besides the new FMODE_NOREUSE, it's also a nice cleanup on the rmap side! It would just be good to keep the comment from folio_referenced_one() and move it to the vma_has_locality() check in invalid_folio_referenced_vma(). Otherwise, Acked-by: Johannes Weiner