From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1032EC4332F for ; Tue, 22 Nov 2022 19:14:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8760A6B0074; Tue, 22 Nov 2022 14:14:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8269F6B0075; Tue, 22 Nov 2022 14:14:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EE606B0078; Tue, 22 Nov 2022 14:14:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 645986B0074 for ; Tue, 22 Nov 2022 14:14:25 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3EF061408C2 for ; Tue, 22 Nov 2022 19:14:25 +0000 (UTC) X-FDA: 80162029290.18.7CE6E2F Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf17.hostedemail.com (Postfix) with ESMTP id CB4F740013 for ; Tue, 22 Nov 2022 19:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oIW+mez/TFEcYehOEAG21RzQumZyO2HavfYb/Bz1UQw=; b=lzR3kl2UCxAuBYbI6TPTxCTPmT EMf/yFp1NbWNALLVOLdkkie9U2ANZW7evhz2eJDhYvxmSY3wtY2NbstsRgX90A4kTqJfqHp5nPYj4 TrvfblYjfgTCGTPwE7MG+voWZEuJpwPHW2FlFOUf/xiA/WC85XD0J3h3PEgwaITBTWaU9GcYaBoDV ZGUzJPUqp9ZAoiV1+mR5x8pMmQxyJIYCdkHPwTINApKngLvrdmp31bcFVj7km1x3MFCqqV3BxeOsy ym5BHgz0yQuVzAiafUHrzKnHN0NzuPtwII2f7hZqysFyyB+ziBgZ3acHRhzJABzq/9EiXpR3chCho sKN6e6/w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxYis-003Yt6-Dn; Tue, 22 Nov 2022 19:14:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E0F5A300445; Tue, 22 Nov 2022 20:14:21 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D1DDC20B64111; Tue, 22 Nov 2022 20:14:21 +0100 (CET) Date: Tue, 22 Nov 2022 20:14:21 +0100 From: Peter Zijlstra To: Dave Hansen Cc: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error Message-ID: References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669144464; a=rsa-sha256; cv=none; b=KIQ/uzQEcqZKgIgAsrNBuK0inxeo9v5AyT7Xc0iuB9AVPsn8Ism1mfTs4i4vOIzo9Fk8h9 fTMwA8cmmQ5twKMKvHQOF1KHcxYd8OMIUMfYKJCZ/Sa0nWR32wfUXNMp+Tc1/rjLpKfVts w2C+d/yeLHPR/Spaj49tL8a1YSPE+Ag= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=lzR3kl2U; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669144464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oIW+mez/TFEcYehOEAG21RzQumZyO2HavfYb/Bz1UQw=; b=bsY/ZkKLCajLFeYH+cSIxgui+6PKaRWx3rjv66VFqijLxnd0AQvghBINnB5r4zhnN2VYxO 8RvFCoJyCWf3Ye5Wh97i1q+YFVDaLshUHlwzxzF+n7pSD/fyh6g/mqnz8L+PHLxzSQDrAo mcbaZtczMf4t2ZlNdYBmWiMm/mtRXE4= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CB4F740013 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=lzR3kl2U; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: 485fuj4agth87bgkmst1jgjn3r7ymck5 X-HE-Tag: 1669144464-967672 X-Bogosity: Ham, tests=bogofilter, spamicity=0.084054, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 10:57:52AM -0800, Dave Hansen wrote: > To me, this starts to veer way too far into internal implementation details. > > Issue the TDH.SYS.LP.SHUTDOWN SEAMCALL on all BIOS-enabled CPUs > to shut down the TDX module. We really need to let go of the whole 'all BIOS-enabled CPUs' thing.