From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 138D5C4332F for ; Thu, 24 Nov 2022 17:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3252D6B0071; Thu, 24 Nov 2022 12:34:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D56F6B0075; Thu, 24 Nov 2022 12:34:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19CB66B0078; Thu, 24 Nov 2022 12:34:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 099D56B0071 for ; Thu, 24 Nov 2022 12:34:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D907FAB0F3 for ; Thu, 24 Nov 2022 17:34:18 +0000 (UTC) X-FDA: 80169034596.18.42AC543 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 4E4C82000B for ; Thu, 24 Nov 2022 17:34:18 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id cl5so3393240wrb.9 for ; Thu, 24 Nov 2022 09:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4XcU9QM1ckQIRe8QVhZPdinZjsfGER7s7lyyPku7DYQ=; b=R1b3oSBO1JQM5LWUbXVCjlamk8u5bPM5JN3ayETkQT+gate4ffVmiBGlW84XSnwPk/ b0XbSiqw+PMQe3qXaMcBSFpSViggoHXm0b6BP+faSQXldVowV3WTZYjG2sCyfuSx3Ist QZ6NwCs090UekQs7cZy5A9064ozKwMTb2EHafIvYWnXT+mSemqxEX/EqKvgYlXV+ELp/ kUodW+WY43ZZh1x48XR40d3KZHDW0KgRQ1nKrd5/tJzYA/BiGN9JtD7007zaCPZOYVpJ yMPPSTuqCMdelktj1zwIboW5EHbi2b6Im+FpTsFU3o7VJuIqZMTwyTgfHb7bG/AIqBfs vH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4XcU9QM1ckQIRe8QVhZPdinZjsfGER7s7lyyPku7DYQ=; b=B284jFkYLy/+pQnmm3bxTbvk5+d+rZ6FzM9Xno/4MgGZuxUiGB/IVy6kXkzC8+v24x jbhXL6swGeIEInTvUWOt6DrsGZxW4iXVolc5DxAx7/BllgteJ0ImkBXYeYvLRQLA4Yt3 LElA8c8wpRxlPectf2gDQLWQsykBSct10R+XaFc5hELbALyW8Ag0n50tvPMbNwhpgvzi l9xFk5+162XR4e60xTZcKOAE5bXiQide/1GkjXrXL250J1mW2ZabTSp273VLcigdLcAx 0GAXFC4SBoQ46EjGalj/uwRzdBAF+x5GxHaHSAniYmKK5ADukVpNydA8OCIwM20kjzxt rVcQ== X-Gm-Message-State: ANoB5pl5d9XOrzdZyCeYwTe7xKzIo8kTkEMU2Q1lBLo64TIKd9SL96Mm 5FMbZbYL/r/JZbuQK3oNtBSfsg== X-Google-Smtp-Source: AA0mqf59SeeMbBnb9HJBK2F4/46LuJC45dS0pyoVhoePMQNWhplXAcRq5kUENsm8AZLBjko11x/Www== X-Received: by 2002:adf:fd01:0:b0:235:83aa:a6ed with SMTP id e1-20020adffd01000000b0023583aaa6edmr19825861wrr.543.1669311257016; Thu, 24 Nov 2022 09:34:17 -0800 (PST) Received: from vermeer ([145.224.92.100]) by smtp.gmail.com with ESMTPSA id j2-20020a5d6e42000000b0024194bba380sm1869088wrz.22.2022.11.24.09.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 09:34:16 -0800 (PST) Date: Thu, 24 Nov 2022 18:34:11 +0100 From: Samuel Ortiz To: Conor Dooley Cc: "Hongren (Zenithal) Zheng" , Palmer Dabbelt , Paul Walmsley , Albert Ou , Atish Patra , Anup Patel , Eric Biederman , Kees Cook , linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michael Kerrisk , linux-man@vger.kernel.org, Jiatai He , Heiko Stuebner Subject: Re: [PATCH v3 2/3] RISC-V: uapi: add HWCAP for Bitmanip/Scalar Crypto Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=R1b3oSBO; spf=pass (imf13.hostedemail.com: domain of sameo@rivosinc.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=sameo@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669311258; a=rsa-sha256; cv=none; b=75ZinKTud8SvtW8gAaZT/DdvcCzr27or2qrtEzYQfIe/rjyOg1uB0IQeY6fja72C4LhY91 gHXwlcD5OSe+Ra/lOvkfaHbLD2akv82Ywo06BifNQzeoeCv08lr/Yw6gCOKzgF7uX+EIIc rjcfnnxWQ6dVrsq4ZRiHv7LwjIu1bjk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669311258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4XcU9QM1ckQIRe8QVhZPdinZjsfGER7s7lyyPku7DYQ=; b=jV4cNPbGhKEFpOV0Oy3XiUDOMPPTnlpG5pmk0NlF3s8oMh+HaUKdVoLFcofeb/BdCEfONb m7WUrYwMLiXBR4aa4ivbNabLNqantWjFnWsN2095QMhQxFdbVqHIhgZRv1Bql4t7AiY9pj c2JohTjQADYhZfxmAJrfM+z4Tuv5AxY= X-Stat-Signature: si4bip7fyp6zj1si5e1yfgggn8hin9dh X-Rspamd-Queue-Id: 4E4C82000B X-Rspam-User: X-Rspamd-Server: rspam04 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=R1b3oSBO; spf=pass (imf13.hostedemail.com: domain of sameo@rivosinc.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=sameo@rivosinc.com; dmarc=none X-HE-Tag: 1669311258-219836 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 24, 2022 at 05:20:37PM +0000, Conor Dooley wrote: > On 24/11/2022 17:12, Samuel Ortiz wrote: > > [You don't often get email from sameo@rivosinc.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Thu, Nov 24, 2022 at 11:55:01AM +0000, Conor Dooley wrote: > >> On Thu, Nov 24, 2022 at 11:47:30AM +0100, Samuel Ortiz wrote: > >> > >>> Patch #1 is definitely needed regardless of which interface we pick for > >>> exposing the ISA strings to userspace. > >> > >> I took another look at #1, and I feel more confused about what > >> constitutes canonical order than I did before! If you know better than > >> I, and you probably do since you're interested in these 6 month old > >> patches, some insight would be appreciated! > > > > Assuming we don't go with hwcap, I dont think the order of the > > riscv_isa_ext_id enum matters that much? > > The chief put it in canonical order so that's good enough for me! > > > > > iiuc we're building the cpuinfo string from the riscv_isa_ext_data > > array, and I think the current code is incorrect: > > > > static struct riscv_isa_ext_data isa_ext_arr[] = { > > __RISCV_ISA_EXT_DATA(sscofpmf, RISCV_ISA_EXT_SSCOFPMF), > > __RISCV_ISA_EXT_DATA(sstc, RISCV_ISA_EXT_SSTC), > > __RISCV_ISA_EXT_DATA(svinval, RISCV_ISA_EXT_SVINVAL), > > __RISCV_ISA_EXT_DATA(svpbmt, RISCV_ISA_EXT_SVPBMT), > > __RISCV_ISA_EXT_DATA(zicbom, RISCV_ISA_EXT_ZICBOM), > > __RISCV_ISA_EXT_DATA(zihintpause, RISCV_ISA_EXT_ZIHINTPAUSE), > > __RISCV_ISA_EXT_DATA("", RISCV_ISA_EXT_MAX), > > }; > > > > zicbom and zihintpause should come before supervisor level extensions. > > I'm going to send a patch for that. > > idk, Palmer explicitly re-ordered this: > https://lore.kernel.org/linux-riscv/20220920204518.10988-1-palmer@rivosinc.com/ > > By my reading of the isa manual, what Palmer did is correct as > those are not "Additional Standard Extensions". /shrug Hmm, by their name (Z[a-b]+) they are Additional Standard Extensions. What am I missing? Cheers, Samuel. >