From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14ABC433FE for ; Wed, 9 Nov 2022 15:53:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341396B0072; Wed, 9 Nov 2022 10:53:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F0116B0073; Wed, 9 Nov 2022 10:53:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B7C36B0074; Wed, 9 Nov 2022 10:53:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0CFB26B0072 for ; Wed, 9 Nov 2022 10:53:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BB6C9A1296 for ; Wed, 9 Nov 2022 15:53:10 +0000 (UTC) X-FDA: 80114347740.28.A078D26 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf26.hostedemail.com (Postfix) with ESMTP id 1CBA214000A for ; Wed, 9 Nov 2022 15:53:09 +0000 (UTC) Received: by mail-qv1-f43.google.com with SMTP id c8so12528059qvn.10 for ; Wed, 09 Nov 2022 07:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=T+N+TL4RWsLhyuBSFtNrfgXKzUzVxDn6urT2Vlc2kkdGVPRzCfvFzEeWrIm6V+dlHt KOFeR0bRP75lWMjIKUVbMohw+OImYxCZ3Y4DMrPzPU76FwhFQoClQUiZZ4/wi8l6yGz6 OvMy0I7n2Z/PMVyzqILHLM+e4IcFnlPG3XwchiOoxD4V15joIbbCZSIlQTxkTdcABKzI 8+r/KJfbjuCK1q4mpLEZyXeph+FPyVJztyiczmZBcI7OU1AqqhKEKvG6rw5LFFNBZj1g 7SA2+SBFTCSsPqayJZkcSTyBPg2wdxLtwlrSCdLQxfI/zElX3iKwww5481ZtCVEQEU1/ xiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=T7Mw2J0x2iqlMzJj7mTMGZO2q7clPCUh1jFlk3lc+dpAZySGzdiiJg87aFTKBvUsd2 umwX60F7WJEnt6J/TQ0H8HC9/T1920M//SS0yzH/m2ZNTdS73/2o+uXN9MSZZ3rxx4CD IvEHvBFYybmnWnL65vUKZ1iaGC3pfxGMPiDpNVl4TZjd4ZTFmgeun4pn/ifinZpcAGUQ hihaw5FfkOxpvoxCvANviHdCan9gnqzXt20Op4DMmT289eSvEssPDlezt4SQSUdZX2nm Ps1rV4YPxWYkRdMPlAJW9J+jDdw5PGqVp72AJjYGimljsMhprt0tSel0sKmaS1C9P5YL UhKQ== X-Gm-Message-State: ACrzQf0CdqZ9/lo1hH/36/NtFbpuIfr8P9BoBHAlkeQgZBqt3y39tzJS TP5rNAprUbgnbEhyBOeCTs0+rg== X-Google-Smtp-Source: AMsMyM6hLe/bWjTqpZ703+C5WeszH/T+nBegFkICCNxyXoFrJeAnSB8JYRQ+ZfGcz6od8FqccV6+xg== X-Received: by 2002:a05:6214:da7:b0:4bb:d8a2:cc2f with SMTP id h7-20020a0562140da700b004bbd8a2cc2fmr52846832qvh.119.1668009189021; Wed, 09 Nov 2022 07:53:09 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-3663-3884-f85a-44bb.res6.spectrum.com. [2603:7000:c01:2716:3663:3884:f85a:44bb]) by smtp.gmail.com with ESMTPSA id u127-20020a379285000000b006faeecef56fsm5629435qkd.68.2022.11.09.07.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 07:53:08 -0800 (PST) Date: Wed, 9 Nov 2022 10:53:12 -0500 From: Johannes Weiner To: Linus Torvalds Cc: Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Zijlstra , Gerald Schaefer Subject: Re: [PATCH 4/4] mm: delay page_remove_rmap() until after the TLB has been flushed Message-ID: References: <20221108194139.57604-4-torvalds@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108194139.57604-4-torvalds@linux-foundation.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668009190; a=rsa-sha256; cv=none; b=ELmcILAiIaatwDo7CWVy64t7D3u6Uu3AtSmHUQOU/+Ixa1NQxZl3AnuJDcuaeaJFV3Uww+ pMJhtmMYjawn/q9Odc/7u99cI1Isb9wAXmY18qmUhR5cUb1YCmVcrmFKWfFxdQnO2gHKJt UfXgflveO/1GcctuK/+4XalFnsXS6zc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=T+N+TL4R; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668009190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=M3Dy278zx2m+kJQ9eltMFyApv3St2x+vueINSuntpxKsI9aHMh31Vp1bBg6rhImP2zwxKj PnZdtmIvZseA1k5rex4SUuiUL85ovjEP4EYLgoTAJADb9L8lw8zvi7EF1oiA3WImRSTeqv DcpVM11ezQIOip3KO4AfiB4ZQjPizsw= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=T+N+TL4R; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: p9o7jc79zj9hto8dfp4qngnbe458iep8 X-Rspamd-Queue-Id: 1CBA214000A X-HE-Tag: 1668009189-718958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All 4 patches look good to me from an MM and cgroup point of view. And with the pte still locked over rmap, we can continue with the removal of the cgroup-specific locking and rely on native MM synchronization, which is great as well. Thanks, Johannes