From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF1BC433FE for ; Wed, 9 Nov 2022 11:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6417A6B0072; Wed, 9 Nov 2022 06:43:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CA636B0073; Wed, 9 Nov 2022 06:43:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444DF6B0074; Wed, 9 Nov 2022 06:43:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34A8E6B0072 for ; Wed, 9 Nov 2022 06:43:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 05820ABCC4 for ; Wed, 9 Nov 2022 11:43:43 +0000 (UTC) X-FDA: 80113719126.22.FCFF7D6 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf23.hostedemail.com (Postfix) with ESMTP id 7825C14000A for ; Wed, 9 Nov 2022 11:43:34 +0000 (UTC) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A9Ahotp002726; Wed, 9 Nov 2022 11:42:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=EofnKzaLM2ZriJlFgyL0U8/ws46EtCdD61zWpQvHXmw=; b=TOFQgKFS46OyHpV3GHPffIxYz53/WVEzbXS5SEjgJUTFWybdupZYswZdLZV/uLC8DRY0 rRkgTVnvUqgQoxyRPi262ZDfpYr5yUpb+8/To40Mp8DiKeaARentrY/3pwUVr2eXZwex A4M6URP9XS1FU1XlPCbHON1iOYyeFx4eHOrUekYw9vBpGQhWzUXC6aOHI7VP/FoWZbNW hWz5lVAQS0hZhNqkOUD1Gv5VA2BtkmGZx/k58VjsiI0F6OdxoGEl+gEBeLvfs7XQYZkJ DiTiEPYyy9Txk5J0g4auxexmWAX/OHcz+/8bvSW65sAfEegNq6geJi5T60WxGK3BUf67 nA== Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kr8wxme82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Nov 2022 11:42:30 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2A9BZm2F006904; Wed, 9 Nov 2022 11:42:28 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06fra.de.ibm.com with ESMTP id 3kngq8m390-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Nov 2022 11:42:28 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2A9BafjH29229496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Nov 2022 11:36:41 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37BFB42045; Wed, 9 Nov 2022 11:42:26 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A6FB342042; Wed, 9 Nov 2022 11:42:25 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.181.142]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 9 Nov 2022 11:42:25 +0000 (GMT) Date: Wed, 9 Nov 2022 13:42:23 +0200 From: Mike Rapoport To: Yajun Deng Cc: Sachin Sant , linuxppc-dev , open list , linux-mm@kvack.org Subject: Re: [6.1.0-rc3-next-20221104] Boot failure - kernel BUG at mm/memblock.c:519 Message-ID: References: <74979021-D386-4402-BD70-167531C7405B@linux.ibm.com> <58779468e28e026a1aa30a42ca7e8aec@linux.dev> <4fee7f2b0e99e256465ef6e7656c6349@linux.dev> <6e32f14ae25909138e40b2cfd7448ed8@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e32f14ae25909138e40b2cfd7448ed8@linux.dev> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 3p5HC0UcvjN0F4uHDdeyqnRh_gzSfBe2 X-Proofpoint-GUID: 3p5HC0UcvjN0F4uHDdeyqnRh_gzSfBe2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-09_05,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 phishscore=0 mlxlogscore=840 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211090088 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667994215; a=rsa-sha256; cv=none; b=uMMnIoxo35lXplH7qX2HHmpmskA3c9Ds3m689DCKm5ztWYlpedD2I2IqmKxc0NG/FPXlbz 5N++/udCyrWl5pIf7Qbkt8xMip1o3A34djaoX/y74WFSfa2ZYX0Ld1n0My7aoh/+90UHsL T4bPSCD2PXYIPC3QwdY4z/XpQOjHd0k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=TOFQgKFS; spf=pass (imf23.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667994215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EofnKzaLM2ZriJlFgyL0U8/ws46EtCdD61zWpQvHXmw=; b=eI2rtaFrjPLFkcn89L9BX9TiM9pTqfLZCDDDCtkK7MqcExQjwCT0UGITrrW4uxP5ty8ncb 6Ec+QDw2GUmkMPwXir1e3Ve6/+3Mh1jZ8r4Gdt3A4iCi01587FKGoQDxaYL8nrWwoBeFIz 5GJDhSp/LkxE8zlXdYgntk9MZimKFxs= X-Stat-Signature: tshiaswd15zw7abq1dg58st44yufpu5m X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=TOFQgKFS; spf=pass (imf23.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspamd-Queue-Id: 7825C14000A X-Rspamd-Server: rspam09 X-HE-Tag: 1667994214-19259 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yajun, On Wed, Nov 09, 2022 at 11:32:27AM +0000, Yajun Deng wrote: > November 9, 2022 6:55 PM, "Sachin Sant" wrote: > > >> On 09-Nov-2022, at 3:55 PM, Yajun Deng wrote: > >> > >> November 9, 2022 6:03 PM, "Yajun Deng" wrote: > >> > >>> Hey Mike, > >> > >> Sorry, this email should be sent to Sachin but not Mike. > >> Please forgive my confusion. So: > >> > >> Hey Sachin, > >> Can you help me test the attached file? > >> Please use this new patch instead of the one in memblock tree. > > > > Thanks for the fix. With the updated patch kernel boots correctly. > > > > Thanks for your test results. > > Hi Mike, > Do you have any other suggestions for this patch? If not, I'll send a v3 patch. Unfortunately I don't think the new version has much value as it does not really eliminate the second loop in case memory allocation is required. I'd say the improvement is not worth the churn. > > Tested-by: Sachin Sant > > > > > - Sachin -- Sincerely yours, Mike.