From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 324CEC4332F for ; Wed, 9 Nov 2022 06:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFF796B0072; Wed, 9 Nov 2022 01:25:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAF738E0001; Wed, 9 Nov 2022 01:25:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 976B56B0074; Wed, 9 Nov 2022 01:25:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 895FB6B0072 for ; Wed, 9 Nov 2022 01:25:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 625491A06DA for ; Wed, 9 Nov 2022 06:25:25 +0000 (UTC) X-FDA: 80112917010.29.1FD37DA Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 0D0971C0008 for ; Wed, 9 Nov 2022 06:25:16 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id v17so16221584plo.1 for ; Tue, 08 Nov 2022 22:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HJIuejy98upFVLWaGrCilYHDRGS/X2QdZaTtWgg1XNY=; b=lTLdEW/9VYc65JIWfkkP4NkWTDF7NOu8pQEOStuO5QmwlXtM1Ozla18+Lz+N+93MjN XdQO/g5/dvaZp1JwBwePZba9Fts4qp2hRWppZQua3eEZz6UEP9dCW8nPs6qNvCHJyQ2T xtrHddXjGHZ1/F0cxiLu6efRDTty4AkoHAPBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HJIuejy98upFVLWaGrCilYHDRGS/X2QdZaTtWgg1XNY=; b=3J9s5HvIqrV/gU0FFZvK1iMryO0cO50S6egy76euwRvQoo0f8hCrdzrJ0V4zAdzEkb f2srhpFWZ+SQtOen7zshZWBQ7v6OxIeq39r62W53n4tlfSXtRwoyp7ehEdi1IIETOd76 KpQfABn1WV1Y+scC+K3IhqTLdvMmVpQbogcmTdHe0lU1+8E2GkT5e5IWszC60k4UIBng 7PVc3JjdSUIjmJQaeT7IECMDmYOa3EctFHrbeevAEmU2ExhMYL1d4OTYQS/HNLYDkW2h g/U3tPH/vIi7Uph5EOmt/P73WTzssyj+iOXpTa9LbL4DBVz+PQDVWOXnFEN0+Yxuvunb ciiA== X-Gm-Message-State: ACrzQf1wKoJXAJIXZ5t4pxT/L+lz+9NIQ7bATjQQ6aFspUMIO6JS/ZyX E1Ge/e5kh/mZrwMrj/ueowZu6Q== X-Google-Smtp-Source: AMsMyM6TgRtFsZ6s4EHJtAlqgyNkskgXlkuaBbJi8t0LKrZfDkpo+6i7reSXshaPCTuqKji5aA7+NA== X-Received: by 2002:a17:903:2014:b0:186:8937:28a6 with SMTP id s20-20020a170903201400b00186893728a6mr57666414pla.39.1667975088106; Tue, 08 Nov 2022 22:24:48 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e98a:ab9b:7583:cb8a]) by smtp.gmail.com with ESMTPSA id y15-20020aa793cf000000b0056d7cc80ea4sm7416895pff.110.2022.11.08.22.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 22:24:47 -0800 (PST) Date: Wed, 9 Nov 2022 15:24:43 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Sergey Senozhatsky , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 6/9] zsmalloc: pass limit on pages per-zspage to zs_create_pool() Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-7-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031054108.541190-7-senozhatsky@chromium.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667975117; a=rsa-sha256; cv=none; b=EjsJJx9hHoc2rDAZxxNBI+S4+lx/K157W8FJU2vnvIZNbmGUqpSv3vw2TOJGa+HKqFOQl4 rAWFLlGIN/5MmSKTZjsriCekbnQb/S1DlMClEfUWYycdoRmuHsrBJeDn/cmuwCvbg557Yd 96OjgencCBjHak9k43wKLidmffVMPbA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="lTLdEW/9"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667975117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJIuejy98upFVLWaGrCilYHDRGS/X2QdZaTtWgg1XNY=; b=hJOFMSuQsdLW05MYJyLEqfs6l2dghcnbm3w8l4SAxETZA05VOmcCrNEQ/5QrmogXkFCdug YVond08K9u5drNIxMcslreaqwHY3+tYcLiYFW3uIQZF4f8GwLdISFZKxtk+DO68wVl+A3K acyCtbjcxVbxYx9zIiqv+poDv/6vomA= X-Rspam-User: X-Stat-Signature: 19mx3t6p1pyr44otk87qd9d1djuno65t X-Rspamd-Queue-Id: 0D0971C0008 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="lTLdEW/9"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspamd-Server: rspam03 X-HE-Tag: 1667975116-504842 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/31 14:41), Sergey Senozhatsky wrote: [..] > -struct zs_pool *zs_create_pool(const char *name) > +struct zs_pool *zs_create_pool(const char *name, unsigned long num_pages) > { > int i; > struct zs_pool *pool; > struct size_class *prev_class = NULL; > - unsigned long num_pages; > + > + if (WARN_ON(num_pages < ZS_MIN_PAGES_PER_ZSPAGE || > + num_pages > ZS_MAX_PAGES_PER_ZSPAGE)) > + return NULL; I tend to think that creating `struct zs_tunables` would be better. For the time being zs_tunables will contain only one member max_zspage_len, but it can be extended in the future.