From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7AFC43219 for ; Wed, 9 Nov 2022 06:15:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22DFA6B0072; Wed, 9 Nov 2022 01:15:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE076B0073; Wed, 9 Nov 2022 01:15:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6976B0074; Wed, 9 Nov 2022 01:15:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ECF566B0072 for ; Wed, 9 Nov 2022 01:14:59 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A729E12089A for ; Wed, 9 Nov 2022 06:14:59 +0000 (UTC) X-FDA: 80112890718.15.E84B09C Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 5647140005 for ; Wed, 9 Nov 2022 06:14:58 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id g24so16201218plq.3 for ; Tue, 08 Nov 2022 22:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MhA2GM0MmHVgF5w//IL35OcuY4H3+4INJfbT7ZD2bYs=; b=TjZ8RFq/eIuwO/6zg8DWofiyQBOyrb0Ence+A7Yi6MeNz+Gy96a/7h6aR54BKoD1UI fHVUNoXlH/QoP+shqZgFFGBD/wHpuNc9pTTYWNHIFpXxq0ti0zekCenfRxFMXCPY24db ak5lbljB9t2PXOhqKyt0Mf021sPQw/oGasFJW8RuE6Rv9XtTCAuXCFFte+YsfZ994xo8 SIi3uir0P8qP37sU7TLu4Luehk4EQkS3bjJ3KBAfHSi6IuNUYcTwO1J9hj0gz57WqWUt 5Drs7DVeuiS+LK+TbV27iiWlDpjXdoHSF3gFh/EXXcSshtPL5Ip6FyrGhcGARkRNSARk PtHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MhA2GM0MmHVgF5w//IL35OcuY4H3+4INJfbT7ZD2bYs=; b=fSQwnXIQM0BZBx8OUVbhEmhZfGP4SZDJTAk4rWbLOCrfmZCdakOISkjpVo8AhfOAn4 OScoAa2fyjiOI9yxPhanbE6C0pj/hIw4ogV59KYOmu6WLjcoXy6xmOXdNYy6DjRcbARs q35493ksbSJrViCGnqkSZalHrHPkw0zeFQI9THS5Pt4FbWuoGX84ryjWJsIwhMqWeNUp by//qeerIB6I2im4zM4/RQ+5E5+Ym23hyBGnXOCzEqat9Xjwlgh1NAL9xd4m5L1PQykr IrGRdg2pNxmklM19Yr4mNzeGdfjr41bw8tAeC4mhpI8U0Hr5/FaAOUT6QhDKGkKDJ5fA /l1w== X-Gm-Message-State: ACrzQf1JWReXLOew42TxVexwpE485cYLBIVdCcKPJ0t6YvwA+YiHvOUe oryZ+xXNtu7dNk6R3AABCwE= X-Google-Smtp-Source: AMsMyM5AT+y3PXBkhKAlIdJXBwNV7ifDm/jY7CsUvEEIQ/tlI8ze9ACYcaox/LQdFwkIXrXxTBHfiA== X-Received: by 2002:a17:90a:c201:b0:216:ab2c:25b with SMTP id e1-20020a17090ac20100b00216ab2c025bmr29885616pjt.45.1667974454355; Tue, 08 Nov 2022 22:14:14 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id n15-20020a170902d2cf00b0018544ad1e8esm8131460plc.238.2022.11.08.22.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 22:14:13 -0800 (PST) Date: Wed, 9 Nov 2022 15:14:05 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Joe Perches Cc: linux-mm@kvack.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667974498; a=rsa-sha256; cv=none; b=mDZ9Ouhzp0UneHKtlfxJZ/gbP7wFI4jAgnvWlXdCYbT9ZHQgPWttMlShLR7KR7qlzaYQQF PtzZpvmV9yaIe+tPiD2jliNf761zlROMJm8xu3MlxVONyjWCDf6FlZJxQ+2N3bZsPQyhAj XcQWi/OUfIKY+atWpsjmw8UO0Ofx/pU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="TjZ8RFq/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667974498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MhA2GM0MmHVgF5w//IL35OcuY4H3+4INJfbT7ZD2bYs=; b=kIkbJODDAupfnzBXuJvPCDoEvmE8HymzJTiqj0XbVysmtZj0rkJSsKfwtAjv8N77B8LfGz 5kYIBHF7kOEfARmojJLe+1Zeeq6tqffE9jRQt5yiEHgbqr/ZJRdCzi1btzkIHtblo/xc/T RMVaqb5i/PpIexqmAYnd2BQFFa8M06A= X-Rspam-User: X-Stat-Signature: ucasfh1t39i879bjhn3q1sondz3a4xic X-Rspamd-Queue-Id: 5647140005 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="TjZ8RFq/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1667974498-662529 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 06, 2022 at 10:04:25AM -0800, Joe Perches wrote: > On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote: > > dump_page() uses %pGp format to print 'flags' field of struct page. > > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > > are set in page_type field, introduce %pGt format which provides > > human readable output of page_type. And use it in dump_page(). > [] > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] > > @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsigned long flags) > > return buf; > > } > > > > +static Thanks for looking at this. > > noinline_for_stack ? May I ask why, Does it have issues related to stack consumption? To Be Honest I'm a bit unsure what is purpose of this attribute. > > +char *format_page_type(char *buf, char *end, unsigned int page_type) > > +{ > > + if (!(page_type & PAGE_TYPE_BASE)) > > + return string(buf, end, "no type for user-mapped page", default_str_spec); > > Might be better with something like '%pGt: no type..." Will try something like "0x32()" when it has no type because it is mapped to userspace. -- Thanks, Hyeonggon