From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BA8C4332F for ; Wed, 9 Nov 2022 04:34:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46006B0074; Tue, 8 Nov 2022 23:34:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F69C6B0075; Tue, 8 Nov 2022 23:34:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BDCB8E0001; Tue, 8 Nov 2022 23:34:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C90D6B0074 for ; Tue, 8 Nov 2022 23:34:36 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 53A6816137A for ; Wed, 9 Nov 2022 04:34:36 +0000 (UTC) X-FDA: 80112637752.09.362C767 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf24.hostedemail.com (Postfix) with ESMTP id DF9F0180012 for ; Wed, 9 Nov 2022 04:34:30 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id q9so15636975pfg.5 for ; Tue, 08 Nov 2022 20:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XSf7688EJgmfyljltIZDbWFwZCjWLdc9zQ1QubG37Ho=; b=l+VZhxngS/3lLjWx3Pb9NIgO6+fYMFmIKFIqRWSyuGweWNtx+83D3yoywYg2/+/w2v 80wf9Gryu1OqELFfPsBKyV2em1UB0i15E02p/ttx0OanLJUSXl3U6LbF2JH5KTLIAAs7 Tx1MOe5siEYzf3mxqlPA9IOO3uTz4tuof+tjc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XSf7688EJgmfyljltIZDbWFwZCjWLdc9zQ1QubG37Ho=; b=sSabPPLvb9oU6LVke8i8iMJxJ4EGlraXVMTsvowLckok6/Kra9JeJFq98GL822uzWI eo1cWJe5Gna3mefeVN7wqtF6RN5cf9lhxbJw9EAdpYKboWYLPnosmlS609ftbpa0ZrRa RCsmNKd/MuilVPI5xZHZtne4GOHbws1d3L2U+RH/awRzsoFeefaZZrg9kUiw4wJ7a879 kJLvkV2HFBKvy9DnM2yWsXHhQAz5yAuSDsy2bJpTcvoxReuzwLFlRhDFvTalGCgOsFws pLf/NAPNS/pInqKzfU9R3MIsxLvs9ZvBd+8vNE8idYvruAS73MyFib8HFTZCZi0Mb4iW lk6A== X-Gm-Message-State: ANoB5pnPwnYKHTscZkBUlOknY/2Blo4YYeogDAhcgdQXw/W4TkG+3hBq H/a87TJFbKimg2GpGok1XPtLUg== X-Google-Smtp-Source: AA0mqf7rxEJjGKHmIBA8JCt/2QNZ7p06LKC+84VQiLmyJT0AFAG5+dCHqmWnbCkI1Od0jW/X0iZtaw== X-Received: by 2002:a63:a552:0:b0:470:6a2c:7d25 with SMTP id r18-20020a63a552000000b004706a2c7d25mr14404518pgu.468.1667968469754; Tue, 08 Nov 2022 20:34:29 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e98a:ab9b:7583:cb8a]) by smtp.gmail.com with ESMTPSA id c72-20020a621c4b000000b0054ee4b632dasm7184941pfc.169.2022.11.08.20.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 20:34:29 -0800 (PST) Date: Wed, 9 Nov 2022 13:34:25 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv4 7/9] zram: add pages_per_pool_page device attribute Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-8-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031054108.541190-8-senozhatsky@chromium.org> ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l+VZhxng; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667968471; a=rsa-sha256; cv=none; b=fJgWGTCnS8fwR2fgzhzq2Xq1GOl8dJKFiwvzF6NDFOpHJxDn1ZJm+iYOTXJh/rpSHGRVLW 1UPL/QIXsvdeRPBjQUK3ClWFed6ueTasZ9RiC2c24FM1X+LRDbudljDeohalli0RcPdUT3 Ktbd/bzcDZbxKV9bV0vlZ+zA/eR/QRs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667968471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XSf7688EJgmfyljltIZDbWFwZCjWLdc9zQ1QubG37Ho=; b=8BAUads6e3g1JXeSdCbY3cH93ppJYGtvCbcUhqPLliYeI3vVFSZGqsySKaxxf9RPRb4+aS +FPVySUpKDHw/JzldSRCp+vPEutiJreEucjzBB80XM4QxkyKNpwiYutv0QFPAfq0kHcJMp x1yESx4dVZFgMq508XmnT69PzDKNfPk= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DF9F0180012 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l+VZhxng; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: yc96xigcy5xcf9455smwwqwdpuxacidx X-HE-Tag: 1667968470-956674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001194, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/31 14:41), Sergey Senozhatsky wrote: [..] > zram->mem_pool = zs_create_pool(zram->disk->disk_name, > - ZS_DEFAULT_PAGES_PER_ZSPAGE); > + zram->pages_per_pool_page); > if (!zram->mem_pool) { > vfree(zram->table); > return false; > @@ -2174,6 +2213,7 @@ static DEVICE_ATTR_RW(writeback_limit_enable); > static DEVICE_ATTR_RW(recomp_algorithm); > static DEVICE_ATTR_WO(recompress); > #endif > +static DEVICE_ATTR_RW(pages_per_pool_page); May be we can have a more generic "allocator_tunables" device attribute, which will support named parameters instead. E.g. pool_page_len_limit=INT And more in the future. Having hard times coming up with good names here. max_pages_per_zspage is too low level and exposes zsmalloc internals, while in theory zram can use different allocators at some point, and those allocators can have different tunables.