From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A004C433FE for ; Tue, 8 Nov 2022 20:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 276BC8E0007; Tue, 8 Nov 2022 15:03:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 226898E0001; Tue, 8 Nov 2022 15:03:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EEEF8E0007; Tue, 8 Nov 2022 15:03:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F192A8E0001 for ; Tue, 8 Nov 2022 15:03:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B9061806B1 for ; Tue, 8 Nov 2022 20:03:44 +0000 (UTC) X-FDA: 80111350368.01.181494E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 873D218000B for ; Tue, 8 Nov 2022 20:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ECx4ac/43Sve770ApDnoLkpre//8zzwIrtSe8weF9T0=; b=Vscp9mnUyEA3c2afpa4mUNmJCa 9droWRl9WrSRZgdH8YXmFBi64pCRsWzlsNObTnHQFthJVWhfIX1A1/k70XxjhIsYJ9Pg2zZFjBAHY o2mOYnqmRSqh16HSDqko2Jwcdda5y/r4urubWONKi69tG0bS1DoA1AgcRkumtE78XfYGBGypTG0w6 +ePdF98yAW0oCLw1T8WloWVm35SWPVUzSpJw8dxJzr7ExXstz6QpaNKFfFRjSsLFCUFSJ/9XYs2Un e0bCdpi7PciBQMffDs2PjBOl9jBXSjmdgf0wDdaCaBcw9WUXgYVVxdnNshptXnI6r7S3csnqdkOfG Ry14GU/w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1osUor-00AZ68-Eo; Tue, 08 Nov 2022 20:03:37 +0000 Date: Tue, 8 Nov 2022 20:03:37 +0000 From: Matthew Wilcox To: Lukas Czerner Cc: Hugh Dickins , Jan Kara , Eric Sandeen , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] shmem: implement user/group quota support for tmpfs Message-ID: References: <20221108133010.75226-1-lczerner@redhat.com> <20221108133010.75226-2-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108133010.75226-2-lczerner@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667937824; a=rsa-sha256; cv=none; b=EngnlAqv9PInV3SBTLUf2b8pf+UjXS9kHna5qmeuz4X4MPIPuzGv9xj6bNUyQlhLzXzvpT SQJdwP9gz+JsP0/gHTPo1muwaeaxnMLZ3gAIguWPumC7xTqTGZSBIC+cSNCwlf4XY+AJfm IMAjNM6zKl2gEYMT81+OLdOHWNFsyis= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Vscp9mnU; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667937824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ECx4ac/43Sve770ApDnoLkpre//8zzwIrtSe8weF9T0=; b=lvCKsHFbACDdTV6aqTr9RAWyWqm6jW9YxAiq4iuT6bliBzVd0QKs0nHDbW+ULZrVa3+XMe lRHry/NSBNDUvTZWhhYQ7eAv+JyeJvCSgQawrb6iENL2++ivowToAA6X6tVhIXIAuGwB5g C8sxLLubj9PU+4kFu5cfzBMeXOMw4iA= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Vscp9mnU; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: tytuwoeiew39to9ehjpkiq8mcyms16qc X-Rspamd-Queue-Id: 873D218000B X-HE-Tag: 1667937821-983760 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 08, 2022 at 02:30:09PM +0100, Lukas Czerner wrote: > + err = shmem_get_folio(inode, index, &folio, SGP_WRITE); > + if (err) > + return err; > + > + page = folio_file_page(folio, index); > + if (PageHWPoison(page)) { > + folio_unlock(folio); > + folio_put(folio); > + return -EIO; > + } > + > + /* Write data, or zeroout the portion of the page */ > + if (data) > + memcpy(page_address(page) + offset, data, len); > + else > + memset(page_address(page) + offset, 0, len); > + > + SetPageUptodate(page); This is suspicious. There is no per-page Uptodate bit, there is only a per-folio Uptodate bit. So this should be folio_mark_uptodate(). Except that you've only done one of the pages in the folio, so you have no business setting the uptodate bit at all.