From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47670C4332F for ; Tue, 8 Nov 2022 00:40:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 408A36B0071; Mon, 7 Nov 2022 19:40:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B7EA6B0073; Mon, 7 Nov 2022 19:40:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD526B0074; Mon, 7 Nov 2022 19:40:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 210816B0071 for ; Mon, 7 Nov 2022 19:40:22 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CF5C6A0918 for ; Tue, 8 Nov 2022 00:40:21 +0000 (UTC) X-FDA: 80108418642.09.C7BAC5E Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf23.hostedemail.com (Postfix) with ESMTP id 7505C140003 for ; Tue, 8 Nov 2022 00:40:21 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id d10so12365707pfh.6 for ; Mon, 07 Nov 2022 16:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OM0r5u0WH+buQLtra84lMSPb6itvSvD0nc8HMAGCciQ=; b=TWamq7EdLsQok6vDR75JzTopHL0ZZBUv5VALE1B1puumyYTXPDCYlR+2gogdv6Rkm2 lugkVLtCa98IEJFVaurvYmUwXAJEojHJv3X8aHMGO4zLnat7Foc8egfpLkd71PLldEHK UyszcgqFuL2kpl+QHO1IrpIdrVIr8ZgPDe9kY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OM0r5u0WH+buQLtra84lMSPb6itvSvD0nc8HMAGCciQ=; b=O4sXOUQAaL4dhSkHP8s9rAasbVEgTm1+KsxF3+ujhhvTLpOLQLo7jJ+2t7lxgg6HvG lmVQO8O4O25r7wNXNx0alq9GRtJEdQV/P/MdphH+Xu5lPcHZYMutbW0+c1ljovQ6jQmC OhA3z8u78XkTljUvF3tFsm08UfTWc1iBELe10vOj1bFTwnfZUB3XHXTi5+senaMJmVpa VySIEt9Us0th03OwIImBaHoaE8qddHB7TQ5MfAmWOpJ/XKJNUxemPNc7wU8EQpfZhni4 NyZwc9eDSJq1lyLhYNYmxtwp+koW6Q/KunawPdd8YBjqZDfbnsrNrK6i8WXRxfZe4xkl YMQw== X-Gm-Message-State: ACrzQf0Qc5G6ggP7y3rXTB/5JNVEfehnj4tGG1sU6qttEUdYlKs0esjl jiQZZHDMGUDa+8HYGm9FqFDlLw== X-Google-Smtp-Source: AMsMyM6xYGNGchyjy8QrKxApfI8UUYUySm1ARIZSxlctWm/xSgTxWJ7u0ClT72ZMItyHqsIBJBa+GA== X-Received: by 2002:a63:8bc3:0:b0:46f:fa99:7d76 with SMTP id j186-20020a638bc3000000b0046ffa997d76mr30252805pge.134.1667868020231; Mon, 07 Nov 2022 16:40:20 -0800 (PST) Received: from google.com ([240f:75:7537:3187:8d5d:1342:1172:9487]) by smtp.gmail.com with ESMTPSA id a24-20020aa794b8000000b0056cd54ac8a0sm5055970pfl.197.2022.11.07.16.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 16:40:19 -0800 (PST) Date: Tue, 8 Nov 2022 09:40:15 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667868021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OM0r5u0WH+buQLtra84lMSPb6itvSvD0nc8HMAGCciQ=; b=Kent6MpplrnrOIJB05b+WeHUji/h8jNuRSxgB0TK8zF6nF+RKExWPibiaZAo10DjFxFvcW 8o4AbdmJ/nsrg+MM6pd4wlj/KzJLj0vIXdBSuM3ZPCPqBHM2HO1bteZPhaQjZ5VAp4WAbB NIQXjDsdj25dDx+JPI300TLYhMuzyCI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TWamq7Ed; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667868021; a=rsa-sha256; cv=none; b=d293/vcxY/M9k4mz2jpfDtJNP9DLjdYnhEFLvS6jkIDZyIsbGyIVRYd+YCTYlzEDUfITcA yT/bGon5Nt+8AEUpqeIysmxQGRx/75N78ajqSLzZdubZM5B8cNtLevK1DTExxfwwC23LDW zJ5a9XEgO/hll91ixo4P+Z8D0CslDMc= X-Rspamd-Queue-Id: 7505C140003 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TWamq7Ed; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: sr6dwux7m4t6rpd5ssnubxxawsj84axy X-HE-Tag: 1667868021-643035 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/07 11:08), Minchan Kim wrote: [..] > I am thinking like this: > > * Without recomp_algo setup, user can do whatever they want on the fly > > > echo "type=idle threshold=3000 algo=zstd" > recompress > > Later they could do > > echo "type=idle threshold=3000 algo=deflate" > recompress By "without recomp_algo setup" you mean that user doesn't configure anything before `echo XG > zramX/disksize`? Currently algorithm and recomp algorithm need to be selected at the same time - before zram device is initialised, because we use the same code and same approaches: we need to have zcomp back-ends in per-CPU data in zram read/write/recompress. Creating per-CPU zcomps on the fly is probably going to be a little bit intrusive to zram. What I currently have is as follows. A copy paste from my test script: - init device echo "algo=lz4 priority=1" > /sys/block/zram0/recomp_algorithm echo "algo=zstd priority=2" > /sys/block/zram0/recomp_algorithm echo "algo=deflate priority=3" > /sys/block/zram0/recomp_algorithm echo 5G > /sys/block/zram0/disksize Various recompression use cases: - recompress huge pages using all secondary algos in order of priority echo "type=huge" > /sys/block/zram0/recompress - recompress huge pages using zstd only echo "type=huge algo=zstd" > /sys/block/zram0/recompress - recompress all pages using lz4 echo "algo=lz4" > /sys/block/zram0/recompress - recompress idle pages, use all algos in priority order, with threshold echo "type=idle threshold=3000" > /sys/block/zram0/recompress - recompress idle pages, using zstd only, with threshold echo "algo=zstd type=idle threshold=2000" > /sys/block/zram0/recompress