From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015F8C4332F for ; Mon, 7 Nov 2022 14:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94DE06B0071; Mon, 7 Nov 2022 09:41:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FCBB6B0072; Mon, 7 Nov 2022 09:41:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5768E0001; Mon, 7 Nov 2022 09:41:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C2F96B0071 for ; Mon, 7 Nov 2022 09:41:17 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D89180DF7 for ; Mon, 7 Nov 2022 14:41:17 +0000 (UTC) X-FDA: 80106908994.25.7166407 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf30.hostedemail.com (Postfix) with ESMTP id 5111E80003 for ; Mon, 7 Nov 2022 14:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667832076; x=1699368076; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u3e6+JJ5A3zX1Hk0G74jg5cr+39BSLGe2g515DJqP0M=; b=JNewPm0yLiUzZd+TLXxbKF+iuTezohUErtZPBEB3YcL23XY+21Dgec6j axT/PpcOozxnwzglYfXrWrxbvtbR4n4gsMdtEwdw1GHuFNKD2N95rCA3Q sO+/33eUYaLeJpav92iiZxIykEqDpH4oPCXqrNw8AM7JpeatebB5KSjGX ip5pO7Cws+BolExf5a0+EoYtuZz7iVHmzxCvXJTvRETdHGXMurZkukSYb fdJi0USjfYSNazqiaDRDTPt5SikcIVK6yiZK+o+ZX7bgcJRUOQHC0VTGH fb86chX2ksHulh48oWGEW7FWKDMhEYr0lrIyNvXoy8AiqlRO0vBWXoOW7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="310425130" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="310425130" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 06:41:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="704894936" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="704894936" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 07 Nov 2022 06:41:09 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1os3JB-008hYc-2r; Mon, 07 Nov 2022 16:41:05 +0200 Date: Mon, 7 Nov 2022 16:41:05 +0200 From: Andy Shevchenko To: Petr Mladek Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=JNewPm0y; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667832076; a=rsa-sha256; cv=none; b=GQFGSKosTfd4/Fict28YqztIITQi0P8T+Gkt2oNpH1qGvYKETzmAqnLPoytqURET2IDPBx F32S86stDzhd925aJ+zMv+VD2KwsmVh+1RyliUpKci29szM8blvglGu3P+nH7OMXEcYxc6 hIVzp+nB681EUG8WGPm6RDwbUprOA0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667832076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lkcnJIidmcthjbLfwzkGMkevuVAYwssj0XEa8OiPLdE=; b=UeNapjrdwcZfmN0J4nPCpaeJp85jB+nMb2himhpURhxmuJEtgJaw+OeM+BcSU0vNDsT+yl QysMvgaZDSMxdAQyJPlk35dO30+aPXJvbVjcnPZnEe6BjToCfuoEBaDPP7S02jGEHQd4bn PdJcrxkUv1RZP+dG29h86dhRIHgm7B8= X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=JNewPm0y; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5111E80003 X-Stat-Signature: jfisa9qxadn7ys1hgehoyniqkcjttyne X-HE-Tag: 1667832076-969136 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 07, 2022 at 03:20:34PM +0100, Petr Mladek wrote: > On Mon 2022-11-07 13:18:52, Andy Shevchenko wrote: > > On Sun, Nov 06, 2022 at 11:03:55PM +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. ... > > > [ 1.816443] page_type: 0xffffffff() > > > > Why do we have empty parentheses? I would expect either something there, or no > > parentheses at all. > > This looks fine. format_page_flags() does the same for %pGp. ... > > > + %pGt 0xffefffff(slab) > > > > No space before ( ? > > Also looks fine. %pGp does the same. Maybe we can modify them before or after this change? -- With Best Regards, Andy Shevchenko