From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B4EC4332F for ; Mon, 7 Nov 2022 07:20:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F5538E0002; Mon, 7 Nov 2022 02:20:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A57C8E0001; Mon, 7 Nov 2022 02:20:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1951A8E0002; Mon, 7 Nov 2022 02:20:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 098F88E0001 for ; Mon, 7 Nov 2022 02:20:30 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C3F45C064F for ; Mon, 7 Nov 2022 07:20:29 +0000 (UTC) X-FDA: 80105798178.12.1CB1C34 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 708BD180003 for ; Mon, 7 Nov 2022 07:20:29 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id p21so10280028plr.7 for ; Sun, 06 Nov 2022 23:20:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgoRVUgxwXJrcmiPeyTeFWYr8HX0hdcHEbm1EMJUS3k=; b=N44LCtpQ8dRv6IDKu3xJC7HDfEA9EmMBYG0HDvkLn568FL5o+hE+vR/lZhe9lh5JrE Uv6YVPOXyEKZUuviINFmfIrBu8yH31EXUGB6jHFv0zbFcZxTeKMo54f7UNMevpaO5DW1 lqEHuyYKA1Tn8xKhBqOfYEvTsfySI5W5BulJYxzOwv85SNG5xMznabQ8GujIZjoTHoKl C5YJJ2fHUEsElW1aRE8U0CnmZ7L2Nx7KDWtgdcqwW3JkQF2sTcBe+e5V1MpMhpBByzV8 2PTJbd6r9Z7SFVaXYgRPBNU7jQtJFDybdRNycxlSZxmjGvZ0109dCQqSkBv1po4CQPhj NMvQ== X-Gm-Message-State: ANoB5pkAmqW/EcTOsxShyQq9BoeKlaf7IGw3KhhDALMXXCgwEF7czeR0 dd0IgeffDj/Rk+a/z1WGiUg= X-Google-Smtp-Source: AA0mqf6S7IR5t8Rig4uve/uPxrkEQhBeAoMqQb/ZrHuiItMUuOyPSx0Ho7wrdZlqWsgf1aPXmXNB9Q== X-Received: by 2002:a17:902:bf0a:b0:188:6862:cc3d with SMTP id bi10-20020a170902bf0a00b001886862cc3dmr15727874plb.17.1667805628385; Sun, 06 Nov 2022 23:20:28 -0800 (PST) Received: from fedora ([47.153.164.177]) by smtp.gmail.com with ESMTPSA id x12-20020aa78f0c000000b0056cee8af3a5sm3710764pfr.29.2022.11.06.23.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 23:20:27 -0800 (PST) Date: Sun, 6 Nov 2022 23:20:24 -0800 From: Dennis Zhou To: Baoquan He Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH 8/8] mm/slub, percpu: correct the calculation of early percpu allocation size Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667805629; a=rsa-sha256; cv=none; b=BJhd0U5pMKuKXRXmy0norYO3rpx35rHshxIJYMZTv4HcmimqHLYOJ4gqOz4tsJmU+r9jb7 gW44YcFkUCMzfHVzC8YuVajsaLJEE5dGujKbvypAp3dARekye7lO75D6EzkiJ766qWNki4 YTMyLp2efaHiQAyrW05nVU56+f9cbQQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667805629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PgoRVUgxwXJrcmiPeyTeFWYr8HX0hdcHEbm1EMJUS3k=; b=fF62e9ZpVotv28FY1KXaV+bLbBk2OOakXOkrhEX3D2k8ABUIbiGe7mwaBpxpKHu3ro7wA6 KVNWftb8RwBSPa3cqYnd7Ws2J8ZWi4FTiO6oeSmXBaFjH3G6lRfdqaqZSqAl8+0UZW+VcS KTIcYYAl+j+QhC7h/o1Dx6L8DFUZAcs= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 708BD180003 X-Stat-Signature: n8uruhu8tjxjqecmxzu648g3bcmoc5ie X-HE-Tag: 1667805629-530508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baoquan, On Mon, Nov 07, 2022 at 12:35:56PM +0800, Baoquan He wrote: > On 11/06/22 at 09:56pm, Vlastimil Babka wrote: > > On 10/24/22 10:14, Baoquan He wrote: > > > SLUB allocator relies on percpu allocator to initialize its ->cpu_slab > > > during early boot. For that, the dynamic chunk of percpu which serves > > > the early allocation need be large enough to satisfy the kmalloc > > > creation. > > > > > > However, the current BUILD_BUG_ON() in alloc_kmem_cache_cpus() doesn't > > > consider the kmalloc array with NR_KMALLOC_TYPES length. Fix that > > > with correct calculation. > > > > > > Signed-off-by: Baoquan He > > > Cc: Christoph Lameter > > > Cc: Pekka Enberg > > > Cc: David Rientjes > > > Cc: Joonsoo Kim > > > Cc: Andrew Morton > > > Cc: Vlastimil Babka > > > Cc: Roman Gushchin > > > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > > --- > > > mm/slub.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > As only slub is touched and there's no prerequsities in the previous > > patches, I took this to the slab tree, branch > > slab/for-6.2/cleanups > > Yes, it only changes slub code. Thanks for taking it. > > I will resend v2 with the left 7 percpu only patches with update. > > Don't worry about resending them, I'll pick them up tomorrow morning. Thanks, Dennis