From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69AEC433FE for ; Mon, 7 Nov 2022 07:53:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17F788E0002; Mon, 7 Nov 2022 02:53:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E06F8E0001; Mon, 7 Nov 2022 02:53:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F124C8E0002; Mon, 7 Nov 2022 02:53:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D68CB8E0001 for ; Mon, 7 Nov 2022 02:53:00 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A689A1C63A8 for ; Mon, 7 Nov 2022 07:53:00 +0000 (UTC) X-FDA: 80105880120.06.D77DF2D Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 43B3420003 for ; Mon, 7 Nov 2022 07:53:00 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id t1so6327257wmi.4 for ; Sun, 06 Nov 2022 23:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1EXtR7XJJXiRjK9vYVDqObq6bajFz9XQCg+T26fuKrE=; b=AhyPTp2hdxp66jkLu7AniU2AycEFO8kjoA0cTSA2DXMhMakoLktz1BMuwuFBMRoX/L iqDcuROIWNrO1ABA1AvPsmmiAQPwvxmCMQF7aNE4VlzVKkbOO1EbgDA6C9m0e1+yann8 KLNkWVfXds2T/RExpxkwWdWVZM8unzDG437HCPvEiRRHo37+80ifBWPnoaTJV4KVMywv AqXyf0MOPklW9RRMqSQvW0Z4wGOHY2DurTzEqyRxSCGagg4TRN+FeNOjsMKqS3V3UiGI Ua/VAiTmsxsndtlxlQIdq1zjsdpinmbjos/47b59qPYe+SFpVtfCi0X8Z8MSfMDlD9nH VM8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1EXtR7XJJXiRjK9vYVDqObq6bajFz9XQCg+T26fuKrE=; b=2TA5xKTCYyZjjuJHbJriaQxiZoYPeSBbBAtrrVuI59pn2K1L/HdfP23pfbvIT5hwed 7cpYn0uFOaLMDogn2kkoIZmfMy9j97kk6mA+rRoHhNfNDJGfffWBs6CYQtcqoGMgF1Xv aJqTn2BUClPoD3QBYZ5ZWWRV74qB9IwMXq1EodK7rKlhyC1TAp8eI65S0TqQCFOFQTgh y0duspT60Y2GaiI1Ri8vg2YsrzfzgXWLeseslJ/8iIobJMQ0u4e4Z3/SjAbIQ/wKYwKE p2x3rTAFqEuMYGdJgfd7f35+5rFcy2SAc09+HSjQdXIQAsPYCzFsLS6/WKVuzww4jpMt tW4A== X-Gm-Message-State: ANoB5pnCy/TVmXaoy06qLj9Ak4kvacC6Uj0qL9lCTc2IoFeEZDAeBeUf VP9MXuGs5oMe3LTcaA+BEd4= X-Google-Smtp-Source: AA0mqf6U/0XYoOBRltwbquuygrt1XbVmjosVnlfe1s1uJGbaRhSF/xTmhGk6btHBRVs32l434UvZhA== X-Received: by 2002:a05:600c:1906:b0:3cf:a851:d2b1 with SMTP id j6-20020a05600c190600b003cfa851d2b1mr3825762wmq.18.1667807578922; Sun, 06 Nov 2022 23:52:58 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id l32-20020a05600c1d2000b003c6b7f5567csm27209809wms.0.2022.11.06.23.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 23:52:58 -0800 (PST) Date: Mon, 7 Nov 2022 10:52:55 +0300 From: Dan Carpenter To: Joseph Qi Cc: oe-kbuild@lists.linux.dev, Heming Zhao via Ocfs2-devel , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' Message-ID: References: <202211050722.8YGvtPaR-lkp@intel.com> <97361840-0a56-f074-0495-712dafe4313d@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97361840-0a56-f074-0495-712dafe4313d@linux.alibaba.com> ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AhyPTp2h; spf=pass (imf03.hostedemail.com: domain of error27@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667807580; a=rsa-sha256; cv=none; b=m/9qxc/zsRajQ8FA+9Q4Ri7uZoW8nARlulhMNAy0W/dMJ2hdctiwVVG/Oy5zyNV0diTazw OlwuflRBlVUfoZJoMfdY8AS0+6mAvspWbtFADlQ/Z11mb256MZ7XyWaCZhdnuDUIimgrSC Yz4TP/ezRq24UWxOPrs66todHzWU01c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667807580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1EXtR7XJJXiRjK9vYVDqObq6bajFz9XQCg+T26fuKrE=; b=yKFvldyxKzLmSdrerNvR3b/HVFq9eaald8/LqkM7U93/W+GzjmtbP6tsG1UMkrlfROsbgi yBZsvswOP3p8NLcwfX7v+Y2VAbLr7pm2fHx5rhyFLtesWMKs5B7zDffX66u+T17CaQF4E2 oNPTENuaqz4ab9RewzuiS5Kv/zBocME= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 43B3420003 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AhyPTp2h; spf=pass (imf03.hostedemail.com: domain of error27@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: okb9cdysponusk5gjmzax6uqktcgtowo X-Rspam-User: X-HE-Tag: 1667807580-869746 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 06, 2022 at 08:38:07PM +0800, Joseph Qi wrote: > > > On 11/5/22 7:15 PM, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 10d916c86ecafeccaed89175ebf9b832dddde380 > > commit: 0737e01de9c411e4db87dcedf4a9789d41b1c5c1 ocfs2: ocfs2_mount_volume does cleanup job before return error > > config: alpha-randconfig-m041-20221030 > > compiler: alpha-linux-gcc (GCC) 12.1.0 > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > > > smatch warnings: > > fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' > > > > vim +/status +1809 fs/ocfs2/super.c > > > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1802 > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1803 static int ocfs2_mount_volume(struct super_block *sb) > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1804 { > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1805 int status = 0; > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1806 struct ocfs2_super *osb = OCFS2_SB(sb); > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1807 > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1808 if (ocfs2_is_hard_readonly(osb)) > > 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 @1809 goto out; > > > > Unclear if this is an error path or a success path. Honestly, I would > > have thought the checker is correct that it looks like a failure path. > > > This indicates a readonly mount and bypasses dlm related initialization. > So it seems an expected success return. > A comment would help. Another way to silence this static checker warning and answer any reviewer questions would be to set the "ret = 0;" within 4 lines of the goto. if (ocfs2_is_hard_readonly(osb)) { status = 0; goto out; } regards, dan carpenter