Re: [PATCH] mm: anonymous shared memory naming

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3174 bytes --]

On Sat, Nov 05, 2022 at 02:53:42AM +0000, Pasha Tatashin wrote:
> Since:
> commit 9a10064f5625 ("mm: add a field to store names for private anonymous
> memory")
> 
> We can set names for private anonymous memory but not for shared
> anonymous memory. However, naming shared anonymous memory just as
> useful for tracking purposes.
> 

Who are "we"?

Instead, say "Since commit <commit>, name for private anonymous memory,
but not shared anonymous, can be set".

> @@ -431,8 +431,10 @@ is not associated with a file:
>   [stack]                    the stack of the main process
>   [vdso]                     the "virtual dynamic shared object",
>                              the kernel system call handler
> - [anon:<name>]              an anonymous mapping that has been
> + [anon:<name>]              a private anonymous mapping that has been
>                              named by userspace
> + path [anon_shmem:<name>]   an anonymous shared memory mapping that has
> +                            been named by userspace
>   =============              ====================================
>  

The table above triggers Sphinx warning:

Documentation/filesystems/proc.rst:436: WARNING: Malformed table.
Text in column margin in table line 8.

=============              ====================================
[heap]                     the heap of the program
[stack]                    the stack of the main process
[vdso]                     the "virtual dynamic shared object",
                           the kernel system call handler
[anon:<name>]              a private anonymous mapping that has been
                           named by userspace
path [anon_shmem:<name>]   an anonymous shared memory mapping that has
                           been named by userspace
=============              ====================================

I have applied the fixup:

---- >8 ----

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 8f1e68460da5cd..3f17b4ef307fe4 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -426,7 +426,7 @@ with the memory region, as the case would be with BSS (uninitialized data).
 The "pathname" shows the name associated file for this mapping.  If the mapping
 is not associated with a file:
 
- =============              ====================================
+ ========================   ===========================================
  [heap]                     the heap of the program
  [stack]                    the stack of the main process
  [vdso]                     the "virtual dynamic shared object",
@@ -435,7 +435,7 @@ is not associated with a file:
                             named by userspace
  path [anon_shmem:<name>]   an anonymous shared memory mapping that has
                             been named by userspace
- =============              ====================================
+ ========================   ===========================================
 
  or if empty, the mapping is anonymous.
 

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]