From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880B3C4332F for ; Sat, 5 Nov 2022 00:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE65A6B0071; Fri, 4 Nov 2022 20:02:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D96B16B0073; Fri, 4 Nov 2022 20:02:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5EE46B0074; Fri, 4 Nov 2022 20:02:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B797E6B0071 for ; Fri, 4 Nov 2022 20:02:45 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D52214013B for ; Sat, 5 Nov 2022 00:02:45 +0000 (UTC) X-FDA: 80097437490.21.3F6BBDB Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf14.hostedemail.com (Postfix) with ESMTP id 31770100003 for ; Sat, 5 Nov 2022 00:02:44 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id l2so6254371pld.13 for ; Fri, 04 Nov 2022 17:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/xCAri3GmDiSlTNge1Wq3LvamGlY3yMVS4Ph4n/65v4=; b=P1zu+aMI5OjVI2su4YAgD1ZfPnhfADlVBnVbqOUzVE+Xd+oOVunhqVqBKMwB1HLMw+ NzWAqaHGyzw9PgRxaboFC/N3I3QPJT3hZ3vKjI4dBZH7ldi1esEZG950nR1YYfYSQkRz XZEFnL4V/SYaBIzf01n8p+hBLm1CC7wq6NiUd0PwQWsWeNk/vmCKwgeD0RFI9mnd+iMu s3mXx9NXxrPAivfmKXWlR2hqN2T+xrQg6A7pmBwrGfNe+Dw+e6Us0W7Hzp17MKg7nP5b Ond9cMzvFRoRL64tjz9q6CbGY633QPmr6NfsGvqf3y0cwKMYeID1H7SVhGa64fjp8QnW Gnow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/xCAri3GmDiSlTNge1Wq3LvamGlY3yMVS4Ph4n/65v4=; b=EoBoSKZ7pXhPi7LdtekVmsHtYr0dM9tW+bJr4XgRFUaa1R9jRsgatUuO5XNauf647u CW0peEJY02Lrdi++F8/9VSU3rW3ZP7xwFKOwjH97aOCSCM1UI0LIuSas5S47GeqiGgTM ml/SipCMnlCS5k7ty9lFCeC64jBJWTjmRyzCyd/m9CLFwlhyV6R0nM0zucv8oBcAwE1k PJzUl/fDrOLqCJ7/a+Cs6ykmjzt04YaGdsEwWQ/ZWdC2iRVcn1pRmWeFRqcNbN6TO4gX nLaVR04QRJVK4kJ3wK4HKo8ha6+IXpr5/dB9LAzPTWr0l/jDPRZlrlizBkwaJYZnz+QG 2LUg== X-Gm-Message-State: ACrzQf2AIlM8AMQjt9MtzNE7FEwEyoN/ysrbYjdOoI6xWEiRbkm/klCz RSxKA7RtR3Zhy7J9p00jv8U= X-Google-Smtp-Source: AMsMyM67M5B4R8Zwwr5gf4wD1hHYiqMNYrrXQlpPKRnTkXanX9H5/KrLSAPI9K7p/XG5J6etXuHtJQ== X-Received: by 2002:a17:902:c745:b0:186:b287:7d02 with SMTP id q5-20020a170902c74500b00186b2877d02mr38557250plq.87.1667606564108; Fri, 04 Nov 2022 17:02:44 -0700 (PDT) Received: from google.com ([2620:15c:211:201:755f:cdcb:1bd8:5ad8]) by smtp.gmail.com with ESMTPSA id j17-20020a170902da9100b001811a197797sm298490plx.194.2022.11.04.17.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 17:02:43 -0700 (PDT) Date: Fri, 4 Nov 2022 17:02:42 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667606565; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/xCAri3GmDiSlTNge1Wq3LvamGlY3yMVS4Ph4n/65v4=; b=5bboS0ughaoLEVsnLzNSzlmx1x+3PQB27G466dzClyU8h5H55HIwHnAlKV4h/hcArKUB1o E6GhVSLeJneN1/ocH0YQiUD9MoHVbNyZLIXrXaDOhiHKsKQ54/Qsg+l64rHu2psiHHZ9zf ulT6oF9WoJqyfTyt+NZ8kg9Dx0Jyzjc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P1zu+aMI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667606565; a=rsa-sha256; cv=none; b=JtWr825PJXTeahHxFj2c9FKnm2uMiV8dsqi3hsmjGh1aVUB+mZ1FUkdpO1ZhG7e7GKKu4j 12xKJ5Wi4jqqVyZ5dYaak0CXHXEG0Bxd1yaqQQVtzWT9NAo84fRX6ZI0i8qVsvOlYL9p37 AC8LryEsY9vdT4oQpxqoX5TuRbN3+zw= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P1zu+aMI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 31770100003 X-Stat-Signature: uabdg1ktdarm55csbbifcg3abz5p58mb X-HE-Tag: 1667606564-580630 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 05, 2022 at 08:44:46AM +0900, Sergey Senozhatsky wrote: > On (22/11/04 16:40), Minchan Kim wrote: > > > > > Configure 2 alternative algos, with priority 1 and 2 > > > > > > > > > > echo "name=lz4 priority=1" > recomp_algo > > > > > echo "name=lz5 priority=2" > recomp_algo > > > > > > > > > > Recompress pages using algo 1 and algo 2 > > > > > > > > > > echo "type=huge threshold=3000 algo_idx=1" > recompress > > > > > echo "type=idle threshold=2000 algo_idx=2" > recompress > > > > > > > > > > Maybe we can even pass algo name instead of idx. > > > > > > > > Let's use name rather than index. > > > > > > OK. Any preference on the keyword? "name="? "algo="? "algorithm="? > > > "compressor="? "comp="? > > > > > > I want use the same keyword for recomp_algo. I sort of like "algo=", > > > but not sure. > > > > +1 with algo > > Minchan, I'm sorry I'm getting a bit confused (didn't sleep last night). > I just saw your other email and you suggested there that we don't need > any idx or name in recompress. Or did I misunderstand it? > I should have more clear. Sorry for that. I meant if you need some reason, I prefer "algo=' to make review proceed. If you agree we don't need it, then, yeah, we are all good.