From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4A8C4332F for ; Fri, 4 Nov 2022 23:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5C116B0071; Fri, 4 Nov 2022 19:44:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0BE66B0073; Fri, 4 Nov 2022 19:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D3736B0074; Fri, 4 Nov 2022 19:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DB8A6B0071 for ; Fri, 4 Nov 2022 19:44:52 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50E70A0A41 for ; Fri, 4 Nov 2022 23:44:52 +0000 (UTC) X-FDA: 80097392424.23.56CF1F4 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 0A77B40004 for ; Fri, 4 Nov 2022 23:44:51 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id b5so5650324pgb.6 for ; Fri, 04 Nov 2022 16:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MbYMQSTlWErMi0dlfZfN+APvyvfPo1NmalRHcGJBJUA=; b=nN8SwqwOtFpxlzE+LhE/SLk4Y235L1jNgh/mYuDBAyGQUbHBjmj/5f3PMTChIEcWXy fHyNc4fh3LyM3g0S+Bz93toRGeFIQ1FWbGf37ecVDJz70mjuUUKsMBKJxmIFRSMrRajA 2kASL1HnS3KE/ANbacU6GwpRtl6W+kMHrfVAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MbYMQSTlWErMi0dlfZfN+APvyvfPo1NmalRHcGJBJUA=; b=2h7qRbFMCZixOtp9tz6fsSJW5/Yhi2vXkn+3/KRIRYzRFppcC4n5u2WCmQ8Pd4ECV5 XPQ8LSnSGT9fiQr6ePAj9L2pkqbDbaxzzNEuKtD5lsbILOr8EZHRUe95Z6AY4ZUtANqJ jkAfOS55rPR1sOtEKD0AxuRb66SlDTn8+Yp3sKsCUiK9d757JFtCYad9GveZS42FpOme 2ClObMzNJYR8xFVjNbpPhRtOx5PKR1Zi48cWePQv2M2yL6bOylFVBqKxdJKbYEiaATpL NDQPhRj65cxUzW0oGW4btXEF9j/bOd4k+5cB00tGvcOrpLfR/Bzy3bZv8VRrY4qQrHC5 1aWw== X-Gm-Message-State: ACrzQf12yF6WyWtJk/QjMpsd5t7KoljaBcs+UEmzCGk0KHlq+9aMlre3 EHbnHLQppBCt7j4qU1CEvmf/Owv6akz5Bg== X-Google-Smtp-Source: AMsMyM5gvQlFVPQtzvXPQ8bWwfYGPbcB3uOukJyB9L2y6dujo2uc13V+TqDBifAvayTpcdLq/CffHQ== X-Received: by 2002:a63:ea58:0:b0:45f:ffa9:60a0 with SMTP id l24-20020a63ea58000000b0045fffa960a0mr32834833pgk.433.1667605491154; Fri, 04 Nov 2022 16:44:51 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f2f6:8f5:87c8:3aeb]) by smtp.gmail.com with ESMTPSA id p3-20020a622903000000b005636326fdbfsm163832pfp.78.2022.11.04.16.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 16:44:50 -0700 (PDT) Date: Sat, 5 Nov 2022 08:44:46 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nN8SwqwO; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667605492; a=rsa-sha256; cv=none; b=HFcsMf58DKQLqWQJ2m2g3aiuygwyLtfZQpHwqKsOlAAjS3Ryyemxj92E5OJZo4noZr6Uo4 gxF7SPFIt4Gx6bP46rpeNQ31mkxQWc/6RrbGK+m8hc92wbPGRhGE/L3/9rUpo4gWrr2AHm BG0+KuUy9+UhCsQTZPH9+Hug/sSAq0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667605492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MbYMQSTlWErMi0dlfZfN+APvyvfPo1NmalRHcGJBJUA=; b=COEko2rcROZ2CiDsGxeGh3pN0jNNTY7zW87jSlHUj0rlbob0rd/+FH2lyo33XfXmK44uZ2 Dpyn/rBdioQGz9KVU4Jg2Nft5rIA/nA41B6iHRlP18PSWPgQQVSNEH32oGFVVfGqv4VqtL oNiWtQnYtkC1lcjNQihxWVlD4agLF8E= X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nN8SwqwO; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0A77B40004 X-Stat-Signature: gsadwugk87wbzxybuw1nmeqo33j9j4mu X-HE-Tag: 1667605491-95596 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000157, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/04 16:40), Minchan Kim wrote: > > > > Configure 2 alternative algos, with priority 1 and 2 > > > > > > > > echo "name=lz4 priority=1" > recomp_algo > > > > echo "name=lz5 priority=2" > recomp_algo > > > > > > > > Recompress pages using algo 1 and algo 2 > > > > > > > > echo "type=huge threshold=3000 algo_idx=1" > recompress > > > > echo "type=idle threshold=2000 algo_idx=2" > recompress > > > > > > > > Maybe we can even pass algo name instead of idx. > > > > > > Let's use name rather than index. > > > > OK. Any preference on the keyword? "name="? "algo="? "algorithm="? > > "compressor="? "comp="? > > > > I want use the same keyword for recomp_algo. I sort of like "algo=", > > but not sure. > > +1 with algo Minchan, I'm sorry I'm getting a bit confused (didn't sleep last night). I just saw your other email and you suggested there that we don't need any idx or name in recompress. Or did I misunderstand it?