From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 491C4C433FE for ; Fri, 4 Nov 2022 23:25:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A746B0078; Fri, 4 Nov 2022 19:25:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B296B007B; Fri, 4 Nov 2022 19:25:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E2376B007D; Fri, 4 Nov 2022 19:25:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8B4126B0078 for ; Fri, 4 Nov 2022 19:25:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3F8B012157D for ; Fri, 4 Nov 2022 23:25:51 +0000 (UTC) X-FDA: 80097344502.20.B54B58A Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf02.hostedemail.com (Postfix) with ESMTP id D6C8180006 for ; Fri, 4 Nov 2022 23:25:50 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so9570801pji.1 for ; Fri, 04 Nov 2022 16:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P8HZa0x37maTa++1KlKSVo9J5t91bCUk4WcF1knYOig=; b=OIk0wWKdO/WHASO4D6Va7QTPjpaYWUt1ibyoLOBpJLdLWmTBdlzTzK/i1twg7GVeZg XSfTqsV4TbocQsiyMn1fUy7MJn4sKDL/a8e/cdec1svaCSX8K6nGayZCFpO2Ue/AIENL wXysJzNEIGvMF0nJm6BFGllTX/4rWv/E12by0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P8HZa0x37maTa++1KlKSVo9J5t91bCUk4WcF1knYOig=; b=Lfm9YsvJ9G5ZcvRkdrUsT2BRntLfDGOsNs+QX88aeOduSW4tRYUL3cLfm8rlJC7ZfI rkDUEoUqPTE/BiuM7jC5VRJLTnAVN63tsnn10aWsVjBYgJ6QjfMKw5a/t7isy13bejI4 h8TlsCSAclqtdbc/XtJrfHsV3Ctu9b+eG/nUVrmElDvvtek+xCaCL1L6MXBsYiTCH4Wv /P9LDh+YQCOzDm0KhNieEiMELiQn3Co6Y46qzB4+1sSMwx4R9LuzGRdiZ+tYQOFgd9EI 0mA7rMWFtdI/7V6X1pZzjZFVxNmzqdRjT95kVTsSG0KA1q1N/RQVQcWmnoh6RgWbACTD bafg== X-Gm-Message-State: ACrzQf0IwMo9MMiOGmXdzR9REvhJ34QVTmw6Qq/05vIEtRdB2Of2XOQr 6yj52NKIFCQB8XH9q8SR+Z8XEw== X-Google-Smtp-Source: AMsMyM7iBqkri4YuVJ8gX0qgjTiLGhQ4ztkwcf2kUOu6yQfQbgWOf/iCwUQFQqHC6mnIW8j9xZDr5g== X-Received: by 2002:a17:902:f786:b0:180:6f9e:23b with SMTP id q6-20020a170902f78600b001806f9e023bmr38624968pln.37.1667604349762; Fri, 04 Nov 2022 16:25:49 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f2f6:8f5:87c8:3aeb]) by smtp.gmail.com with ESMTPSA id z12-20020a170903018c00b00180daa59314sm282198plg.125.2022.11.04.16.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 16:25:49 -0700 (PDT) Date: Sat, 5 Nov 2022 08:25:44 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OIk0wWKd; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667604350; a=rsa-sha256; cv=none; b=Gu2eyxNGt+GW4FzsnirtJU0hBM/cbCaVMWIp7yjSIERpOG1fqIrLTgK30M0zGX8Fc0p0bA ThDwrpDH9BJ3xktVsElnLraY8etciqmuTeUQHL1drEMkenFqZ6605qKIO3H2aU9zpr+Fn5 tBLHzUOFQjjMxzxqhKJXqlE/AAZeBsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667604350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P8HZa0x37maTa++1KlKSVo9J5t91bCUk4WcF1knYOig=; b=lWxQ1kOYYv/owDcHK3u4rt6IMR2V454C50r2iOKkou+2nU1GYsud19c1OzVUPvUO+b2xFI TaOvEzGfmAPOhiVox50escl8gNA3XAg9EIjv+cO/e7tISAZoVQN3Ho8KgH5HYvEr97YBk1 f6sgI3OCW1AwFQ6JpG4eHqVVPNGvaHo= X-Stat-Signature: 59ump4zopxoihm1781mmu8xhu9zurr1q X-Rspamd-Queue-Id: D6C8180006 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OIk0wWKd; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667604350-682549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000136, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/04 09:34), Minchan Kim wrote: > > > > So, as far as I understand, we don't have reason to add remove_recomp_algo > > > > right now. And existing recomp_algo does not enforce any particular format, > > > > it can be extended. Right now we accept "$name" but can do something like > > > > "$name:$priority". The only thing that we probably need to do is rename > > > > recomp_algo to either add_recomp_algo or register_recomp_algo? > > > > > > Yeah, I like the name and priority format. > > > > > > Only question is how we could support algorithm selection change > > > under considering multiple secondary algorithms. > > > > So what I was thinking about, and I'm still in the mental model that > > re-compression is a user-space event, just like writeback, extension > > of recompress sysfs knob with "algo_index" (or something similar) which > > will mirror algorithm priority. > > > > Example: > > > > Configure 2 alternative algos, with priority 1 and 2 > > > > echo "name=lz4 priority=1" > recomp_algo > > echo "name=lz5 priority=2" > recomp_algo > > > > Recompress pages using algo 1 and algo 2 > > > > echo "type=huge threshold=3000 algo_idx=1" > recompress > > echo "type=idle threshold=2000 algo_idx=2" > recompress > > > > Maybe we can even pass algo name instead of idx. > > Let's use name rather than index. OK. Any preference on the keyword? "name="? "algo="? "algorithm="? "compressor="? "comp="? I want use the same keyword for recomp_algo. I sort of like "algo=", but not sure.