From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6901C4332F for ; Fri, 4 Nov 2022 17:47:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DBE56B0071; Fri, 4 Nov 2022 13:47:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38C9E6B0073; Fri, 4 Nov 2022 13:47:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 253D86B0074; Fri, 4 Nov 2022 13:47:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 15CD86B0071 for ; Fri, 4 Nov 2022 13:47:27 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CF8ABA1514 for ; Fri, 4 Nov 2022 17:47:26 +0000 (UTC) X-FDA: 80096491692.08.E91F00F Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 6D62B8000C for ; Fri, 4 Nov 2022 17:47:26 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so7979279pjh.1 for ; Fri, 04 Nov 2022 10:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XrYnS8JhNYA90twtP47L3ZwTLaMR8mnWvEeKOdrs1f8=; b=qaYgQ7+1jZ1Kv2W+aHiz6Kyz3YuGKVJM0RtjnDFo2QSZasn3G8TGm+oQ58wjjeJVai 7Jft6TyegA/Rd5fZCMwfqe8/SNQU1uZN/FBEoB68vmgJZZ/wUP5FvHCSUZCgmOx6YE2q M42JzyglrT4gTBDnizSB/SRKAY27UUpzUoZGeq3yMU4FDp2EFspffIA3Uw93bdCLzlOr EsxBtdarf34/G2fFIdsyhZK/Vg8SLubX9iHokolm83NlNa3sQCBm9gS59W15zlAmWas9 71ynldxLFiFB9HNPfRV6qoLeP6dengYdmcvBYEfiBOLgNDzM4lPp/PEnp23u3DBzZW93 czSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XrYnS8JhNYA90twtP47L3ZwTLaMR8mnWvEeKOdrs1f8=; b=UG7ErKKGGXrY6gRqfhvFkNWXJC/XkvuYlldwZGuRpcAsks7p3KSYnXP4Ib1lQMP+vg oHSFVDz1h1FhhRBe5c8zQUpD9O3xcVCiozGRwUJoOsr+7kLV2dMJ9fdmrux51DOroYJJ 6X1/nhKCtY2pG15AirJ3+884xOWmOden6av5qAFbI37Eb0T+9O6JqkoiXek8YtHXrM7t wj2SvCYEd13pS8uXNopP9S3WFdkT7KaMoE7wwtiGAt+zVpgLvQbC31ynFzn4qNmPX2vy j0Mbp58mW2yw5qsquHVCp2YyjlJA2VVgakmlUKg9g06iTcSRWo7a3QcBILzBNfyyYmcd MdKA== X-Gm-Message-State: ACrzQf3OFvSOZLg63GMpsrdQsAd2QpS9u/ZYdjfobxb0otUo2sThVerG nn3z8yFwXR9ZjRaKir+d3Si191rYIuM= X-Google-Smtp-Source: AMsMyM7e+teCQsHQh4ualKatwWqt+w0DB4v/hwUDBsU/YZpqILIOVcY1yYQ3Jj5CkN+sFYoBPbeacw== X-Received: by 2002:a17:90b:2393:b0:213:ecb2:2e04 with SMTP id mr19-20020a17090b239300b00213ecb22e04mr26271755pjb.100.1667584045165; Fri, 04 Nov 2022 10:47:25 -0700 (PDT) Received: from google.com ([2620:15c:211:201:755f:cdcb:1bd8:5ad8]) by smtp.gmail.com with ESMTPSA id t8-20020a170902e84800b001785fa792f4sm24852plg.243.2022.11.04.10.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 10:47:24 -0700 (PDT) Date: Fri, 4 Nov 2022 10:47:23 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 4/9] zram: Introduce recompress sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667584046; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XrYnS8JhNYA90twtP47L3ZwTLaMR8mnWvEeKOdrs1f8=; b=YgbwMbg8c6QrHbcZEDS+Oe+3Ipxkp6uqcGUB2KvmzxVYICrapvcKVV79rFhm74/d8fYIK2 QeugzuAVa0Z0hYZn5B+AaQPIipZ81uw9vt7FIVXy1G+aRniV5LyCbe/3hpKrXfGsiRtW5R 6TW9Sduiz6piOP2vEyaHBFb5fJI0tCQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qaYgQ7+1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667584046; a=rsa-sha256; cv=none; b=yvnVqUNG6AmoH7J0tMEU0bBPCMTm08kXDOP7LbNBQa4tjKFqnmecGNOD6STLedfHlfKH/4 9PtDW+XNH8c0KPltTXm1zMvOzb3UyGw5fhLLoVRyd1j1ErLHGohuU860mSZehfAorOs4SN nrZQ3MpUefaFAiQxRHk6ZUSfdjULiRg= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qaYgQ7+1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D62B8000C X-Stat-Signature: n7f5ojmo9rn615i5ypj1ygebnczisgb9 X-HE-Tag: 1667584046-270280 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 04, 2022 at 04:53:13PM +0900, Sergey Senozhatsky wrote: > On (22/11/03 10:00), Minchan Kim wrote: > > zram->table[index].flags > > > > If we squeeze the algorithm index, we could work like this > > without ZRAM_RECOMP_SKIP. > > Something like this? > > Allocate two ->flags bits for priority and one bit for RECOMP_SKIP. > Two priority bits let us to have 3 alternative algorithms (01 10 11) > plus one default (00). So 4 in total. Looks good!