From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DE5C433FE for ; Fri, 4 Nov 2022 08:08:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78A916B0071; Fri, 4 Nov 2022 04:08:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73AC48E0001; Fri, 4 Nov 2022 04:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 602516B0074; Fri, 4 Nov 2022 04:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4BC946B0071 for ; Fri, 4 Nov 2022 04:08:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1C80A120268 for ; Fri, 4 Nov 2022 08:08:59 +0000 (UTC) X-FDA: 80095033998.09.0ACA4BE Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf29.hostedemail.com (Postfix) with ESMTP id A8BCC12000B for ; Fri, 4 Nov 2022 08:08:58 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id k5so3859718pjo.5 for ; Fri, 04 Nov 2022 01:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PNE4/+TJdC1epwove+2dQ4MoIHCeASG45k2ERB81ttk=; b=jvLgUz81AaSsUkBBNw0rIxUTwkDsPsfJL3yG+Q1m8hvoPabQL3jYMLIHvnL7o7efM3 OY4nL5C0ezKDjMbaN1oOKBgisiYuuOa9cEfHiNNi8n/U42tdRMolODVyLArAL1D6BSVZ mwhHI06OIgV6rTHDni7jzcchwxds0UearMStA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PNE4/+TJdC1epwove+2dQ4MoIHCeASG45k2ERB81ttk=; b=AG9dlIS50qVNquLnwblasifuu5FA7lX0hHlxyaykeKb8Oibmm1ZPcI87E54TynDMuH NaUpm8FSrtXMYF/821wKKyOsGjDzY0EtR3pYBzCp+Io4WxyyFs47JR/hHS+nFoZpdePK PrYx5g+efveXwFr/VwkrF9XNVAJw9xXlUL3advqON0d+RCvw1tURJeoiksqfPPNjSBdr P/a1KuyfJF3nkmqeagHpJ7HN13FixPRGjK/sBtYPaJCIPi72Ec4HrcM0L8ixQXdXZdqn Txi3F08xPYhTAuTivsDsm45tobF+l+OA6rC3hd+Mbx1SehR0DtTSAzbUIj7KxxJW4Lzq RJsQ== X-Gm-Message-State: ACrzQf2r5pZ4dgFUPqrYISh5VXX2hG4eByOZ+mN0nElT/dXOb9uJW/8U pcPx2u9P0k4wGml7m5ZAQ25ECA== X-Google-Smtp-Source: AMsMyM7XyPORBcVW/SHv1RIaXkxKX/g43vxC2PrBl/CGbEeB9WdP2jpSZ9ZaZn2kngbXEcmeqEIDYQ== X-Received: by 2002:a17:902:d4cc:b0:186:f57d:ba61 with SMTP id o12-20020a170902d4cc00b00186f57dba61mr34296152plg.97.1667549337608; Fri, 04 Nov 2022 01:08:57 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f2f6:8f5:87c8:3aeb]) by smtp.gmail.com with ESMTPSA id d8-20020a170902654800b00172f6726d8esm1901198pln.277.2022.11.04.01.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 01:08:57 -0700 (PDT) Date: Fri, 4 Nov 2022 17:08:53 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv4 4/9] zram: Introduce recompress sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jvLgUz81; spf=pass (imf29.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667549338; a=rsa-sha256; cv=none; b=Nx4pAkRlK/4iKY0Coh538r1mrMqe0/VQtsb0O3QhI9BLBigDrEFrspIpOyNBPKOUjeaapm UXcZJoJ3SeF9ouOdLGhvzrGWqsk/+U11vVKmyqGj/uXCy64lvoeGiajeQAeJEDSM6mim1F ZdpEP9uFxvI0y9Wk9opdoHqDKHuYN7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667549338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PNE4/+TJdC1epwove+2dQ4MoIHCeASG45k2ERB81ttk=; b=5QVc14MQT+Vb4iFmum/M+grRSm19Ojh5h500mmLQiY/chJQJUjbzNjQbAQ51GReCoA2FWh eV+ijEBTuIZk17xeutevMjbp/agKgWnKtm0YBxhLCs+Wpvwyxp9OQWT4txu0/ReMEf/+p8 ea7HDFpoaX2NCch0yKe8LQrBsw3Jr08= X-Stat-Signature: 3o6tpudhjd3bcp9rmdup5n6g1cqihd33 X-Rspamd-Queue-Id: A8BCC12000B Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jvLgUz81; spf=pass (imf29.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667549338-532556 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000738, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/04 16:53), Sergey Senozhatsky wrote: [..] > +static inline void zram_set_priority(struct zram *zram, u32 index, u32 prio) > +{ > + prio &= ZRAM_COMP_PRIORITY_MASK; > + zram->table[index].flags &= (prio << ZRAM_COMP_PRIORITY_1); > +} Uh... Something like this, sorry. +static inline void zram_set_priority(struct zram *zram, u32 index, u32 prio) +{ + prio &= ZRAM_RECOMP_PRIO_MASK; + zram->table[index].flags &= ~(ZRAM_RECOMP_PRIO_MASK << + ZRAM_RECOMP_PRIORITY_1); + zram->table[index].flags |= (prio << ZRAM_RECOMP_PRIORITY_1); +}