From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B69C4332F for ; Thu, 3 Nov 2022 22:00:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8902A6B0072; Thu, 3 Nov 2022 17:59:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840338E0001; Thu, 3 Nov 2022 17:59:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 707956B0074; Thu, 3 Nov 2022 17:59:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 61F5E6B0072 for ; Thu, 3 Nov 2022 17:59:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 21B9814154C for ; Thu, 3 Nov 2022 21:59:59 +0000 (UTC) X-FDA: 80093499318.08.F673BD9 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf04.hostedemail.com (Postfix) with ESMTP id B069A40005 for ; Thu, 3 Nov 2022 21:59:58 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id q1-20020a17090a750100b002139ec1e999so3070495pjk.1 for ; Thu, 03 Nov 2022 14:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BXMtoJhRlFWaQLcxjEM+qd1+6PF53F0Hz+I5xM4y+wc=; b=LSzE9TH+osvipk73Jg9gpor1ZQe37FTuPrWQ5VUxQIsLQ//7XAFuJQM1KyFIXYAxqx BE4yzuk+xifeQgNpMYonk3DPgvpHS7XYbgoNdLomm2aKEkQCHaH0Bc7mrZFzL+9j5ZSy b9DDF8m1+3bfZ9iV0lucJ1MqhbByVhp5MZXMvkd4dpduipcwth1ZiKn90EGRhJ8R9r+m EJ4boWxUG+nQ4ooKm3DZioH6mkJd/Le4V3cgspEcIdaCLQDHg98SssmSluKeW2l4jPay g1Az1Lvo9oZjC2k1yTkOvtryQxynTaEzmqQoj8oo4NJhMXBQYq056FnhoGgEMPlBjEct OTAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BXMtoJhRlFWaQLcxjEM+qd1+6PF53F0Hz+I5xM4y+wc=; b=fQ15ystOLJYlsI7x1AGxwWYvIAG4bdDUpcIxU1BB8UN13ZCb7e6D/CBZkWZxRCvR0M 5BA2yO2pCr0cAU4AkApCRojQmkaY5y7cYU5mZzv0TdQsxH2uTpWNSKZDesLHIbw/1dL+ yDxH2X2lov3jJj+NPaR92L1u1Km8kuvPdF8V8VsCN/nEtjKEr86uIlZ8tScw1cmWIHPD pmnr+vGFiwle0lvLomsavz7f4qdbckpCOmOhnMopiP3T9+Ewemt2NH8vZql4Cb4kXiEZ 4bJP7emhbCAA9LrztY+7PegpEz/I2XpnWmtI4JsLJQhAy7gMyUaY4nh9GfwHsKvom+BO oDQw== X-Gm-Message-State: ACrzQf1VYmO7r3PBBkK1d2tl+lgkNvE7gIkDk7ICajR+yeDGMC/HEe8j pxJRt4a7r0UrsxsV6MlVfNU= X-Google-Smtp-Source: AMsMyM7bULDdaNCNh0UvTT4e4bGiz6aC/rB81Sbmms9IVmh3til4gq09VVgLdxxc7KpN8RZNvnj8Zw== X-Received: by 2002:a17:90b:1c10:b0:213:1bb8:feb with SMTP id oc16-20020a17090b1c1000b002131bb80febmr49947295pjb.214.1667512797631; Thu, 03 Nov 2022 14:59:57 -0700 (PDT) Received: from fedora ([2601:644:8002:1c20::8080]) by smtp.gmail.com with ESMTPSA id 123-20020a621781000000b00562784609fbsm1184991pfx.209.2022.11.03.14.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 14:59:57 -0700 (PDT) Date: Thu, 3 Nov 2022 14:59:54 -0700 From: Vishal Moola To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, David Howells Subject: Re: [PATCH 00/23] Convert to filemap_get_folios_tag() Message-ID: References: <20220901220138.182896-1-vishal.moola@gmail.com> <20221018214544.GI2703033@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018214544.GI2703033@dread.disaster.area> ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LSzE9TH+; spf=pass (imf04.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667512798; a=rsa-sha256; cv=none; b=TU18NXP/b/2p/5CRWg3G+DrU8skEsgR4iGokKLXmnGMoAju3KS8IL3woOdY2JmSuW8wf2F qHKLv2tFZjU4en5LioFRCzXNWVewblWfnUZbN8uEalmYZjqd42mNdtQM+/pRAz0dQVzblB FPJlv46ubFGhxRD9IRAoOQrUlSIgc8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667512798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BXMtoJhRlFWaQLcxjEM+qd1+6PF53F0Hz+I5xM4y+wc=; b=lchvKgu83+YoMxuo3iiMEzpVSBiK/ciDBg5im1KbAmcS3qUvcZfvwTMDnP2GPk27GrcVX8 dU0NGoaIn96/ggV5CnbetfCkCM23zIuS/xUaH0VukO6+7QG44mmmwGaLmMrDjcVUh5PjLz eblnmPm/zDSsT/zSoyltnrlSyowdoJc= X-Stat-Signature: axzgz3bhnku4wdohrubum1dcsq4fuhee X-Rspamd-Queue-Id: B069A40005 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LSzE9TH+; spf=pass (imf04.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667512798-124694 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 19, 2022 at 08:45:44AM +1100, Dave Chinner wrote: > On Thu, Sep 01, 2022 at 03:01:15PM -0700, Vishal Moola (Oracle) wrote: > > This patch series replaces find_get_pages_range_tag() with > > filemap_get_folios_tag(). This also allows the removal of multiple > > calls to compound_head() throughout. > > It also makes a good chunk of the straightforward conversions to folios, > > and takes the opportunity to introduce a function that grabs a folio > > from the pagecache. > > > > F2fs and Ceph have quite alot of work to be done regarding folios, so > > for now those patches only have the changes necessary for the removal of > > find_get_pages_range_tag(), and only support folios of size 1 (which is > > all they use right now anyways). > > > > I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be > > beneficial. > > Well, that answers my question about how filesystems that enable > multi-page folios were tested: they weren't. > > I'd suggest that anyone working on further extending the > filemap/folio infrastructure really needs to be testing XFS as a > first priority, and then other filesystems as a secondary concern. > > That's because XFS (via the fs/iomap infrastructure) is one of only > 3 filesystems in the kernel (AFS and tmpfs are the others) that > interact with the page cache and page cache "pages" solely via folio > interfaces. As such they are able to support multi-page folios in > the page cache. All of the tested filesystems still use the fixed > PAGE_SIZE page interfaces to interact with the page cache, so they > don't actually exercise interactions with multi-page folios at all. > Thanks for the explanation! That makes perfect sense. I wholeheartedly agree, and I'll be sure to test any future changes on XFS to try to ensure multi-page folio functionality. I know David ran tests on AFS, so hopefully those hit multipage folios well enough. But I'm not sure whether it was just for the AFS patch or with the whole series applied. Regardless I'll run my own set of tests on XFS and see if I run into any issues as well.