From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A4FC4332F for ; Thu, 3 Nov 2022 17:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ED066B0074; Thu, 3 Nov 2022 13:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39DE26B0075; Thu, 3 Nov 2022 13:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2655E6B0078; Thu, 3 Nov 2022 13:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 170B76B0074 for ; Thu, 3 Nov 2022 13:11:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DFEB641524 for ; Thu, 3 Nov 2022 17:11:15 +0000 (UTC) X-FDA: 80092771710.17.9815862 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf01.hostedemail.com (Postfix) with ESMTP id AF00240010 for ; Thu, 3 Nov 2022 17:11:13 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id io19so2525255plb.8 for ; Thu, 03 Nov 2022 10:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=EyEaiXYwGZ66+eMx05Q+3jfcs0ljEUn1snD5FexMKL8=; b=A8fXGXXAcSb8wP6STdb3cm24s8EfdklK5O49e41+AWr+xMmeIcMh3Fa3jgTVN1ZXks hLpfF1BKpLP3StIca1AM4j41UaEAXPWH7qMdzzQHXmYG0qFT+nPAYWw4L0bKuJ1B+kNP voWIeMOvv7SwoFqzlGJDm0efaNkKZcmRr+Zk98VfWoV8zzRW9yiLUZ1/rzBVcI68bVDc fznnlq1+dPNdvGjSexG/PsOZAxivX5KtC3EBe3KQ5HWIs1uQfKMhFwZOPXC8qrVVvrLl eyodCLe2TpOK3nLQDX0vITvS4WIPpkUlhCDOfzI56DXe2zURNZmMZ3aNjl8i2yHlZ8tS t04A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EyEaiXYwGZ66+eMx05Q+3jfcs0ljEUn1snD5FexMKL8=; b=cq6BXHO0dwlrDYKSr8JjVtt8XedpzERzjVqQwbvsG4/dkOxLo4fB4+glVFFbnt3aRg wVkgbYo11Fwc6l2jZKA9foanKiSn2Fx7kRh+mNDWAiQR6Db5mXl35xk5qsl7wipjYtcz JWsL5+VGBDD9+2uX/8kZmwXItzxfPO3m5A+7be1btoqLaRrfVEaDJptXJ4oyF8i6ssUJ O5vFO609d4Mj3Tx4/gKf0wFm3ktVLAm6u8TLEbSzrFrilHEvid/Yd7sBYM90FO5A9tLz HU63YmQz0WToKdeDmCRAal7oS5yTBmBirdSNSGhi62Rfg40oXZ/A5kkiGcgybeDk3r5Q sJVA== X-Gm-Message-State: ACrzQf1lmi/znl9IhQ35XVJUwh7NUycvvLy1M/f5o1xwvnO0rU8GDHB1 yODHobrKNur+P8T48D4NikJyb8UbeTQ= X-Google-Smtp-Source: AMsMyM5Nr6JzpD4MArJro/efIP53SmH1+6Ydpi9jLmS/lV1d1RhxHIShehkJYiPGH0xwvWHOVjouMg== X-Received: by 2002:a17:903:292:b0:186:dae9:c089 with SMTP id j18-20020a170903029200b00186dae9c089mr30644140plr.31.1667495472577; Thu, 03 Nov 2022 10:11:12 -0700 (PDT) Received: from google.com ([2620:15c:211:201:3d65:7dc2:c62a:5d98]) by smtp.gmail.com with ESMTPSA id j36-20020a635524000000b0046ec7beb53esm1040263pgb.8.2022.11.03.10.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 10:11:12 -0700 (PDT) Date: Thu, 3 Nov 2022 10:11:10 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667495473; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EyEaiXYwGZ66+eMx05Q+3jfcs0ljEUn1snD5FexMKL8=; b=nfiNDy8JbihZaMkbZ2uirp0/6XLo6NrD7aX1Z18Z2ZpkbP9t0/6nlDDs90eUpP6CcmwzsR 7ByiVe0Tn0jWL1SHf/2ZoXetevs97YSgJDBOoyhMYAaCbq4+kLvZpcWxT/kk9R0hMnP6ui z+QlcIBR9P9dybwu938TNFzKuBRdhzA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=A8fXGXXA; spf=pass (imf01.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667495473; a=rsa-sha256; cv=none; b=EseinLkAdYujIO7Y6x6Eh2iaqsntfqjfuZKgUmdXiCq4FEofCZ6xgdl29dvF8KhP/lbjwB IqNp4tEKEfEfWoUKGS7qDVYRrXnulk8wr1VZBnGHTu3VQQ+abtBfV0w6UM//XVP3dpNJ+K YoyDCubzcQ+UKSStKE4tgaZA2hvYe2k= X-Stat-Signature: eksehzaiytjb86jfqe57h6tunodorun9 X-Rspamd-Queue-Id: AF00240010 X-Rspamd-Server: rspam06 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=A8fXGXXA; spf=pass (imf01.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1667495473-724986 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 03, 2022 at 01:09:49PM +0900, Sergey Senozhatsky wrote: > On (22/11/03 12:05), Sergey Senozhatsky wrote: > > What is the use case for removal of a secondary algorithm? > > > > > My point is that we don't need to implement it atm but makes the > > > interface to open the possibility for future extension. > > > > > > What do you think? > > > > So, as far as I understand, we don't have reason to add remove_recomp_algo > > right now. And existing recomp_algo does not enforce any particular format, > > it can be extended. Right now we accept "$name" but can do something like > > "$name:$priority". > > Or with keywords: > > name=STRING priority=INT > > and the only legal priority for now is 1. I like it.