From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1B7C433FE for ; Thu, 3 Nov 2022 17:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A8C66B0072; Thu, 3 Nov 2022 13:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8592C6B0073; Thu, 3 Nov 2022 13:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7207B6B0074; Thu, 3 Nov 2022 13:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 61BD86B0072 for ; Thu, 3 Nov 2022 13:10:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 39C02ABDF2 for ; Thu, 3 Nov 2022 17:10:47 +0000 (UTC) X-FDA: 80092770534.12.D2D79B0 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf29.hostedemail.com (Postfix) with ESMTP id AB17A120009 for ; Thu, 3 Nov 2022 17:10:46 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id b21so2525909plc.9 for ; Thu, 03 Nov 2022 10:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/Zw/xbrx1mfYNmLCyYGWO3RwLiclCaks9djofi27mHQ=; b=Y3+twozvFsaxlvdGpWADTdQU3zUwjGsS2nxkmdv6zVXX4LBt31WCsHVISg4/3lopgM KyLl5QDy60CRumW9iiYkm76Nz8jXVNx5ExoUV8OEl8uAMg2ytTWn/NnASUwNxQfPoQw5 2Wb5y+FbNiM40s3VaiatAIiqlbyR24Cl1Fwp8AqTmm/33aJy2rWJRo900bwT6vGcE2TP uLwbznp1CMg7CwGexGPli7T8ZICgQwFkTod7srBnp5tO2PIotLLVCYMYubH9r5eSG5DH LE8eVKT2CKnzBDAvVl5q6KWk8PDKI0B63mtwxDrLIp7EsWf/KXbNrAzYU2+jR8GSbrMm f21A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Zw/xbrx1mfYNmLCyYGWO3RwLiclCaks9djofi27mHQ=; b=ru3ETOuNyHrJZGQsoylEKknZ2idD+cdTNCRZCZcsrvaJphl7e17b2WUl5zbNJ6yX/+ S9j+iGkcvtc/81ktzWgttfouvITdWKp6BLJQuR3onwozxSfzCo/YGRzzrYV4JRx/A5u+ V11IdgqjGG7lVRF3tPpGmuRaRInvgitSvcbpgi1VPALNY3J0U6DHluO+Hem+9V2qn+3a h+2cGeXB6LoJ6dURVKz19b7sDLhlIMhWW2Yl9B1sAKysW6v9MIo2FcqGC0I5ln11T/Na P4JU4NvlDVT9GfjmePknCHARRRCbVy8OX/XlSge5C8v6W8/v09YeMjYaBzjqViq25Dmw RoMw== X-Gm-Message-State: ACrzQf1DBR9lWQ8PulToP/Qm/Qk6zqTFWMZZlELq3JVVVe/huRVQ7oLu W0VYemFzvnwau9XKdwRES/U= X-Google-Smtp-Source: AMsMyM4DEgOZ5StLPoF3czSLE+zMqwxW+raJTUzURNiiYqiiy+SeY2VS8B6fRLlQ1Rz61sjl+zn5sw== X-Received: by 2002:a17:902:e402:b0:186:6f1d:b463 with SMTP id m2-20020a170902e40200b001866f1db463mr30548171ple.23.1667495445609; Thu, 03 Nov 2022 10:10:45 -0700 (PDT) Received: from google.com ([2620:15c:211:201:3d65:7dc2:c62a:5d98]) by smtp.gmail.com with ESMTPSA id w8-20020aa79a08000000b0056d98e31439sm1011141pfj.140.2022.11.03.10.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 10:10:44 -0700 (PDT) Date: Thu, 3 Nov 2022 10:10:42 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667495446; a=rsa-sha256; cv=none; b=IdozhUAqgkEPahHeo1hrBujg9yDOnOuXo3Ufjm5+4096PY/DTZQjiVvrAjZitaIk/koKm2 BmiBWfyhOudx1foszF+yJ2JJ01sV4ABPOpZqejrpqH5GxOxpWGRMfIjy+cjgegxMWKEGoF enEVPuiGe8z07hAGZz3s7JSY6NsL+Dw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y3+twozv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667495446; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Zw/xbrx1mfYNmLCyYGWO3RwLiclCaks9djofi27mHQ=; b=ibfqLPjBMO1ajAjVqFA4WP0go1hC9/nNSoPBewohiXeTo7rrGqJpbt8k/Bdv34AQ/PPvhC hnQ0uc9ugZGkgF6lqK9+dS0sIcW4FUHPnwlEaoDG61sws3hMa3Fu9tlz0hRvaKBuX+pSwo c8Yjh4q3KoNL/GtAqg7vMku0gfSa9pY= X-Stat-Signature: 7rip8j6wwq9s1jxy8n7bgihhg77a46be X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AB17A120009 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y3+twozv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-HE-Tag: 1667495446-274782 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000181, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 03, 2022 at 12:54:43PM +0900, Sergey Senozhatsky wrote: > On (22/11/03 12:05), Sergey Senozhatsky wrote: > > [..] > > > Just open question(I might be too paranoid?) > > > > > > I am thinking someone want to add third comp algorithm in future > > > to balance decompression and memory efficiency. > > > > > > If it's not too crazy idea, let's think about the interface. > > > Maybe, could we make the recomp knobs works like list? > > > > > > # A primary comp > > > echo "A" > /zram/comp_algo > > > > > > # Multiple secondary comps > > > echo "B threshold" > /zram/add_recomp_algo > > > echo "C threshold" > /zram/add_recomp_algo > > > echo "D threshold" > /zram/add_recomp_algo > > As a side note: > The way it's implemented currently is that comps is an array, so we > can store more comps there. I sort of was thinking that we probably > can have more than two algos at some point the in the future (hence > the MULTI_COMPRESS config option). Sure.