From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653B3C433FE for ; Thu, 3 Nov 2022 07:54:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8E6E8E0002; Thu, 3 Nov 2022 03:54:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3EA58E0001; Thu, 3 Nov 2022 03:54:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D5F8E0002; Thu, 3 Nov 2022 03:54:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A357D8E0001 for ; Thu, 3 Nov 2022 03:54:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68CE3120B15 for ; Thu, 3 Nov 2022 07:54:40 +0000 (UTC) X-FDA: 80091369120.28.3C1BC21 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id DB8C520004 for ; Thu, 3 Nov 2022 07:54:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 670351F9D9; Thu, 3 Nov 2022 07:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667462078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZM9LhN3P2GxaaPs4LSOfA8xH8G9/wFb+4rPYKngHJ3Q=; b=Oqkj4/NswNgplx+SQ4vtZD2QboDgr1eI3hNWOXzocEBXUKG0iCAT7l/F8pi9iaEHnRqZut uurLdPFU1pifoykyt1MALef2CzmgrrRl2E6mRcgmcuvMM6RFEoL5uSCxGJNRj7L2KHN6ZW vrSp9OO3p10uv3Y7revg1iBWEU4PstA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3B5CB13AAF; Thu, 3 Nov 2022 07:54:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4SI0DL5zY2O5KQAAMHmgww (envelope-from ); Thu, 03 Nov 2022 07:54:38 +0000 Date: Thu, 3 Nov 2022 08:54:37 +0100 From: Michal Hocko To: Yang Shi Cc: Zach O'Keefe , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Davidoff , Bob Liu Subject: Re: [PATCH] mm: don't warn if the node is offlined Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667462080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZM9LhN3P2GxaaPs4LSOfA8xH8G9/wFb+4rPYKngHJ3Q=; b=VU7/joQw3yfaTSlHkflOvZtgrBLtzRM9k4sCptvU4Tk8yLj5cc4emfKZnHaSOjkyoFPyIz MjFdWI9SfHkdxr/eYMrcwRc/AAkSJwMVR76jHurtO8g0oAcUMfM5dmDcamnrN+mCX3P1Eh RpzJMY06KIisNs1NSid+1hdj3i9wuG8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Oqkj4/Ns"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667462080; a=rsa-sha256; cv=none; b=QR6jFY2jSFuHEVg9Fpuhjrmi2kHFuVdZR2COvTW15nteNHvDCJZs11BXxMZB7R4SpAZztu t6Eq9l69yVPRmnFynF3wNa5euRnlu7MF9//SlBk7bGUgzN1W9dx995xWSKmybHZnxdFanX UGRuvTvuMen0k64vQNKraiehmXhIdTY= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Oqkj4/Ns"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DB8C520004 X-Stat-Signature: bze5kuahhzmfmkjaaycdffcptztf4t5q X-HE-Tag: 1667462079-374921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 02-11-22 13:08:08, Yang Shi wrote: [...] > So I think we narrowed down to two options: > 1. Preserve the interleave behavior but bail out if the target node is > not online (it is also racy, but doesn't hurt) I do not think there is merit in the interleave patch is dubious to say the least. > 2. Remove the node balance code entirely Yes, removing the balancing makes sense but I would still hope that we do not fail too easily if the range is populated on multiple nodes equally. In practice it will likely not matter much I guess but setting up all nodes with top score is just easy to achieve. -- Michal Hocko SUSE Labs