From: Michal Hocko <mhocko@suse.com>
To: Yang Shi <shy828301@gmail.com>
Cc: Zach O'Keefe <zokeefe@google.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Andrew Davidoff <davidoff@qedmf.net>, Bob Liu <lliubbo@gmail.com>
Subject: Re: [PATCH] mm: don't warn if the node is offlined
Date: Thu, 3 Nov 2022 08:54:37 +0100 [thread overview]
Message-ID: <Y2NzvfCjd0X4g4p4@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHbLzkouJkixT0X_uGTrFj_qCyYikpr2j3LOo50rsY_P9OS8Xw@mail.gmail.com>
On Wed 02-11-22 13:08:08, Yang Shi wrote:
[...]
> So I think we narrowed down to two options:
> 1. Preserve the interleave behavior but bail out if the target node is
> not online (it is also racy, but doesn't hurt)
I do not think there is merit in the interleave patch is dubious to say
the least.
> 2. Remove the node balance code entirely
Yes, removing the balancing makes sense but I would still hope that we
do not fail too easily if the range is populated on multiple nodes
equally. In practice it will likely not matter much I guess but setting
up all nodes with top score is just easy to achieve.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-11-03 7:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 18:31 Yang Shi
2022-10-31 21:16 ` Zach O'Keefe
2022-10-31 22:08 ` Michal Hocko
2022-11-01 0:05 ` Zach O'Keefe
2022-11-01 7:54 ` Michal Hocko
2022-11-01 17:12 ` Yang Shi
2022-11-01 19:13 ` Zach O'Keefe
2022-11-01 20:09 ` Yang Shi
2022-11-01 22:05 ` Zach O'Keefe
2022-11-02 7:39 ` Michal Hocko
2022-11-02 7:49 ` Michal Hocko
2022-11-02 16:03 ` Yang Shi
2022-11-02 16:15 ` Michal Hocko
2022-11-02 17:36 ` Yang Shi
2022-11-02 17:47 ` Michal Hocko
2022-11-02 18:18 ` Yang Shi
2022-11-02 18:58 ` Zach O'Keefe
2022-11-02 20:08 ` Yang Shi
2022-11-02 20:21 ` Zach O'Keefe
2022-11-03 7:54 ` Michal Hocko [this message]
2022-11-03 17:13 ` Yang Shi
2022-11-03 7:51 ` Michal Hocko
2022-11-02 7:14 ` Michal Hocko
2022-11-02 15:58 ` Yang Shi
2022-11-02 16:11 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2NzvfCjd0X4g4p4@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=davidoff@qedmf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=shy828301@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox