From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F898C433FE for ; Thu, 3 Nov 2022 02:40:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7E128E0002; Wed, 2 Nov 2022 22:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2D8D8E0001; Wed, 2 Nov 2022 22:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F52D8E0002; Wed, 2 Nov 2022 22:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 905D28E0001 for ; Wed, 2 Nov 2022 22:40:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 64B32401C8 for ; Thu, 3 Nov 2022 02:40:38 +0000 (UTC) X-FDA: 80090577756.16.1035009 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 0FAB840006 for ; Thu, 3 Nov 2022 02:40:37 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id h14so351223pjv.4 for ; Wed, 02 Nov 2022 19:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1CzhzdOGNk13VZOPHqdFQ974H6LQTp0JJL8W4fRoN5g=; b=PMyXnCNlzvObOAbZcR73hloc5uKhp2Amt6NbgXVUhwlFycH6Niqq+RfJcl6/7t8uKd RFtt2F2mJ2SEw3Rm4bqTzOqMLQtIm3PwgOHH2+dqtpP8Oe+TTy+LDcOwClLpcC92VVhR c3zwLx1lt1kTYo8yZCpa1DyQ/dvScj7HtilDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1CzhzdOGNk13VZOPHqdFQ974H6LQTp0JJL8W4fRoN5g=; b=iU/LEs2FyYvUifNyhKZDGJFw92yTtf+UH1SSrQi6kOw3K4JbTpB8Xg2lxa5vfjAvip ZPqtmvwQJkQDG454r/uywxfPQT/UxPLbloy7lr5EhnBPyBXAbXAjEhiVbmtejowVsvPV SOY4fcsH0OvoSxExKycStXs/H9dhaFqiv1iqanjjOXBqHQyO/xFpw6WMDMy8K8AjSRq5 0hWqS6TUvpd6ssicyy4PXEOpBV7UOEZ6MWOcrbYb7EWT7st3/01wvl3dv3Chv5pLr1uW vypgURFk5f7eWELV4IguJbbreFrQS0K09cr+5s0T4S2FN3i1HEPQdsMe+g33ujbm4H4Z ZusA== X-Gm-Message-State: ACrzQf3O4dEuXX+3zeYyIY0ukWm/FZroLozm64qAkxnp9Asma8w1Y5kk Or6/4ODcjZJ4QKaQL8CIb/P7Mw== X-Google-Smtp-Source: AMsMyM6c2ziFWR9wmPwV8A7mix313F2P4V67TFhErnUDnURE5Xxou/a6n8C+ZqXlV9njPP5XK5yq3g== X-Received: by 2002:a17:902:b10d:b0:187:29fe:bda0 with SMTP id q13-20020a170902b10d00b0018729febda0mr15989343plr.16.1667443236924; Wed, 02 Nov 2022 19:40:36 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f22:e30:374d:5a2b]) by smtp.gmail.com with ESMTPSA id k3-20020a170902ce0300b00176b63535adsm8984925plg.260.2022.11.02.19.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 19:40:36 -0700 (PDT) Date: Thu, 3 Nov 2022 11:40:31 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 1/9] zram: Preparation for multi-zcomp support Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-2-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PMyXnCNl; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667443238; a=rsa-sha256; cv=none; b=arBlYp4v2GX+9ky9HobHSAr4Xkv0u/botOCfrxXSuqphFtIazElCLkAiAgZ9rAJlJMMvB5 Ii0mYNLo0qX0U1WZQKHGUsErqhQ1ezjTeUp95j2pLzkjG0aQDyYCOFKFHhz9/loaxps4O9 3EyqEZOvmn+zUD2nS+NcLxSDRwZB568= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667443238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1CzhzdOGNk13VZOPHqdFQ974H6LQTp0JJL8W4fRoN5g=; b=QDEbo/SnGLH4FH8ejPqrWeQjfRxeVOD+iLZYwxVWKIRt6xdmCJoyeCDCsLDb+Tz4r34iHk F+rIB1/3CFyqqmkZ4VG9Sa0DBKJwHh03PW4u0Masp6FvRv5860D7jxvZL0G/wLdM4UsH+x 5517WQ37A+26tZGWbLZ2EoiM9/EGIOY= X-Stat-Signature: dj3jszc118ft4yqka79sidsp9jdhrhk8 X-Rspamd-Queue-Id: 0FAB840006 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PMyXnCNl; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667443237-678810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002952, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/02 13:13), Minchan Kim wrote: [..] > > > > +static void zram_destroy_comps(struct zram *zram) > > +{ > > + u32 idx; > > + > > + for (idx = 0; idx < ZRAM_MAX_ZCOMPS; idx++) { > > + struct zcomp *comp = zram->comps[idx]; > > + > > + zram->comps[idx] = NULL; > > + if (IS_ERR_OR_NULL(comp)) > > nit: > > Why don't you use just NULL check? I don't see any error setting > for zram->comps(Maybe later patch? Will keep check)? A defense measure. zcomp_create() returns err pointer, so here I check for err and nil just in case (if somehow someday we accidentally have err values stored in comps). It's cheap and safer than NULL.