From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F84C433FE for ; Thu, 3 Nov 2022 02:44:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE2D8E0002; Wed, 2 Nov 2022 22:44:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1677D8E0001; Wed, 2 Nov 2022 22:44:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0081E8E0002; Wed, 2 Nov 2022 22:44:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0CE18E0001 for ; Wed, 2 Nov 2022 22:44:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B0C91120292 for ; Thu, 3 Nov 2022 02:44:03 +0000 (UTC) X-FDA: 80090586366.27.057B6FF Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf21.hostedemail.com (Postfix) with ESMTP id 601201C0004 for ; Thu, 3 Nov 2022 02:44:03 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id q1-20020a17090a750100b002139ec1e999so574275pjk.1 for ; Wed, 02 Nov 2022 19:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bj1OXM86++Ax5WK9NQpXE8onmLsfEj10gyUi+TO3JfE=; b=ROLVFzyL5oaa51yfOrh3XK/kCTxN0hPymFWPR3PKxJnXkCAX0o6mTw6kJ3TcfIvztf G+Z9C5gJr3mVzv8rtbVtGHhvr4Px83/zMQ8VKbOhbEo1+x4vWdAG2CvE1ytt1MJtR/Io UoLUAPfhJMtiwLBIwi0KIOH6ZXSixbLexAT9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bj1OXM86++Ax5WK9NQpXE8onmLsfEj10gyUi+TO3JfE=; b=hF8voTwt0kiq6NK+9+w5hZGueyN4IzmpZywO3kUDpPx050NNroCOKS8RQdENKYBkTH dXORwrO4HF9xcxVN1lPk1O8yuu/3TER1W1S8boL7C1ULc8s18k6XIuGyY8Q5oOIwjx1+ 94yU9DYsgiB7CmZv+r+u5e/5sBtIuSK0YCl0yUep7qwSt3ufoa7nQVTDJPRiC5vFMA8U jKaxpd771A8Q32o4RVYAF9ElOOKeA8LiE9ZwM6v9a6t14FbP9cf2ZTzlUuCClghYoF/X /XtAUbX+0crWyWBDsec3iACxC/tc9SHoSJi8BlWrvwqiRn3sk0mbCCrhbZ5OBuNrHz3C AdKw== X-Gm-Message-State: ACrzQf1wxvB+FDkNXk9HdBC1vc0qRPZEUduDjnCfzLxFb1MR9nRncPZ/ mGWM+hAyfbhoxYNseGYvQsp3Nw== X-Google-Smtp-Source: AMsMyM7HkYl3D9Gi70kLV6hQTPnEikEh/jsu9Z67wnN9zuwHwNyPp7zjL2gw3L8jRdkl8Nx3hPmDDQ== X-Received: by 2002:a17:902:7294:b0:187:146c:316f with SMTP id d20-20020a170902729400b00187146c316fmr22170504pll.149.1667443442354; Wed, 02 Nov 2022 19:44:02 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f22:e30:374d:5a2b]) by smtp.gmail.com with ESMTPSA id i7-20020aa796e7000000b0056b2e70c2f5sm9103526pfq.25.2022.11.02.19.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 19:44:02 -0700 (PDT) Date: Thu, 3 Nov 2022 11:43:58 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 3/9] zram: Factor out WB and non-WB zram read functions Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667443443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bj1OXM86++Ax5WK9NQpXE8onmLsfEj10gyUi+TO3JfE=; b=N3X/stnZIK/ZCLwCb1HQcE5HZmXxs2M+DyK8guLy6qpPgbwlI484hidzcfKic4IVaI4xrw kaD+GGlQ/TjRMmScgfFSpkB0XZ1IuUf6gKkw2yZxzSvyc1QnxlhQ3s4O5WzYWaNz5fW3n4 ftMIMPdUwYM0GVotxJRHqYaiMBM4q08= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ROLVFzyL; spf=pass (imf21.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667443443; a=rsa-sha256; cv=none; b=f6wK9iYzk5PjlFa2olFQFOWfFAdJxIM7Vo7BtGnnpOe/Gja0lPL/r+uFkgiU7aUmC6610w MUefbPlakp1q6OZpxWZa3NGIgls+hwgeJZzWT/XOPlxz5rTkxIaWLWjcECXESA60by7qVc er39ItANpKY4QCeoHploQ52WV1eCLho= X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 601201C0004 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ROLVFzyL; spf=pass (imf21.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: zrhpseg694rz1bztcogyihb7g639n1z8 X-HE-Tag: 1667443443-225088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/02 13:20), Minchan Kim wrote: > On Tue, Oct 18, 2022 at 01:55:27PM +0900, Sergey Senozhatsky wrote: > > We will use non-WB variant in ZRAM page recompression path. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/block/zram/zram_drv.c | 73 ++++++++++++++++++++++++----------- > > 1 file changed, 50 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > index a8ef3c0c3dae..94c62d7ea818 100644 > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -1314,8 +1314,30 @@ static void zram_free_page(struct zram *zram, size_t index) > > ~(1UL << ZRAM_LOCK | 1UL << ZRAM_UNDER_WB)); > > } > > > > -static int __zram_bvec_read(struct zram *zram, struct page *page, u32 index, > > - struct bio *bio, bool partial_io) > > +/* > > + * Reads a page from the writeback devices. Corresponding ZRAM slot > > + * should be unlocked. > > + */ > > +static int zram_read_from_writeback(struct zram *zram, struct page *page, > > How about zram_read_from_bdev? As far as I can see, we already have that one, so that name is already taken. We have read_from_bdev, read_from_bdev_sync, read_from_bdev_async, and probably some more.