From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D02EC4332F for ; Thu, 3 Nov 2022 03:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 700AF8E0002; Wed, 2 Nov 2022 23:54:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A928E0001; Wed, 2 Nov 2022 23:54:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AF98E0002; Wed, 2 Nov 2022 23:54:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40CEA8E0001 for ; Wed, 2 Nov 2022 23:54:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0B81E806D2 for ; Thu, 3 Nov 2022 03:54:50 +0000 (UTC) X-FDA: 80090764740.03.44F1A57 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf26.hostedemail.com (Postfix) with ESMTP id A8547140002 for ; Thu, 3 Nov 2022 03:54:49 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so4024238pjc.3 for ; Wed, 02 Nov 2022 20:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OJiPqyKG7qkpi2KSk0a4gpC5uX6Azw5NbmCuDumKLuQ=; b=OJ2UavJdv6Ap58NAI4f8cl1JKxdpunJfWpAXBe2WDOpwElPbSw0vLeX+oWC6y6CeY2 avbQA5sVZ+cK0wr7mvSm9TVxJUXm6lqKGYP7zBzl0BFSPi4j4SrekamltEfGM59oysBg ZJK7NyaKcvRbaUUDJUMgGiP3/o1yfnF0FduP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OJiPqyKG7qkpi2KSk0a4gpC5uX6Azw5NbmCuDumKLuQ=; b=BAymeeZgiHxBG4H3tWLCi8IQwoqUMIUx6pZECheggfPoBj2FyoOkWPmrjr5Ms4Q7fm VI6XePaecwBQLu0OqXd2zvgURbsktw5J19IQFBeNRVmFo/7tGXjcLA3r4wAfoeLr80+o BecmWMU6EhEMsExVO9I50Orgibj5w/Q2o7MdlOHrtuRVtMi8IlGREbHMTH0x6fkNTckX vGIWw3w8VNk48OlSV4xZ+p42USiXANjuCIQpSgEGVJ6riet6A4pHPaRG0OHKr2o1z7wy 35uFswO06nOcr3DaOf8FXZaAqmrE5VdEW6AA/LRcAfa1Gv7EpohTXlz5ds9eb/KllGDd ptCw== X-Gm-Message-State: ACrzQf2mxRacecRsGC0yVM7USynB8tsnyEcuEeWTeNAis+hzcQ62a/xX nqo15dWexDGuCoocJV4K2oRvTA== X-Google-Smtp-Source: AMsMyM7TwFRz43Wuxf3h7IChzSXvD57HT2cm/P51xVhWnid2oadAqibgbmmJyu1UagtUG7Dk5Y4eMA== X-Received: by 2002:a17:902:860a:b0:186:7eab:afa2 with SMTP id f10-20020a170902860a00b001867eabafa2mr27968051plo.46.1667447688504; Wed, 02 Nov 2022 20:54:48 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f22:e30:374d:5a2b]) by smtp.gmail.com with ESMTPSA id c90-20020a17090a496300b00203ab277966sm2236283pjh.7.2022.11.02.20.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 20:54:48 -0700 (PDT) Date: Thu, 3 Nov 2022 12:54:43 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667447689; a=rsa-sha256; cv=none; b=Yk3QkDDBYbcD79gVvzTotjE2Q1g7WmDMWga4kd+4D/43+AsSIt65T6narGUC9Z27qvhRMw co76sRQoHfAvAyDu2BlAvwx9afmDCB8osSJHjudZxfqCYKWfU1Les0cKx8WTgG5+48mpC+ dYmugQ9E4tMukVoGymPsfAATpK1ZzEE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OJ2UavJd; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667447689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OJiPqyKG7qkpi2KSk0a4gpC5uX6Azw5NbmCuDumKLuQ=; b=XAZb3DkwouXgoIf9JBBao9m5Je9wjoWa8kRMheqmhKuAoSFM5beh9oru6qLLvvvfNFbYc3 tQdjdHDCFCYDRqxj9SEMXvIchn1u2aej7tjGpl6u/ThWlifASLbw5I0qSqzB9vu5vhq+Oj /Ipy6OxeSMBvP3CPaPxncpbhMSTdNLI= X-Stat-Signature: t6d6hpa7ctdidi4npb8mccjz75as4mbh X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: A8547140002 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OJ2UavJd; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1667447689-102854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.004986, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/03 12:05), Sergey Senozhatsky wrote: > [..] > > Just open question(I might be too paranoid?) > > > > I am thinking someone want to add third comp algorithm in future > > to balance decompression and memory efficiency. > > > > If it's not too crazy idea, let's think about the interface. > > Maybe, could we make the recomp knobs works like list? > > > > # A primary comp > > echo "A" > /zram/comp_algo > > > > # Multiple secondary comps > > echo "B threshold" > /zram/add_recomp_algo > > echo "C threshold" > /zram/add_recomp_algo > > echo "D threshold" > /zram/add_recomp_algo As a side note: The way it's implemented currently is that comps is an array, so we can store more comps there. I sort of was thinking that we probably can have more than two algos at some point the in the future (hence the MULTI_COMPRESS config option).