From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1023AC4332F for ; Thu, 3 Nov 2022 04:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82DD58E0002; Thu, 3 Nov 2022 00:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DE598E0001; Thu, 3 Nov 2022 00:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5978E0002; Thu, 3 Nov 2022 00:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E6778E0001 for ; Thu, 3 Nov 2022 00:09:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FC75AAE58 for ; Thu, 3 Nov 2022 04:09:55 +0000 (UTC) X-FDA: 80090802750.26.37E8728 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf14.hostedemail.com (Postfix) with ESMTP id A3E47100003 for ; Thu, 3 Nov 2022 04:09:54 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id q9so550684pfg.5 for ; Wed, 02 Nov 2022 21:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CjgiL2MLpB7k2dv0Fav14nQzud4nvz81K/5lxqZhfgU=; b=Ie7RO6PLa858Ia9kdyuyUiMlAvM8UZsnPeP1mn7nTLR9ZwGRt+Kf1PdHW6o9D6J93i iT0YgS4DJRhMaAXuP4oeyfXlk1/V48NlsRuAd56nHsHXGPJLz4XaBnYB/2O5sxCG0EX3 2L0kSSpJmwIsjmUndUp2oFhaYc2BJkJA4Gf08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CjgiL2MLpB7k2dv0Fav14nQzud4nvz81K/5lxqZhfgU=; b=zoC+vLiCt5v+dDNf0ldp+011RJCps5yCYgtIj8ly0gFWcAzTOsSfQj+tS+zWf8MQb7 5+g3XAJBX+9DiSlbRIu8nmj5jgz0IuutoO0j6GOu7GWYSsYZdzOABhyx2E0cViJWN6of ceDvH1I46qQ5/vGJY3L+BTjOhjIjTepQO5JyZ9y2AKDlQDpVK98k1Mp4ckJkK+hsESCu KgxBgXH0ZU0XrS4NUVRMlMN2PaQLYALKZeweV/syCjAFQFBF4P5/F1ZVlIrYhVjx/EBj 0BUZLeoVGB7STsaPXjrHpROrI7gXQaDZQ7UBsf2QiLWYdjLIebZW3UI7IhtY3+HP3Vpx qdGw== X-Gm-Message-State: ACrzQf2dWqnLtdxauIpybnTjrQ7esKW2+rbToq8qR0wtH9wgDnaxlz0t FWNTw0zXdu38mFMMWwHaSj3ghg== X-Google-Smtp-Source: AMsMyM5csRwutJPzmf7vWy9aYKQhU2w+QRsF3X/nPdTWHybfb4qKRtzaGxW3B8Dnnvp+dRF5jUvcUg== X-Received: by 2002:a05:6a00:2446:b0:528:5da9:cc7 with SMTP id d6-20020a056a00244600b005285da90cc7mr28855537pfj.51.1667448593611; Wed, 02 Nov 2022 21:09:53 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f22:e30:374d:5a2b]) by smtp.gmail.com with ESMTPSA id z5-20020a170903018500b00186ff402525sm3599016plg.213.2022.11.02.21.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 21:09:53 -0700 (PDT) Date: Thu, 3 Nov 2022 13:09:49 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667448594; a=rsa-sha256; cv=none; b=L1Fpv31ouFOBnwiVtPpG5YNUGY4x8gfHv5MQ74c4odtJku4F72lsexoApJJa5IZIt31QM+ muHlqNjc3LuUocmgLfBpq1MHFq8mDU3auEY5oDddyuUFH7wKsBh9Osmyu4/Ee6i3vdYeX2 euAn8vSpeHSoYTPSjiAnrcyu/Q1dTrE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ie7RO6PL; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667448594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjgiL2MLpB7k2dv0Fav14nQzud4nvz81K/5lxqZhfgU=; b=otahiNHICBecg0s5AIVA7Lox+/XOtGFBGwc35bBHxEvlwQl1DeLEfBM3zQU267r00Kk3Pi MZ+huFHvt0ca53vAyf0WFi2xCpkTVNlRqUbBFHwxaeMshH+mbfUXHt6Cc4OSgPIBC6oawk s4w65KUYzpexBULDzdHdIK7zmWxe+yY= X-Stat-Signature: 4mbm4a3mq34es3erdcqo7rrn33oop7qj X-Rspamd-Queue-Id: A3E47100003 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ie7RO6PL; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667448594-970717 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000543, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/03 12:05), Sergey Senozhatsky wrote: > What is the use case for removal of a secondary algorithm? > > > My point is that we don't need to implement it atm but makes the > > interface to open the possibility for future extension. > > > > What do you think? > > So, as far as I understand, we don't have reason to add remove_recomp_algo > right now. And existing recomp_algo does not enforce any particular format, > it can be extended. Right now we accept "$name" but can do something like > "$name:$priority". Or with keywords: name=STRING priority=INT and the only legal priority for now is 1.