From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09761C4332F for ; Wed, 2 Nov 2022 21:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89ED58E0002; Wed, 2 Nov 2022 17:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 827178E0001; Wed, 2 Nov 2022 17:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C8D68E0002; Wed, 2 Nov 2022 17:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5388F8E0001 for ; Wed, 2 Nov 2022 17:21:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2A3C31C6C87 for ; Wed, 2 Nov 2022 21:21:19 +0000 (UTC) X-FDA: 80089773078.23.937A372 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id CC45E80003 for ; Wed, 2 Nov 2022 21:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667424078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LwjUJXk275rFecz1ZN/R5h4zz71FMLP/gKQdOhmKyzk=; b=GHwEMl8CQr7Z4uBRlW2EIYP9IZgvvKDV10xaINqq2m05h9mMmc4gjkOQqZBxib4rLs2ILW 5a+ITA40VimbuNZopWfBXS02kBEM+kNtbupFF1GtAuoPxbMYunBJSLPHyqRLt4ztxisZJQ cl9u8B0bfDGGsZ96jhxAxddDjcaSey4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-4Fmn5EgrMJi6eQx4nFtoLw-1; Wed, 02 Nov 2022 17:21:17 -0400 X-MC-Unique: 4Fmn5EgrMJi6eQx4nFtoLw-1 Received: by mail-qv1-f70.google.com with SMTP id mo15-20020a056214330f00b004b96d712bccso10950212qvb.22 for ; Wed, 02 Nov 2022 14:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LwjUJXk275rFecz1ZN/R5h4zz71FMLP/gKQdOhmKyzk=; b=uO9q46ot+DcLqkSwZtioeBV+TdHkwrgbV81pxL1lqZfr1UJoOFeQ1vNrzpPrHIi/HL ATmg8YUdDZNQ/j/sVEkGKP+w6ZgavUs8KynMigWtJH5MHO/gtjLkRoOQjCX0nnc1++YX 78u4oByc0hglkkFh/xk5c8BvsxauSnfC7nbsBys7/LoM3FVBBYNFSYSo6mGAEihxr3pR lXAqSZU8ue8BlSSN7U5+GT5U/pqBFIY3GIud4wXQBcYGJoobJmDFwGMMGwCZB6jBXcf0 XOnWtunbSE1oh15tITmq5IxJjsJfvSFzwwMt1H0qFHaGAf3JZO9C6JCyiFc+5TYZTfH5 bjNA== X-Gm-Message-State: ACrzQf2kR1iNUmGh2dlqs+tX88T+AVcC61EC/yPst/sdXndwpPhCCHoK EqA0wciLGbFEASY4Cimx1tHjI2wqAa2v//IXAz+yBnSRPw/2WYuMPc2XepvCwS3kKjAOxZtA+Us TwjHcBF7BQtc= X-Received: by 2002:a05:622a:1196:b0:3a5:2fc4:5852 with SMTP id m22-20020a05622a119600b003a52fc45852mr11788056qtk.202.1667424076624; Wed, 02 Nov 2022 14:21:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44f3iMP6a6UsCDkjqdOvGbgMfFn28VOd/20STHVLbjpmYQEoDITy/sO8/YJ03SRJtRUbYRlw== X-Received: by 2002:a05:622a:1196:b0:3a5:2fc4:5852 with SMTP id m22-20020a05622a119600b003a52fc45852mr11788039qtk.202.1667424076409; Wed, 02 Nov 2022 14:21:16 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id 123-20020a370381000000b006e702033b15sm9250562qkd.66.2022.11.02.14.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 14:21:15 -0700 (PDT) Date: Wed, 2 Nov 2022 17:21:14 -0400 From: Peter Xu To: Nadav Amit Cc: Linux-MM , kernel list , James Houghton , Mike Kravetz , David Hildenbrand , Andrea Arcangeli , Rik van Riel , Andrew Morton , Muchun Song , Miaohe Lin Subject: Re: [PATCH RFC 10/10] mm/hugetlb: Comment at rest huge_pte_offset() places Message-ID: References: <20221030212929.335473-1-peterx@redhat.com> <20221030213045.335680-1-peterx@redhat.com> <3D896ED0-5600-4E55-8509-3F0E355FF692@gmail.com> MIME-Version: 1.0 In-Reply-To: <3D896ED0-5600-4E55-8509-3F0E355FF692@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667424078; a=rsa-sha256; cv=none; b=jhxuyN28+8h7CaCNBvKzYQulcHZUbaev8MJhmFKtlpYBPslMC61jccpDVFysqp0VLAiU+j helPbH4jDKrdDOUTOP9KiUS4YH1mQ710+O414dBUfCFaeev9rk6EX1bXN808iyzzAahTvy IFYIp4Y+ADDRYWuR2XUWJKxljHOhLB0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GHwEMl8C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667424078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LwjUJXk275rFecz1ZN/R5h4zz71FMLP/gKQdOhmKyzk=; b=A1WLvtxrcWpdYPpQLkADRkWMelwbUYJTnumuBu7QOE0G6adr1sRfb3rbljKcc1ebHlAJL1 Yf0G8Nt2ETqSIuDOkhlKwjyV8OnGcyoUS5vo9mwpzZRctXbE4kJrSOsGkISj1/vWEAmogB /ZAsFtv7x+PKqadlVgNUVyRNiIqDPGQ= X-Stat-Signature: thqukoit8pd1pim78cyh96c53u8ok3cb X-Rspamd-Queue-Id: CC45E80003 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GHwEMl8C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667424078-182157 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 10:39:33PM -0700, Nadav Amit wrote: > On Oct 30, 2022, at 2:30 PM, Peter Xu wrote: > > > + /* With vma lock held, safe without RCU */ > > src_pte = huge_pte_offset(src, addr, sz); > > Just another option to consider: you can create an inline function > huge_pte_offset_locked_mm(), which would do the lockdep_assert_held_*(). > > I personally would prefer it, since it would clarify exactly the lock you > care about and "make the code document itself”. That's a great suggestion, I'll give it a shot in the next version. Thanks! -- Peter Xu