From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66288C4332F for ; Wed, 2 Nov 2022 20:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD63D8E0005; Wed, 2 Nov 2022 16:20:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5F478E0001; Wed, 2 Nov 2022 16:20:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26A48E0005; Wed, 2 Nov 2022 16:20:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ACF228E0001 for ; Wed, 2 Nov 2022 16:20:12 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 81DDA14110E for ; Wed, 2 Nov 2022 20:20:12 +0000 (UTC) X-FDA: 80089619064.15.33D0CB3 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf07.hostedemail.com (Postfix) with ESMTP id 2DA0C40003 for ; Wed, 2 Nov 2022 20:20:11 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id e129so17195471pgc.9 for ; Wed, 02 Nov 2022 13:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=9DjpWuBA9exOzLUYvqxZg1Cix0esC/PPOjwfygnWeME=; b=LiDV59gEZWcERwqLtJpyFpunwq9VioEGhoQlabJ+/2PMgE8V2BXCgxJJ6uBk4XqOZP LtquxJ6s33xnCmo2YekpzjPq1CnFqGcpD7lgm/WjNMel8i7oMl67r3OPcyw2znULQimS KXQOqJsBOEUnGSmkIf1Di2D98TS2zraNPMdwpsjucWL11fZ14NTh/BE3HPitMuFBE6iC IqHQHJXmK/l2UwxWZR3hu5K1IIG1QW5cb8aS8F8F9HAgA90VtHwkNvTIsVVYkioBBAAn 6ARurfgrRPezG81fwKEizuk2facw9IBsvzcn7c0It8jy3yz1g8dIhf3gY2Ws0U7lcX7H 7fJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9DjpWuBA9exOzLUYvqxZg1Cix0esC/PPOjwfygnWeME=; b=G4C6o2D17rkgX20A6a0CD3xHC/xG28iEbhjBj79ugjHAbBoVHU8TociX104BzGZD9S buaVsgsoVBEN5hRWQxUUGyTTMv8nHR7Q6an5dAupIveIa5oXe9G/fOYEFFawe5kwqi3Q Dkb1DTjm8Z2iRxEzGhaSUk6uxaT55OBW7O1zHtAVRhpM2ggeKQ9HA4TRb6e6draP8VVw fcwgOy39mOk1kUjiP8ppLqdNGxtpORW6oRCMsu/0YW5/U7+WLdweaO+YKfD+9IiF2Gzc XvCAWpPlBZcpXRX4fycXttMslkf30m0rZ55aQhNLEBG31xCuoQc6dgXXViVQwYw8YPw7 qUjQ== X-Gm-Message-State: ACrzQf0CMzBUHMZ0nE5dZfKGbBTti5WsjlqG+WWsj6O4iqDFSjW69LQZ 4tWP6RB2O6+uYbWME+Mh/ak= X-Google-Smtp-Source: AMsMyM4Hvi439RG9EixT+nWpTjrrJxbl8sgAOJl1+3mSajMFITJwd6AL7yU/bh3NnD3bo9yU7OqYog== X-Received: by 2002:a05:6a00:1da6:b0:56c:318a:f8ab with SMTP id z38-20020a056a001da600b0056c318af8abmr26972646pfw.82.1667420411185; Wed, 02 Nov 2022 13:20:11 -0700 (PDT) Received: from google.com ([2620:15c:211:201:3fd5:8614:6eb0:846b]) by smtp.gmail.com with ESMTPSA id q5-20020a17090311c500b0017f49b41c12sm8782387plh.173.2022.11.02.13.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 13:20:10 -0700 (PDT) Date: Wed, 2 Nov 2022 13:20:09 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 3/9] zram: Factor out WB and non-WB zram read functions Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018045533.2396670-4-senozhatsky@chromium.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667420412; a=rsa-sha256; cv=none; b=O6kGQyAZJg6nA8nlAg5u7FCwLXknlZTFRPzhNV5a3q0Avb2u/3UpjLX5L/0RsJ7p/FpyVg HyclQJWr85k2ZPIxcQACsM/OqLdkdrmoTW+ZrcIFQ0rcB8WQ6XyVLmUTLWkNo9I4O/I4ZJ eLxW4mGlbNCcDQr/TXhS2oRISJracwk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LiDV59gE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667420412; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9DjpWuBA9exOzLUYvqxZg1Cix0esC/PPOjwfygnWeME=; b=PMQi+CMovcd9MxNGqJ1qzFC7ds5g/koKu3cMOdgcBwXnGGLCOh4Sbc0nTrv3KLTJcebUlL sqB887AptiPZlrfiCaxRVdfzaqLVrEI4qNMrhvOIZ5XTZQMwLDMc+M2t236Xmsym4mUlGH y3y7aiRTzpbZm2fo0taOPTz8C1JDLIA= X-Stat-Signature: 148tbwy9dnjigti71p8nrmfdefo14xym X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2DA0C40003 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LiDV59gE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-HE-Tag: 1667420411-39569 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 18, 2022 at 01:55:27PM +0900, Sergey Senozhatsky wrote: > We will use non-WB variant in ZRAM page recompression path. > > Signed-off-by: Sergey Senozhatsky > --- > drivers/block/zram/zram_drv.c | 73 ++++++++++++++++++++++++----------- > 1 file changed, 50 insertions(+), 23 deletions(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index a8ef3c0c3dae..94c62d7ea818 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1314,8 +1314,30 @@ static void zram_free_page(struct zram *zram, size_t index) > ~(1UL << ZRAM_LOCK | 1UL << ZRAM_UNDER_WB)); > } > > -static int __zram_bvec_read(struct zram *zram, struct page *page, u32 index, > - struct bio *bio, bool partial_io) > +/* > + * Reads a page from the writeback devices. Corresponding ZRAM slot > + * should be unlocked. > + */ > +static int zram_read_from_writeback(struct zram *zram, struct page *page, How about zram_read_from_bdev?