From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB68C43219 for ; Wed, 2 Nov 2022 11:29:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D3838E0002; Wed, 2 Nov 2022 07:29:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 883AC8E0001; Wed, 2 Nov 2022 07:29:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7240F8E0002; Wed, 2 Nov 2022 07:29:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C65F8E0001 for ; Wed, 2 Nov 2022 07:29:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28AA71611F0 for ; Wed, 2 Nov 2022 11:29:33 +0000 (UTC) X-FDA: 80088281826.26.B1A8CBE Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf23.hostedemail.com (Postfix) with ESMTP id A5EA3140005 for ; Wed, 2 Nov 2022 11:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667388571; x=1698924571; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xHltA9cDNqr066zntg/UF56nyb2JOcr0In8V89pVlbU=; b=SHgwqQGaf/i9dNitegMGPO2+ugXgQ4AjMYmga4TwulVuT5G7aOUbxvRd lFpgClddNvTBrhdt3YuC6M6N/kh2oo035VmXKoWHDEWnOlZDjwGuBCtc/ xT88rNmRExAuV/roELg6pcFAkXpnlK+57i2EosVoyNz46tjZB1ZIniqxS GCzrjBtGnbRM87VkJVw7enJJT3CKv9GPMxSuhZzfLdHDNAXTfW4r4t7nQ 3CsehCjOv378Ec8lnPm0+ixWVmXX20L7/TAX1SJ+NVz4IKsWm96dxfw88 iIT+7vOq+4U5MyaKAc8dzS37ovG7qjvAj1xvRyz3RjppcSPsSbyxw4mPq Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="336059951" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="336059951" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 04:29:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="703235434" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="703235434" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2022 04:29:27 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oqBvx-0069TA-1p; Wed, 02 Nov 2022 13:29:25 +0200 Date: Wed, 2 Nov 2022 13:29:25 +0200 From: Andy Shevchenko To: Kees Cook Cc: Christophe JAILLET , Pasha Tatashin , Andrew Morton , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 21/30] mm: Use kstrtobool() instead of strtobool() Message-ID: References: <03f9401a6c8b87a1c786a2138d16b048f8d0eb53.1667336095.git.christophe.jaillet@wanadoo.fr> <202211011543.20ACBF9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202211011543.20ACBF9@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667388572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VNZDJq40s2ej7QKvcs2WoH/TDPV39RHdhGFjL6btYH0=; b=LEw4hvWBio32V6oGrGdmImVNTlF00cKofq4WcqIP4JgYnJtlZ9YqYYActqBd0ViNouFwJP JCIBW/JMZ+PPFUOLXz4TMqUM2SJ1rkRWXHh9LMuaM6bd+drMEM/Wh5W34agmkbNgZhmYP1 XYM1Z8vyryuOZVUb8fIErQ6AdD3nyTU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=SHgwqQGa; spf=pass (imf23.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667388572; a=rsa-sha256; cv=none; b=KTF8XgJm5Dybpgl7vyDR4rk51fsNd8HatUi9B9yp/UYaRuuWKb/h36EkRo9XvWyBHhM3i8 7gVaf6wWHyH88O4Zgqc4GOwKoC1mSYvmoaVCm7zPzEcTAJMcoHh7PjWpX+TcSmipD2qnQM ZvtMRXwY4RP5dvHUsTux0XVbuQcEbew= X-Stat-Signature: f67s5aedk5jgrwkbenyxwz6wbohc7y9p X-Rspamd-Queue-Id: A5EA3140005 X-Rspamd-Server: rspam06 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=SHgwqQGa; spf=pass (imf23.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1667388571-52988 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 03:47:20PM -0700, Kees Cook wrote: > On Tue, Nov 01, 2022 at 10:14:09PM +0100, Christophe JAILLET wrote: ... > This seems in keeping with the removal of the simple_*str*() helpers: > https://docs.kernel.org/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull That piece of the documentation is partially wrong. Nobody will going to remove simple_strtox() due to their convenience when it's related to parse something from the stream. Yes, overflow is possible, but here is a trade-off. Note, kstrtox() may not work at early boot stages when we need to parse stream (with mixed digits and text and symbols) without acquiring space from the heap, i.o.w. RO strings. -- With Best Regards, Andy Shevchenko