From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE594C4332F for ; Wed, 2 Nov 2022 11:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D0058E0002; Wed, 2 Nov 2022 07:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1597A8E0001; Wed, 2 Nov 2022 07:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15218E0002; Wed, 2 Nov 2022 07:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DA39D8E0001 for ; Wed, 2 Nov 2022 07:27:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 918A71611E1 for ; Wed, 2 Nov 2022 11:27:41 +0000 (UTC) X-FDA: 80088277122.17.8AD60DD Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf01.hostedemail.com (Postfix) with ESMTP id 53DFB4000F for ; Wed, 2 Nov 2022 11:27:36 +0000 (UTC) Received: from zn.tnic (p200300ea9733e741329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e741:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3F6BC1EC059D; Wed, 2 Nov 2022 12:27:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667388454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=yICoADaQMVMzDnnLd9qSZOhWGA6H9/WvnEz/OK5eX7Q=; b=S1atLxaEuLaJ/+CK/dqlknDpST2LhW/3u+eYKdl6ClrAKnMqw61jNH8w4PO0e02jNHS0kC shBVTW4qpXJJb1k4DRNQ3FgDYM6DOQm9H+b1PuFSSlhAjdFm16bl5Ochou662KZCkO3wp4 04JhwBQACZ1QdCH14YrOC+MY7cKm4Hg= Date: Wed, 2 Nov 2022 12:27:33 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Subject: Re: [PATCH Part2 v6 07/49] x86/sev: Invalid pages from direct map when adding it to RMP table Message-ID: References: <243778c282cd55a554af9c11d2ecd3ff9ea6820f.1655761627.git.ashish.kalra@amd.com> <6e9f3d48-1777-6710-cb1d-3f2f38c0328e@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6e9f3d48-1777-6710-cb1d-3f2f38c0328e@amd.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667388459; a=rsa-sha256; cv=none; b=inFxsbfo3SdXIGSgMuAgGWCpN4W7j1k6nl7E66gnIuM/46BVG0ICUxwaZ81SGhGePxPPOt YzuQdFvI3gKH7KKDg9Yp7P0C4IzE6gs95uvRpwGS9ibrKe+0J8zyHyeGogz9j7t0GQckOR 2yjS6kkt7MEhGrB7pCnHEddD5OwSqpo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=S1atLxaE; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667388459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yICoADaQMVMzDnnLd9qSZOhWGA6H9/WvnEz/OK5eX7Q=; b=2L2NcoCtneuc6D2/STnlbmc3JzvhA9chhHBoK4tjurz81TYNPUfg2xWbfWrFoCSc/TY/OF v+e1RMZaGZDxayKtqbsyP+nybre5mH4Qr5//kZWSeyXIOog3qwjGl3nKfp4JGpa+7il+3I 3N4D9bYzHfUXDrHGF4lF6kuuw0GGXNI= X-Stat-Signature: ocq86srrki48iawk44m13cro88tpmgrk X-Rspamd-Queue-Id: 53DFB4000F Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=S1atLxaE; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667388456-305668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 10:12:35PM -0500, Kalra, Ashish wrote: > Following up on this, now, set_memory_present() is a static interface, > so will need do add a new external API like set_memory_p() similar > to set_memory_np(). It is called set_memory_p() now and you can "un-static" it. :) > So currently there is no interface defined for changing the attribute of a > range to present or restoring the range in the direct map. No? static int set_memory_p(unsigned long *addr, int numpages) { return change_page_attr_set(addr, numpages, __pgprot(_PAGE_PRESENT), 0); } :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette