From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09054C4332F for ; Wed, 2 Nov 2022 09:13:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C8958E0002; Wed, 2 Nov 2022 05:13:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 678A18E0001; Wed, 2 Nov 2022 05:13:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568038E0002; Wed, 2 Nov 2022 05:13:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 47E388E0001 for ; Wed, 2 Nov 2022 05:13:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AEAF1C0467 for ; Wed, 2 Nov 2022 09:13:15 +0000 (UTC) X-FDA: 80087938350.14.AFB4DA8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 37E93A0005 for ; Wed, 2 Nov 2022 09:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N5xkihfiIAm5OQbHmLx0EWGK5BIbM+DxZNz/QBUlxYg=; b=RtVNh1IE7sd1+/zLX57ev7rqZQ gVZ5mlxmRsrC7toNkpdi+jHHFmoWz5vyLbS5hXLhndtcdZqC66ilROfwmJrueCBTFho4FJQM1Pxxp OtlnmSC3Gla2lOz4F0WkxwwUSYae0RyisqXje7O5IXJAHn/YM3hdYuBPAK+DK5tZIM9SLop6GfjzT V3JxCqkp1qdWBuYNwR0WDkV4sSXPwXK9zhmrZp2iGbPo3Yesop8LDpIZ7A5U3D8Law2NqZ6klulCe qjeIAmssBKxK/FC8ydKQP8o9QK4D+Y7OCyF4Aq+udQaV5EuEEgRU/Wdvj7ocZsZcn2T0kxzm7o/e3 Fxuyi3sA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oq9oA-00A4D2-6z; Wed, 02 Nov 2022 09:13:14 +0000 Date: Wed, 2 Nov 2022 02:13:14 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Uladzislau Rezki , David Howells , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: Re: [PATCH v2 2/2] mm: Add folio_map_local() Message-ID: References: <20221101201828.1170455-1-willy@infradead.org> <20221101201828.1170455-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101201828.1170455-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RtVNh1IE; spf=none (imf15.hostedemail.com: domain of BATV+27d44d0ccf0240a6b878+7010+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+27d44d0ccf0240a6b878+7010+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667380395; a=rsa-sha256; cv=none; b=jrDFWB3uPSNkwnJBVppYpdKEQ3pHt3HsOJbUV9lEywY/OTWM4fZ87uo/bACROH1C7BSV1l V6I80+qR+OgwXL13HufKku3jyjO7ZsSJaWZK3q0CoSLuG5xR5isNilbb5SIgId7AeDjtfm Z26iZzu0BTYn8527seBRIgAQJmSE/0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667380395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N5xkihfiIAm5OQbHmLx0EWGK5BIbM+DxZNz/QBUlxYg=; b=Z+2dw293DaPNPop8WV7yqPdOv+2TG8rT/OM8gyhgXD/OyHECWfD/MJdPCWoDoaN3NqkICm tec2eWwylvHTTPKI6FhUzG4zvsjA1Eu+eJw8W8HjJQibAQrmYqXgLTbMYC3QJhtnOJxpdV ChOr3zaV9mh076IZFF3QpV34+XP6DXA= X-Stat-Signature: xbjqqnqqj3fmqhwxet83jy9pr44z7hze X-Rspamd-Queue-Id: 37E93A0005 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RtVNh1IE; spf=none (imf15.hostedemail.com: domain of BATV+27d44d0ccf0240a6b878+7010+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+27d44d0ccf0240a6b878+7010+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667380394-612938 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +void *vm_map_folio(struct folio *folio) > +{ > + size_t size = folio_size(folio); > + void *mem = vmap_alloc(size, NUMA_NO_NODE); Needs an error check here. > + mem = kasan_unpoison_vmalloc(mem, size, KASAN_VMALLOC_PROT_NORMAL); > + > + return mem; Why not: return kasan_unpoison_vmalloc(mem, size, KASAN_VMALLOC_PROT_NORMAL); > +EXPORT_SYMBOL(vm_map_folio); All new vmalloc/vmap functionality should be EXPORT_SYMBOL_GPL.