From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F22C433FE for ; Wed, 2 Nov 2022 04:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A72C6B0071; Wed, 2 Nov 2022 00:10:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 057296B0072; Wed, 2 Nov 2022 00:10:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E88146B0073; Wed, 2 Nov 2022 00:10:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D9D136B0071 for ; Wed, 2 Nov 2022 00:10:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A7A25C0F65 for ; Wed, 2 Nov 2022 04:10:07 +0000 (UTC) X-FDA: 80087174454.13.D6AC837 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf22.hostedemail.com (Postfix) with ESMTP id 3C8D8C0003 for ; Wed, 2 Nov 2022 04:10:07 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id io19so15425176plb.8 for ; Tue, 01 Nov 2022 21:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yMJn7jimJNcA0G1Sq5Hqirc0aLfOad24t/l8klU9DOY=; b=TvlCXQ8NjdJp1yLfUtUk2P/Qs8V2AtrOrI2xgiu3Ccl70bvVqtB1OiixpaYrdGLg0b F1CM+HwzOpl4kdctIFecwM/pulSZLLzbns9c9n53I4HtSSSASGT5k3r8MResxKdwvEth RN1WckQyiTKybASLNAzoTuNYjiaXkY6lw8UB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yMJn7jimJNcA0G1Sq5Hqirc0aLfOad24t/l8klU9DOY=; b=e61HdpXHjSNVwJZJ6/T1aUjR36e0hBnk8ODPEwOIB7wruVd6nFYQti2zVQBK8JC0L5 WtP28ngex01TAH5sueV67o+/n/XzzzWURjIsLe8gDQw+UJ5OBq6NmYeIzypeWV1eGidZ 1eCQSFiAtlC0v3RcFA/I3ChT5P/8YjsZ7GZgzrFEveKHvbo+k+EjILCzD53MvIaMNMUH SGdThrW97jUxCZrsW/M75GVPOBImpGa17T0l9ijKUbSg9b06XPHtyriVV3CSbJcrpW2/ ip4cNNaQGFNpV9CqTKRqKSHdStbqVlQa7e9coGfUvxg/zCzHPP8pIl8jLnBABNnvUFgS jILQ== X-Gm-Message-State: ACrzQf2K/D8EW7hdLm7Yhh2C+JQ7WApKQV9iHTsTjb9zcGaKj027W2Iq WDlXhyAvpTRGEnixll9bqbsfvQ== X-Google-Smtp-Source: AMsMyM5wKzcOggf4qugrRG89F4qvas5Pi2MV67GcuUOuz1fGu56ehuRTQ6Ld+rIcRABfBKeuftEePg== X-Received: by 2002:a17:902:d4ce:b0:187:17bd:44d7 with SMTP id o14-20020a170902d4ce00b0018717bd44d7mr16559179plg.84.1667362206240; Tue, 01 Nov 2022 21:10:06 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f558:dfb0:7cb7:44d9]) by smtp.gmail.com with ESMTPSA id q14-20020a170902a3ce00b00186c6d2e7e3sm7119248plb.26.2022.11.01.21.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 21:10:05 -0700 (PDT) Date: Wed, 2 Nov 2022 13:10:01 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Message-ID: References: <20221026200613.1031261-1-nphamcs@gmail.com> <20221026200613.1031261-5-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026200613.1031261-5-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TvlCXQ8N; spf=pass (imf22.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667362207; a=rsa-sha256; cv=none; b=t7F6OteJATRkX5MIv3WgfwR2K5i5CTZr4ZjRd+fFzDcGtO4f5R37RSCEldjfFCq3r+vu5N v1dFa1tbeycUuwTry3ECzPoi03nokwsfdVORmFmXaRRcpC0Mgt59k2pXs+zV7axvLTYlHw EgJkn1lzOsiNPLJ1xHIdp7oIbcObMDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667362207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMJn7jimJNcA0G1Sq5Hqirc0aLfOad24t/l8klU9DOY=; b=cSDKiKdWRKi4t2yziWRoTenOqbTT0ndB2NkVxm7ro9r173Kxm8tChIlWjEgXFTD7rXPqmi XtvNt2oLjGByjMUgpY9BZiUziKFrgysb9sPaBphQWJFbHkKwutm3Fz+EywSsNKbh2gqjn0 4+O5/0MHcrZbun5dYHKcHXmDvks2qjY= X-Stat-Signature: xa4z99yh3a8fiet19r9ceecoq4mga6df X-Rspamd-Queue-Id: 3C8D8C0003 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TvlCXQ8N; spf=pass (imf22.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667362207-841189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/26 13:06), Nhat Pham wrote: > +struct zs_pool; > + > +struct zs_ops { > + int (*evict)(struct zs_pool *pool, unsigned long handle); > +}; > + > struct zs_pool { > const char *name; > > @@ -242,6 +248,12 @@ struct zs_pool { > /* List tracking the zspages in LRU order by most recently added object */ > struct list_head lru; > > +#ifdef CONFIG_ZPOOL > + const struct zs_ops *ops; > + struct zpool *zpool; > + const struct zpool_ops *zpool_ops; > +#endif I really don't think I follow this zpoll_ops and zs_ops things. Why do we have zs_ops?