From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8157EC4332F for ; Wed, 2 Nov 2022 03:59:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D81086B0071; Tue, 1 Nov 2022 23:59:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D32938E0001; Tue, 1 Nov 2022 23:59:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF85B6B0073; Tue, 1 Nov 2022 23:59:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B11D16B0071 for ; Tue, 1 Nov 2022 23:59:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7F3F112019B for ; Wed, 2 Nov 2022 03:59:10 +0000 (UTC) X-FDA: 80087146860.04.D6A767F Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf02.hostedemail.com (Postfix) with ESMTP id 1F49680003 for ; Wed, 2 Nov 2022 03:59:09 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id o7so11875379pjj.1 for ; Tue, 01 Nov 2022 20:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2yPoIWDDzc9PYn0w5vORaR9t4xV3ZtjfUPEHOHIEZUg=; b=j43kkGZTfcJiRjGWFJ97v2juhgj1kXKveCEGwbeMMGULnUeQQats118Gz3DtrCLIxh Qou8ggREsz/Psa56ARTVxnX5U3KuNVryBxziz0JOPWHU9gaBCIz3HInv6CRLaOqCXqhw v/liuqUT+UMmOZBgzhjGWcRjpkesk02+C+/pHo0N8lbZzZzTod0EanqqcdfHaaLnngHe V6S/iDXCBTACCbw/RiQQQNmD+oiYshKLieRmd1rKPiLggFd0iVj+Uia0c+QnfOeg3KY/ Ryrx3H2Tx5iBOaY11/gLWll5jkO6kozs/Ps75cKqY0ggDeMcCFsOf24NrAiW+9dy9hWU N5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2yPoIWDDzc9PYn0w5vORaR9t4xV3ZtjfUPEHOHIEZUg=; b=ZHVtToo3Qr4wPoq5swPGSmXMzGP7NVfoPud/tNgfDyJMuspJSzzWuPUmsga74N5/ui H9F4oE1l6EGftALohJQYMVNb7RCKF4iBUBkm6Y+FqMMIDgTt1Gi5ZAehHaeanHk40hwi IGk1bqEG1kE9M0yhs6KS7sV3yomllLRHpuest78iDAeyZPLlGvek0f4rew79UDiHto1F kEjR8uRGIo/ZanvxStjC7O7O9nZouUgdAcFmf/2VJErlq84AR7FwIu+jl/7ive3URdM1 tgpBaz6FCYJPN9ZbD+qQuPXjnwLjrIZeWIg5HYjWweK+TmFzKzbNxbEJuLHLStmVFJ1f 6wMg== X-Gm-Message-State: ACrzQf32om7e1xdR7Zoe8/JJLVUSoMBHKrdocPF8zloDChy9tj/1eMgr yXg27txQJ0Ztfin0/tHdGFYzCvb8ei8= X-Google-Smtp-Source: AMsMyM6CiqkzyAVi7+b15AEvkHHkYI3AA8d7qFg3UH4G0RbPa644410riYl1ogPjxely26I5oeDQzA== X-Received: by 2002:a17:902:ea09:b0:186:a604:d7e4 with SMTP id s9-20020a170902ea0900b00186a604d7e4mr22801093plg.120.1667361548975; Tue, 01 Nov 2022 20:59:08 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id q16-20020a17090311d000b001745662d568sm7080577plh.278.2022.11.01.20.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 20:59:07 -0700 (PDT) Date: Wed, 2 Nov 2022 12:59:02 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Uladzislau Rezki , David Howells , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: Re: [PATCH v2 1/2] vmalloc: Factor vmap_alloc() out of vm_map_ram() Message-ID: References: <20221101201828.1170455-1-willy@infradead.org> <20221101201828.1170455-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101201828.1170455-2-willy@infradead.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667361550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2yPoIWDDzc9PYn0w5vORaR9t4xV3ZtjfUPEHOHIEZUg=; b=gscenfxvGiLFfXOUgmQwLmCaczy8R8IK6DvZpODaGmO3qOSyTxjIXNqc6dIwZM2ANaV2Ap XcNXP6osWCnzgmF9owhN43/smr/pVKiGvUQx+5BxdBBynfm4J1WFHYWgik+tLh/5JdwOt8 P6qGccmPaJdzj5B3IXze/yW1cQF3zUw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j43kkGZT; spf=pass (imf02.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667361550; a=rsa-sha256; cv=none; b=EyQ14FfykXeQoS3y8YC1ghN/EhFYAagL087Rqur+tW+am46IrzXJ9h/zGV5obSnoS99Heq Em3JhBbxzKZwIkLftRnNWlHnutK45u0DOTyCYQ//IxVAD6OYIwsfIefMuy5KbMhNRq99kw UtS12LkKJY0W/Hf7T15Ilohqd/C8ezo= X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1F49680003 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j43kkGZT; spf=pass (imf02.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: tqk4kugs1d1r66js19zpekjg3gptfk8t X-HE-Tag: 1667361549-11296 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 08:18:27PM +0000, Matthew Wilcox (Oracle) wrote: > Introduce vmap_alloc() to simply get the address space. This allows > for code sharing in the next patch. > > Suggested-by: Uladzislau Rezki > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/vmalloc.c | 41 +++++++++++++++++++++++------------------ > 1 file changed, 23 insertions(+), 18 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ccaa461998f3..dcab1d3cf185 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2230,6 +2230,27 @@ void vm_unmap_ram(const void *mem, unsigned int count) > } > EXPORT_SYMBOL(vm_unmap_ram); > > +static void *vmap_alloc(size_t size, int node) > +{ > + void *mem; > + > + if (likely(size <= (VMAP_MAX_ALLOC * PAGE_SIZE))) { > + mem = vb_alloc(size, GFP_KERNEL); > + if (IS_ERR(mem)) > + mem = NULL; > + } else { > + struct vmap_area *va; > + va = alloc_vmap_area(size, PAGE_SIZE, > + VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); > + if (IS_ERR(va)) > + mem = NULL; > + else > + mem = (void *)va->va_start; > + } > + > + return mem; > +} > + > /** > * vm_map_ram - map pages linearly into kernel virtual address (vmalloc space) > * @pages: an array of pointers to the pages to be mapped > @@ -2247,24 +2268,8 @@ EXPORT_SYMBOL(vm_unmap_ram); > void *vm_map_ram(struct page **pages, unsigned int count, int node) > { > unsigned long size = (unsigned long)count << PAGE_SHIFT; > - unsigned long addr; > - void *mem; > - > - if (likely(count <= VMAP_MAX_ALLOC)) { > - mem = vb_alloc(size, GFP_KERNEL); > - if (IS_ERR(mem)) > - return NULL; > - addr = (unsigned long)mem; > - } else { > - struct vmap_area *va; > - va = alloc_vmap_area(size, PAGE_SIZE, > - VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); > - if (IS_ERR(va)) > - return NULL; > - > - addr = va->va_start; > - mem = (void *)addr; > - } > + void *mem = vmap_alloc(size, node); > + unsigned long addr = (unsigned long)mem; I think we need to check mem != NULL. > > if (vmap_pages_range(addr, addr + size, PAGE_KERNEL, > pages, PAGE_SHIFT) < 0) { > -- > 2.35.1 > > -- Thanks, Hyeonggon