From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6174FC433FE for ; Wed, 2 Nov 2022 03:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE9FC6B0071; Tue, 1 Nov 2022 23:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A5B6B0072; Tue, 1 Nov 2022 23:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13F86B0073; Tue, 1 Nov 2022 23:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC8126B0071 for ; Tue, 1 Nov 2022 23:46:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 87A4AA6572 for ; Wed, 2 Nov 2022 03:46:34 +0000 (UTC) X-FDA: 80087115108.15.85C5756 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 428C180002 for ; Wed, 2 Nov 2022 03:46:32 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id y203so1154284pfb.4 for ; Tue, 01 Nov 2022 20:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ngjCxwI50NV8NPGOK2d44HJXxJVX9v33B3O6zMRn5JA=; b=eJpD3knnuoN1RI+mnk0L+km945S6U+NZFy70tUArlIlIdazFCgBA8pH98AF4gmcwIB UGAS5hmpofQoKmX/0hwDgqTq+Ph6E2T3QU029p4SDYJd1D4RM8jmG10cUHzS3MZSe2t1 QKtw3odcKYB2K9kqLN9x/IUnRKv1SqoK6wCzZFMgHa5Gm5ySrJPKvxgoBBphGmZV1jnE 5xZHD3eQrG6gFwbFrHrTM18pBkoq03heJZ+RZ+3gcQ4cNrzWj1/wLF2IM/dTescBzE5Y bG2NHWVQcV3HBrEbSrIJGGRLQdEQxd7nCIP9kJlMrFu5N7HivEwpCBNKCHCAexxS2g8C e3gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ngjCxwI50NV8NPGOK2d44HJXxJVX9v33B3O6zMRn5JA=; b=dgpMrOW5UOZLKi9Nd7eWDs/nbEQ4arzKOsyIq9jjTNaS5SIo3Qp+VuuBF8hp3kdSBH b+fHTRHWuJt8ZLImjORN5JZznx63Fk3jji+O60T8WHhXxIonPF/GHguQDoiUljGrNDEO rAaMt19Ch0PM5cHEEFgPy8N7XBYZiJcG4A17FQ3NA9nV9QDEJ9/SGtIiF+Lkkc8hJCSA D9MfVwVS/y35Miiqc4BLZUTqJadkJg+s7qsrp/j2Fk2lxGmczr2WVGXMCSl3R7sdRUtN fxbkr8maVpDVzU8yNmqxHn0pFOdNKIvOrdxtxM4Dk9mQQ3NES5Q7laeyGkoM2IGx9WpC XbfQ== X-Gm-Message-State: ACrzQf2HMYLP9NfnlThB0il9GA9+rrUreLxuGlKzGjN5yBlWIcDunQTN 3G2AfGX/9UXGE1ckc1WQ19Y= X-Google-Smtp-Source: AMsMyM5WcVcn16x9J77fNGo+ZGYfs8AlMI1FYySaXqBVGyy3gqsYd1vg6hBASyFMPbxpL+Pzg7buSg== X-Received: by 2002:a63:8942:0:b0:46e:c02e:2eb5 with SMTP id v63-20020a638942000000b0046ec02e2eb5mr19955416pgd.141.1667360791412; Tue, 01 Nov 2022 20:46:31 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id f27-20020aa7969b000000b0056cea9530b6sm7221952pfk.202.2022.11.01.20.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 20:46:30 -0700 (PDT) Date: Wed, 2 Nov 2022 12:46:25 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Uladzislau Rezki , David Howells , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: Re: [PATCH v2 1/2] vmalloc: Factor vmap_alloc() out of vm_map_ram() Message-ID: References: <20221101201828.1170455-1-willy@infradead.org> <20221101201828.1170455-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101201828.1170455-2-willy@infradead.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667360793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ngjCxwI50NV8NPGOK2d44HJXxJVX9v33B3O6zMRn5JA=; b=Z9tsKgMr6dBVguRQjqgpGUbHxKObXCE/vGCJn9XvRt3IftOYlpa4m3aAtB1BY9QamWsIaW smL2HArIvn0azIVmYJbI0L3es57iUDOAheXEoJEjwf+9zDktx8mgDFJ784MEaM5s3JCw6t zMa/fXd+wZOH2XlE+I0zLmAt3bAERn0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eJpD3knn; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667360793; a=rsa-sha256; cv=none; b=YMiRQPK/MAmNBYN/LIPOOYZefepfFithwPMh+jD7iDOo2OpIQmEengxt33sLrl2uUrn8bB ToX3/anW14LnQMYXJ4uxwMDD+NQVeEOMb87bmNgEX9Z6Lv7vrgYX7wrV8VD36SV0/0sIN7 WHg54flhQqenXhO2sZZMQwfiCa98MiI= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eJpD3knn; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: wwcgte4snnwqafhw7bg7tb5w8dusgqe6 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 428C180002 X-HE-Tag: 1667360792-919759 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 08:18:27PM +0000, Matthew Wilcox (Oracle) wrote: > Introduce vmap_alloc() to simply get the address space. This allows > for code sharing in the next patch. > > Suggested-by: Uladzislau Rezki > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/vmalloc.c | 41 +++++++++++++++++++++++------------------ > 1 file changed, 23 insertions(+), 18 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ccaa461998f3..dcab1d3cf185 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2230,6 +2230,27 @@ void vm_unmap_ram(const void *mem, unsigned int count) > } > EXPORT_SYMBOL(vm_unmap_ram); > > +static void *vmap_alloc(size_t size, int node) > +{ > + void *mem; > + > + if (likely(size <= (VMAP_MAX_ALLOC * PAGE_SIZE))) { > + mem = vb_alloc(size, GFP_KERNEL); > + if (IS_ERR(mem)) > + mem = NULL; > + } else { > + struct vmap_area *va; > + va = alloc_vmap_area(size, PAGE_SIZE, > + VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); > + if (IS_ERR(va)) > + mem = NULL; > + else > + mem = (void *)va->va_start; > + } > + > + return mem; > +} > + > /** > * vm_map_ram - map pages linearly into kernel virtual address (vmalloc space) > * @pages: an array of pointers to the pages to be mapped > @@ -2247,24 +2268,8 @@ EXPORT_SYMBOL(vm_unmap_ram); > void *vm_map_ram(struct page **pages, unsigned int count, int node) > { > unsigned long size = (unsigned long)count << PAGE_SHIFT; > - unsigned long addr; > - void *mem; > - > - if (likely(count <= VMAP_MAX_ALLOC)) { > - mem = vb_alloc(size, GFP_KERNEL); > - if (IS_ERR(mem)) > - return NULL; > - addr = (unsigned long)mem; > - } else { > - struct vmap_area *va; > - va = alloc_vmap_area(size, PAGE_SIZE, > - VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); > - if (IS_ERR(va)) > - return NULL; > - > - addr = va->va_start; > - mem = (void *)addr; > - } > + void *mem = vmap_alloc(size, node); > + unsigned long addr = (unsigned long)mem; > > if (vmap_pages_range(addr, addr + size, PAGE_KERNEL, > pages, PAGE_SHIFT) < 0) { > -- > 2.35.1 Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon