From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8FEC4332F for ; Wed, 2 Nov 2022 03:44:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59D4F6B0071; Tue, 1 Nov 2022 23:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54D176B0072; Tue, 1 Nov 2022 23:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463196B0073; Tue, 1 Nov 2022 23:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3781E6B0071 for ; Tue, 1 Nov 2022 23:44:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 08D56A02EC for ; Wed, 2 Nov 2022 03:44:16 +0000 (UTC) X-FDA: 80087109312.23.BD31A17 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf19.hostedemail.com (Postfix) with ESMTP id ADE9C1A0004 for ; Wed, 2 Nov 2022 03:44:15 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id l2so15373690pld.13 for ; Tue, 01 Nov 2022 20:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZuDhCs/uN/Jh8YtacbftAAQuLE1EzgHWJYodom4FpBg=; b=L832lV6gy8GwQ7EizdFm30fABkOF6M7+bcGz9Dtad7YavJluIno2A1T1cUcQh1Lv43 r3VTQaXWTxQ9CY9Md+pBFUy1QuewIbwW7BsdsCauHwOkp1SfNA6hGvFnjMCuzseIlaF6 HAdo1IPrYARu4v7Vn/8IPlP6aNX8uhMPuWqQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZuDhCs/uN/Jh8YtacbftAAQuLE1EzgHWJYodom4FpBg=; b=Rl0dovAQDqLDiruVQVVKbnoUis/aG4GGSLpQlKNReCBHcHyEPtbVDUIfr+P4PiF2EU Gzw/BS18ibvkceVTE3XpFtUEffbQzm2SKvgZbg/OScRxr4PvdC/Xxd4REc4iAcyqhmVN DFir/ocMQ3NSim7n+8oE2NXwhq1j4DNcuB61JDIacAiOrYURVyZmL3K4MOlEiQn01c3V Ka4uPodAI0DFCkqOHJoMr6JA/V4R6MJe9EmspyzmRrYw+6D4Kny9xq0nTHTtRUgOhcCD i5rOXI/pMV6KETgRwC9gcNGbAfEsJIVop5oSwF5sAGW0/ujaoUiBOwdO/6lDweK32gpW ciCw== X-Gm-Message-State: ACrzQf3RsQ8XGhgIMFiGWQYfFS1zGnNXKke4WIE/JfSbn8OWGrwFGfYM NUND2nfNkOnJSW3aOo7Uq5Md+w== X-Google-Smtp-Source: AMsMyM6P0xtQ3chlVxS/o5oJDRkd2Vw7NeSDqVzZj/NsDFNGuR8Ipp3Q5hJSGUIQkbeEejPA4OO6Wg== X-Received: by 2002:a17:90b:2248:b0:210:10dc:a314 with SMTP id hk8-20020a17090b224800b0021010dca314mr39574351pjb.15.1667360654765; Tue, 01 Nov 2022 20:44:14 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f558:dfb0:7cb7:44d9]) by smtp.gmail.com with ESMTPSA id d81-20020a621d54000000b0056bc5ad4862sm7239890pfd.28.2022.11.01.20.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 20:44:14 -0700 (PDT) Date: Wed, 2 Nov 2022 12:44:09 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v2 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <202210272158.7swYwd23-lkp@intel.com> <20221027182736.513530-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027182736.513530-1-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=L832lV6g; spf=pass (imf19.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667360655; a=rsa-sha256; cv=none; b=MHfDjwsAxMtXE4QduFpp5Tocqp/5/V+fFt+Dia5JPoeLY9rsntwcLyoPNJPLE67rfWmMjH 3gPDlwJW9lKJyKsPwqo2bksvR9rVVmT0M7QrDC9BC3vHEP5f9sktkJzWZerogdjPbh7ktV hYo0+nsrsDZgoWcmQp3kMPlb92damS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667360655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZuDhCs/uN/Jh8YtacbftAAQuLE1EzgHWJYodom4FpBg=; b=GTLXepvQiI9Z+0hs0JuheeFtLYNSZhVymjqvGhowt4hJpF0oyxwAAHSSH8drTE+hU1KWRL Nt8qzqlnt3/qw0GgMnhmx73Cxvq/MAjGUP74JJ0lb4Q1lG0Ibjirdz1+vB17pa7GdJTkg5 LSk7jw3nSgda4pJ2AQse8HzgwUylF1M= X-Stat-Signature: gthdzjfddg4he5tirikt1bxgmz35e59h X-Rspamd-Queue-Id: ADE9C1A0004 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=L832lV6g; spf=pass (imf19.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667360655-321074 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/27 11:27), Nhat Pham wrote: [..] > @@ -482,6 +504,7 @@ static struct zpool_driver zs_zpool_driver = { > .malloc_support_movable = true, > .malloc = zs_zpool_malloc, > .free = zs_zpool_free, > + .shrink = zs_zpool_shrink, This should use tabs, just like the rest of fields. > .map = zs_zpool_map, > .unmap = zs_zpool_unmap, > .total_size = zs_zpool_total_size, > @@ -955,6 +978,21 @@ static int trylock_zspage(struct zspage *zspage) > return 0; > } > > +/* > + * Free all the deferred handles whose objects are freed in zs_free. > + */ > +static void free_handles(struct zs_pool *pool, struct zspage *zspage) > +{ > + unsigned long handle = (unsigned long) zspage->deferred_handles; A nit: we don't put a white space in cases like this. IOW (unsigned long)zspage->.... here in everywhere else in this series.