From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F33ECAAA1 for ; Tue, 1 Nov 2022 13:02:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 153DB6B0072; Tue, 1 Nov 2022 09:02:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1040C6B0073; Tue, 1 Nov 2022 09:02:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35CE6B0074; Tue, 1 Nov 2022 09:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E59A36B0072 for ; Tue, 1 Nov 2022 09:02:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C34CFA0F4F for ; Tue, 1 Nov 2022 13:02:52 +0000 (UTC) X-FDA: 80084888184.04.E3EDBB1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 97C2A160063 for ; Tue, 1 Nov 2022 13:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D+EHaa8ZSYWQyKEwd8VdI1NfdyRq/w+zeq0C4XjaijY=; b=dGk5R5sFoqExlKZ8WUCieZp2hc NWvrUA/VaQdoDBYD66Et+Zpo8U0qH8f3TjU5hseQQkuAWGOSD/RSTzTsAJeTrjc9wlEhJTphAWrZx VeSzNDNUtTXLbAVqseGT1IiS3GrR/mBxNH+GVGMfuhmdASGnm76T2PaxlIoyEofP4GR34rb8NYhWc 7ZovRyfq5W3r20xRQaZ0WePuZnBJNZyLdsjAEU8ZfTCkJJ9ZrxwMNVjsLcAMqG76x93GZilG3IMTn 0EY+jORidC1nHjFfiYYyYbxzFXnahxMQMS5nm20TqeiJGkBFXZWkQCCQnuqwytv/C7pCvhK2Y3pCE Sg4ziqtg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1opqul-004cil-2D; Tue, 01 Nov 2022 13:02:47 +0000 Date: Tue, 1 Nov 2022 13:02:47 +0000 From: Matthew Wilcox To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador Subject: Re: [RFC 2/2] migrate: convert migrate_pages() to use folios Message-ID: References: <20221101062137.83649-1-ying.huang@intel.com> <20221101062137.83649-3-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101062137.83649-3-ying.huang@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667307768; a=rsa-sha256; cv=none; b=HAV0lqme5d7YCEjTPtHDFD38bSbYCra9eEqTaFkQ1LRWcJMXrquNcEbfUcMtnCLpnfKqgq 3qfHoa48M8pOhiTIDsjMIcRobigy6I6awc8kWpTLD4SGi9ZHBkp5loo5d8riqxpPeHFCce fdYhTjCuYVGAn5K8Kuw+hzPKj4Yu9DQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dGk5R5sF; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667307768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+EHaa8ZSYWQyKEwd8VdI1NfdyRq/w+zeq0C4XjaijY=; b=DXKypEHwKI09Ct1ru2N3yFhHJ6GvjYg+pVSQpnZKBhwCbvZFOkbUyrcVGp9owbI3QHwP+2 CCHzog162DHUI2/j6atImaGFQoppnc+7E8XjN4DrFQCrysHnzBtktyF9X79Dlf2k+mJv3L OlZfVJqkMhVHXcun7286SB18w3O/7pk= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dGk5R5sF; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: rsnmjycpdbidpepwuocx9fnjzxbfjda5 X-Rspamd-Queue-Id: 97C2A160063 X-HE-Tag: 1667307767-405688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 02:21:37PM +0800, Huang Ying wrote: > - is_thp = PageTransHuge(page) && !PageHuge(page); > - nr_subpages = compound_nr(page); > + is_large = folio_test_large(folio) && !PageHuge(&folio->page); We have folio_test_hugetlb() to replace PageHuge(). > count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded); > count_vm_events(PGMIGRATE_FAIL, nr_failed_pages); > - count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded); > - count_vm_events(THP_MIGRATION_FAIL, nr_thp_failed); > - count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split); > - trace_mm_migrate_pages(nr_succeeded, nr_failed_pages, nr_thp_succeeded, > - nr_thp_failed, nr_thp_split, mode, reason); > + count_vm_events(THP_MIGRATION_SUCCESS, nr_large_succeeded); > + count_vm_events(THP_MIGRATION_FAIL, nr_large_failed); > + count_vm_events(THP_MIGRATION_SPLIT, nr_split); > + trace_mm_migrate_pages(nr_succeeded, nr_failed_pages, nr_large_succeeded, > + nr_large_failed, nr_split, mode, reason); I think this is the biggest question with this patch -- how (or whether) to account folios in size between PMD and PTE size. Since it's _called_ THP, I've tended to make the statistics conditional on folio_test_pmd_mappable() rather than simply being folio_test_large().