From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0473FA373D for ; Tue, 1 Nov 2022 12:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 558266B0072; Tue, 1 Nov 2022 08:44:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 508866B0073; Tue, 1 Nov 2022 08:44:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6956B0074; Tue, 1 Nov 2022 08:44:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 336486B0072 for ; Tue, 1 Nov 2022 08:44:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 072F5AB628 for ; Tue, 1 Nov 2022 12:44:45 +0000 (UTC) X-FDA: 80084842572.27.71C1D9E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id E64C14000E for ; Tue, 1 Nov 2022 12:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Odtx5Eky4qVo99zjyx03+MN50lR1ZREXkOzvkAldQk=; b=N9IeZS1uuCWJswLD5FY6EtrHMA C7Zo3FTtJf13S+5J5r4M5MoVTv5oZn04v5ipNG9jKL49BWI0XyC/Z2DSRFHpjVALeB7MAuzI+vTay Ij3yrKXMRPXEyfhvrzJ/wtkYqDlgfh+OJDTsgFPQQnBZeKj/NKW8XKEk8tZH4SHAe6EtHU0gPR6Sn nJaJEK/wRHQAT726kb5wAmLcyP7/HYZaVu6blJcyLKsjlcsRJaDyZWE6QegtHqMhuZrfsinZ00ZU2 bDyjhFfGRygdMqfuWBp5exEEQfmmRrDkkBG2UW7t/OLmzJW3iO5Ch99diWJizsnvjTzpzm7D8mOFE hfE6VEOw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1opqdI-004bu4-R0; Tue, 01 Nov 2022 12:44:44 +0000 Date: Tue, 1 Nov 2022 12:44:44 +0000 From: Matthew Wilcox To: changfengnan Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, djwong@kernel.org, dchinner@redhat.com, chandan.babu@oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH] mm: remove filemap_fdatawait_keep_errors Message-ID: References: <20221101093413.5871-1-changfengnan@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101093413.5871-1-changfengnan@bytedance.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667306685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Odtx5Eky4qVo99zjyx03+MN50lR1ZREXkOzvkAldQk=; b=ZEaXH+UfXfPG5BWi92PRWV4qm40YSSnx/uScPQ/eIS47VVAPFa0PrHRNDZmkXa+LdIQqXG 59pdTTXQmctJOrLkah/jvTVmA3QjOH7CgUkysH4iCgQufj1dg4lSUnUW4YtYz92TPa1a5G c8rqgIoZIdUrPBLQivJV9fi3LX45iuw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N9IeZS1u; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667306685; a=rsa-sha256; cv=none; b=eBz7KpBPMNPQ0+boih+z8/mzqQ2okEI/RM1kcWtJHf5qm+kgb2Ygz7aoh2fijrCBxJa5cy TwZL21VfHAqmnINFXCrW/izDIkSbYznbYgrkxQNbqeM8JmJSOCE37+K4G8xPPxB+Lo4eSJ 9WloWTgoFgSmxez3MRO8gDaiV/xl+CM= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E64C14000E X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N9IeZS1u; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 35tdy7j8x8aqiq6gfpdte7fdcxcqs1rd X-HE-Tag: 1667306684-255075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 05:34:13PM +0800, changfengnan wrote: > use filemap_fdatawait_range_keep_errors to instead of > filemap_fdatawait_keep_errors, no functional change. I'd rather see a patch which turned filemap_fdatawait_keep_errors() into static int filemap_fdatawait_keep_errors(struct address_space *mapping) { return filemap_fdatawait_range_keep_errors(mapping, 0, LLONG_MAX); } then the callers get the nice interface they want.