From: Matthew Wilcox <willy@infradead.org>
To: changfengnan <changfengnan@bytedance.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
viro@zeniv.linux.org.uk, djwong@kernel.org, dchinner@redhat.com,
chandan.babu@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mm: remove filemap_fdatawait_keep_errors
Date: Tue, 1 Nov 2022 12:44:44 +0000 [thread overview]
Message-ID: <Y2EUvEkz4XqV/Gt1@casper.infradead.org> (raw)
In-Reply-To: <20221101093413.5871-1-changfengnan@bytedance.com>
On Tue, Nov 01, 2022 at 05:34:13PM +0800, changfengnan wrote:
> use filemap_fdatawait_range_keep_errors to instead of
> filemap_fdatawait_keep_errors, no functional change.
I'd rather see a patch which turned filemap_fdatawait_keep_errors()
into
static int filemap_fdatawait_keep_errors(struct address_space *mapping)
{
return filemap_fdatawait_range_keep_errors(mapping, 0, LLONG_MAX);
}
then the callers get the nice interface they want.
prev parent reply other threads:[~2022-11-01 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 9:34 changfengnan
2022-11-01 12:44 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2EUvEkz4XqV/Gt1@casper.infradead.org \
--to=willy@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=changfengnan@bytedance.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox