From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0B7C4332F for ; Fri, 11 Nov 2022 17:14:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 011AD6B0080; Fri, 11 Nov 2022 12:14:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F03936B0081; Fri, 11 Nov 2022 12:14:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF2948E0003; Fri, 11 Nov 2022 12:14:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D00B06B0080 for ; Fri, 11 Nov 2022 12:14:49 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F7F01A0991 for ; Fri, 11 Nov 2022 17:14:49 +0000 (UTC) X-FDA: 80121811098.30.BEFC56A Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf07.hostedemail.com (Postfix) with ESMTP id D6AEA40006 for ; Fri, 11 Nov 2022 17:14:48 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so5260392pji.0 for ; Fri, 11 Nov 2022 09:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=VTcif9FAK1ZGkmzomIK8r/gCq3xMcVIfUb58B9OBtKE=; b=poYD0imxGJeJIKeaGfVOTqQreVkMV0Yz/8rx6gVn6IXFpAhzWM+BrHt1OnjUYsu7/Y DTjhY9lrITMIlrFXcMJnC2BHsLP/T/fP2o8kT2jb7h3QyBTTYXORvzigC1/Ec00Va0og Vk5z54nKSJWZjS2Y2yivCTpBFVRJf2jgYtoR1hJn/RAwDHsW4ZB3XgZ5p1NBmwnoWj9C gypWFglJmk9A43FEQwOlKoP3n2RhaCy5EjAEZPw+7bMQtzUYAT+mLMAY6XBfSedq1vCT qYsCjVbpzk1U7Wt00A5DQJ059o6Y46qXjltiMNhe6AqRNQKrWmM84rpFr3aeOPVeWB+J xXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VTcif9FAK1ZGkmzomIK8r/gCq3xMcVIfUb58B9OBtKE=; b=km3I25yL3OXjjHeuk8cSDBmLANFiM3YGkECm3ySDPqd5jPpgLE8B7GqDE1oAc6YY3U 9iYf9A/UjHjJZv7WV1gDy9AWWLFu5PghyKyyKbYHys29P9TG2n/lU7K/RhcbL2Yv+dGG bvrh0A5557IhBEHjGj6+lOFL56lw5wHzSoMLf2l7X6CdpRc+N0ekVZ8UPIXLbe3DM1zs 8kZTxqAiu+HUehYovYdoPhf/2rfDAs9IAsk19MoyXgWnQJtgPYtjTIh2QqzNXZvC732y WDZdJqLGc6LXhuvwuIV7Yk8x/s3jsYFKBr9e3PZUfMCtPaxd96AJQT6wcWAPDYPympz6 L3FA== X-Gm-Message-State: ANoB5pkDdJVWeqanlDBQ1dSAj9xPd0be/uV2/fCIm+Hv8dv0/9SDxBT3 XVNwSpjq+Vh+7qJjSP5LgYhhMNlNWw4= X-Google-Smtp-Source: AA0mqf5iNZpM0bpIDzPt3g3jI9YmXHRm56dpUlR6NwoO7jkm71+5c7XRh3ebFEn0rT4dRWUABMK5Rw== X-Received: by 2002:a17:90a:7288:b0:213:587b:8a83 with SMTP id e8-20020a17090a728800b00213587b8a83mr2853484pjg.22.1668186887773; Fri, 11 Nov 2022 09:14:47 -0800 (PST) Received: from google.com ([2620:15c:211:201:dab:6951:19b1:b46b]) by smtp.gmail.com with ESMTPSA id o16-20020a170902d4d000b00186acb14c4asm1985677plg.67.2022.11.11.09.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 09:14:47 -0800 (PST) Date: Fri, 11 Nov 2022 09:14:45 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 6/9] zsmalloc: pass limit on pages per-zspage to zs_create_pool() Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-7-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668186888; a=rsa-sha256; cv=none; b=5PfR036pATtpDw5sc4FPX+eomxWO/W7jyL4zOwS+iZcKVtxJkfxKBEIzylo7uMbjF3YdXP FtHTd39NZgmb+GrSPFp0WoIRgarXQn1GvJn8yAP93pVfMp90zWvxl27bbbFXGglIMNeAww Wg2XovoPz7kVjw3GVwMwz9VUVPTBcqk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=poYD0imx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668186888; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VTcif9FAK1ZGkmzomIK8r/gCq3xMcVIfUb58B9OBtKE=; b=TD+/jIJAMpTJwqkgwoEZXAPGrCQxjvFiPOFuxx6VVJRICH4HHtlS8m8KtPDu1Nw6q5Ow2e HgxXGpL14QDthtiTlsbUUDEx6pKXbldoz4qfT/v9S5zGo6t4rNRLDPFYerr9Pkhb82J8yf bEHjDIy+zMkkxzHi5s3RFlrbNbJNeSk= X-Rspamd-Queue-Id: D6AEA40006 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=poYD0imx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: io4z7amzacoucouosjo7zr1nfidezho4 X-HE-Tag: 1668186888-532355 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 09, 2022 at 03:24:43PM +0900, Sergey Senozhatsky wrote: > On (22/10/31 14:41), Sergey Senozhatsky wrote: > [..] > > -struct zs_pool *zs_create_pool(const char *name) > > +struct zs_pool *zs_create_pool(const char *name, unsigned long num_pages) > > { > > int i; > > struct zs_pool *pool; > > struct size_class *prev_class = NULL; > > - unsigned long num_pages; > > + > > + if (WARN_ON(num_pages < ZS_MIN_PAGES_PER_ZSPAGE || > > + num_pages > ZS_MAX_PAGES_PER_ZSPAGE)) > > + return NULL; > > I tend to think that creating `struct zs_tunables` would be better. For > the time being zs_tunables will contain only one member max_zspage_len, > but it can be extended in the future. +1 zs_tunables if we go that way.