From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88FBC433FE for ; Fri, 11 Nov 2022 17:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 609076B0074; Fri, 11 Nov 2022 12:09:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B93E8E0005; Fri, 11 Nov 2022 12:09:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 480318E0003; Fri, 11 Nov 2022 12:09:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36D356B0074 for ; Fri, 11 Nov 2022 12:09:23 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00FE8120296 for ; Fri, 11 Nov 2022 17:09:22 +0000 (UTC) X-FDA: 80121797364.04.AE3F0CD Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf10.hostedemail.com (Postfix) with ESMTP id 8B8DEC000D for ; Fri, 11 Nov 2022 17:09:22 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id b29so5362967pfp.13 for ; Fri, 11 Nov 2022 09:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=8np7/G7bsyFXWgIxYekl7kPxfItn8rFnlB5cNNDFqN4=; b=Vk1KDeaImsSydqONneD4SKhmcDiZUj2sLkG+UGXR5C18BKD9dc7eov9JlfcjpRveW/ GNIHwtiJ1+nQx310I5JwbrcGfdgVkVXyI1PtwfjTPZWc2FoLj3tmRsmmNfSgck/qEy9g gKAEUutfqR699uAbQvSToUczY09dl3waMFGCiuaSsfjsRuuyJNWJccRA+O1k1FCqov9/ xFNi2xvq9+rAiVHmgFvjYTIZG14qNGciPN8QVxQPJx/wNh4Phk2iUcdVF9O/6/AMdGUw 6g2wmIckWDf8qhGutH8CNzy5bmj6IcVH+FF/yadUQHyth3btUtc5esxNUlxUdSJccoT/ /p5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8np7/G7bsyFXWgIxYekl7kPxfItn8rFnlB5cNNDFqN4=; b=2aiVfalXWRI214b8c4T19UdcWfR8054QCRAUJc5+LVKZyXT8DWZCqhH1JcWOUlATkZ Wh69dOUpxTuovJs/XWY71UrQQljERVDH+pwJMLWw18Mv3WM/Rus5aykZmfclERruXE5d jtiRUEaDRLoVN7yX5R+N2b7+W2qZEP/E/0YUgOYMBpkleisgvsm0El9L9Fj744s308sR MhBq8+ACT/fHCzaM2bxylHJNNLD1NdY0mn4O84lSTyCw0rFUWDSDo4lkJxWLn8tQ1jSi VtJPaDciBII9jNmlkHSY5ygnf+fI9rPDsCZfV5pj8xb1HQ+xgG4m2zX2eXtNWK9/8OeU ydBw== X-Gm-Message-State: ANoB5pkc/O6VT9jAYfEGtYiiDrh9oYZCxrHED2FVxSxhIeNedW+F2fN2 uZtKtWZf25CYJQnVGSPe8VA= X-Google-Smtp-Source: AA0mqf6bOc6eswnSV3TfmcRFzmPhTL6Ee1KbWpaBaOGQLlUb9Jl61D3zc4K3ORXo+CB6cVL5uBgJAg== X-Received: by 2002:a63:5115:0:b0:46f:a989:ad72 with SMTP id f21-20020a635115000000b0046fa989ad72mr2401863pgb.430.1668186561335; Fri, 11 Nov 2022 09:09:21 -0800 (PST) Received: from google.com ([2620:15c:211:201:dab:6951:19b1:b46b]) by smtp.gmail.com with ESMTPSA id o28-20020aa7979c000000b0056babe4fb8asm931672pfp.49.2022.11.11.09.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 09:09:20 -0800 (PST) Date: Fri, 11 Nov 2022 09:09:19 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zsmalloc: turn zspage order into runtime variable Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668186562; a=rsa-sha256; cv=none; b=08PMM/+//01GuYjb7pOt7sKnLtD5P7ewjxBcZ7tJlyNpHjf8mYAkOgHnFEaWBOnBbgOT2L 2PH5ZBxSNA5a122YFEFBeZKEsNylh/jHDRmikP5Hg/G7bPIXVJzL9r09v2V1tcUC7CvEMu qEQJdTTCn6f0ClkW4IWjIqpWlMMoWdM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Vk1KDeaI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668186562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8np7/G7bsyFXWgIxYekl7kPxfItn8rFnlB5cNNDFqN4=; b=fZhoeRFCQu0bxnMFhQ6FLtDMSMb2/wOXIlimXMMrRFGvhVsNBRnjyQiyH204GMBuZyOHJR YrMdVh8L2o1Zvuy89gk6cx155BGN0vsGbePzZYQld/ftUS8L5ODGAC1GCxedCPGOwk2mzc 4/Z8+GlSDavR3YDFfxhbnMO9I+6whG4= X-Rspamd-Queue-Id: 8B8DEC000D X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Vk1KDeaI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspamd-Server: rspam06 X-Stat-Signature: guzdkxyo68skya9gs7ftsiudfeafzszd X-HE-Tag: 1668186562-566777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 11, 2022 at 07:38:10PM +0900, Sergey Senozhatsky wrote: < snip > > [..] > > > enum fullness_group { > > > ZS_EMPTY, > > > @@ -230,12 +221,15 @@ struct link_free { > > > struct zs_pool { > > > const char *name; > > > > > > - struct size_class *size_class[ZS_SIZE_CLASSES]; > > > + struct size_class **size_class; > > > struct kmem_cache *handle_cachep; > > > struct kmem_cache *zspage_cachep; > > > > > > atomic_long_t pages_allocated; > > > > > > + u32 num_size_classes; > > > + u32 min_alloc_size; > > > > Please use int. > > OK. Any reason why we don't want u32? I thought that > s16/u16/s32/u32/etc. is the new normal. Oh, I didn't know the new normal. # ag u32 mm/ | wc -l 65 Then, I'd like to use int to be consistent with others. > > > From this patch, I couldn't figure why we need > > variable in the pool. Let's have the change in the patch where > > you really need to have the usecase. > > Let me take a look. > > > > -static int get_pages_per_zspage(int class_size) > > > +static int get_pages_per_zspage(u32 class_size, u32 num_pages) > > > > Let's just use int instead of u32 > > > > Why do you need num_pages argument instead of using 1UL << ZS_DEFAULT_PAGE_ORDER? > > It looks like static value. > > It is static right now, but in the a couple of patches it'll change to > dynamic. Then, plase have the change in the patch you will use to review easier.