From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8FCC433FE for ; Thu, 10 Nov 2022 20:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305A26B0071; Thu, 10 Nov 2022 15:04:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B5806B0072; Thu, 10 Nov 2022 15:04:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A4206B0074; Thu, 10 Nov 2022 15:04:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 06C736B0071 for ; Thu, 10 Nov 2022 15:04:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C9E181C7187 for ; Thu, 10 Nov 2022 20:04:00 +0000 (UTC) X-FDA: 80118608640.25.C761486 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 596331A0011 for ; Thu, 10 Nov 2022 20:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NIhmN7AMTXSMlZmsQxBGWR4nbHWdLbYXDTp8/wDHABE=; b=CjlDFRP+oum7hqf01JepEnZMUD EDu/qJ8KnBhJR/3Fef9SzsiyzpYkdiij7vFh1uJgELcd9UeQTT4DtqIM8sImGhyb5MrarFdxQY2i5 UfEUQGNWCMjv+voU9pdB7qeBK8LaSO+YjI3KVuxMABr3ewTbJjvcHShMLQ668qUR/BgpQkPnCtCh2 +2gQyNsckD2/q5etq54nojntwzgYyNCs52TnVBL6IMxThdhp9ng1orb5IvXJIEgnLjKtvEqgXvMQ3 VAPcxW46SyhaFhakqKtFeUeqpU7wQ4b56x31ooqtX5HylFpW1fm9iipu+GlPKnI3Mrk/fnTmVkNlo AFeRuIQw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1otDmI-00CMkc-QA; Thu, 10 Nov 2022 20:03:58 +0000 Date: Thu, 10 Nov 2022 20:03:58 +0000 From: Matthew Wilcox To: David Howells Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Make some folio and page function arguments const and use bool Message-ID: References: <166810136860.3462948.16794726061248137027.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166810136860.3462948.16794726061248137027.stgit@warthog.procyon.org.uk> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668110640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NIhmN7AMTXSMlZmsQxBGWR4nbHWdLbYXDTp8/wDHABE=; b=Eq4IN1fXNqtiroa4qu9dAn7CJ2uYRUtUD5LgWUFdrTzJNb5RXtfKp+Qlj7HBasT3RGaZIE hXIDBh9OXK3jBDreZAS4wgoLDqHBd/GInYrqmo2zXamSlyAN4b7l/8p8atqx0a10Nl4hCd 2uHHlDyya+GE+ltYSW9bz/igLzLhQVk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CjlDFRP+; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668110640; a=rsa-sha256; cv=none; b=b8r7CEE2DnUo/GPBx0810koycTRlo5H6VODsE6APHMtXpHWuo8mdD8VASm8K+XThDgKZus h9+axBQRCVttT+UHQptnM6phQpddskfCEvJOVuzxbPzrUSt8nAuLXVwop82D+Y+MRZtyRT jRA6COY0r5If9RU+Qv8Q61XFqR3AcPo= X-Rspamd-Queue-Id: 596331A0011 X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CjlDFRP+; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: k4sdfmnm3owaxib8tyszgw6ff8fes7wh X-HE-Tag: 1668110639-587824 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 05:29:28PM +0000, David Howells wrote: > Mark the folio* argument to some of the folio accessor functions as a const > pointer and similarly make some page* arguments to some page functions > const. I think the build bots are going to whinge. #ifdef CONFIG_DEBUG_VM_PGFLAGS #define VM_BUG_ON_PGFLAGS(cond, page) VM_BUG_ON_PAGE(cond, page) #define VM_BUG_ON_PAGE(cond, page) \ do { \ if (unlikely(cond)) { \ dump_page(page, "VM_BUG_ON_PAGE(" __stringify(cond)")"); void dump_page(struct page *page, const char *reason); I've looked at making dump_page() take a const struct page * in the past, but it's a lot of work. Do you really need this or is this a Friday afternoon project?