From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2DC4C433FE for ; Thu, 10 Nov 2022 22:09:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7885F6B0072; Thu, 10 Nov 2022 17:09:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 738986B0074; Thu, 10 Nov 2022 17:09:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 600DC8E0001; Thu, 10 Nov 2022 17:09:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 52D4B6B0072 for ; Thu, 10 Nov 2022 17:09:28 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D1ECAAF5D for ; Thu, 10 Nov 2022 22:09:28 +0000 (UTC) X-FDA: 80118924816.19.8A01D5E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A20F640007 for ; Thu, 10 Nov 2022 22:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668118166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h38wWhVkSIZtB2RyPJKkf5rNtE65Gqs4wgaNeAIALcc=; b=iXWbs2f6EkBl/zy/ngnkuvQFZdKeqJkiSJLig1Zl6mxsOYuEW5zkgnQsWpvLe1r1qZIDsY SkRY/cSw1gZ6qK5+R8jjQ3tPuak9clhepX9d05IFz1rZDpqaKD+lcybX5RjWkhIOI25tL1 q5WZd0EFob4F+PdNNdl6Ubqp6fiH4yQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-611-lhTRtSBlN9Oqg-_I9-uD0w-1; Thu, 10 Nov 2022 17:09:25 -0500 X-MC-Unique: lhTRtSBlN9Oqg-_I9-uD0w-1 Received: by mail-qk1-f199.google.com with SMTP id i21-20020a05620a405500b006fb25ba3e00so2349428qko.1 for ; Thu, 10 Nov 2022 14:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h38wWhVkSIZtB2RyPJKkf5rNtE65Gqs4wgaNeAIALcc=; b=2QRAo2oOEzEOmKUtBSFjHc9xi0hK0ovW6Q0VPTKSFnVoPHJgAnCJZwq+Hm5qxX+86W 0+xaERnNCt60Wv7NjR5lnrmK02WOzpVlgzMXkY5AtWOVNsx1kVUyagBaMP6NkrH0am59 S7JkL7tC3odjWPrcPYtqobrMNLyyBH6QSgU3tf9dVotoGsliUfG4CK7+9Z72dtEIG47R zbQRihOyqOs7lF6XO9V7KQnN+iwssOc0oGJXgWSlSEbvwQAv3nwafhFmODjFL8hfrzs6 Wt2w8H7tDA0fKjHB3rMjmmmkFt9QGfGk5E4gpCzmTTlGzVlY/QAgnv53zpKflvdSFny5 YUmA== X-Gm-Message-State: ACrzQf3i5UlswGXmMHK/zMpgzaTUpPjnLAwHcWs278SX5H5fso6dBfYF 6IY8pvrphOM0ssKD3pD6kra2cVlwhKKWo+7eO13b4nfw+jbae0njQq8sPx7AGhm1KiLz+jmtVo4 c4TpF7blZfHY= X-Received: by 2002:a05:6214:418c:b0:4b1:8788:21ff with SMTP id ld12-20020a056214418c00b004b1878821ffmr2170367qvb.16.1668118165057; Thu, 10 Nov 2022 14:09:25 -0800 (PST) X-Google-Smtp-Source: AMsMyM4zT6Kz79MRmDBsfpoBn32M93cP30ai8uShqGW0DU7ZFM+GRq+eHe4ng1aNLorRKZp5T5POkg== X-Received: by 2002:a05:6214:418c:b0:4b1:8788:21ff with SMTP id ld12-20020a056214418c00b004b1878821ffmr2170352qvb.16.1668118164890; Thu, 10 Nov 2022 14:09:24 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id q45-20020a05620a2a6d00b006ee7923c187sm346175qkp.42.2022.11.10.14.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:09:24 -0800 (PST) Date: Thu, 10 Nov 2022 17:09:23 -0500 From: Peter Xu To: Nadav Amit Cc: kernel list , Linux-MM , Andrea Arcangeli , Axel Rasmussen , Ives van Hoorne , Andrew Morton , Mike Rapoport , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/migrate: Fix read-only page got writable when recover pte Message-ID: References: <20221110203132.1498183-1-peterx@redhat.com> <20221110203132.1498183-2-peterx@redhat.com> <65FA2E7E-1F12-4919-BD79-11159934CF2C@gmail.com> MIME-Version: 1.0 In-Reply-To: <65FA2E7E-1F12-4919-BD79-11159934CF2C@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668118167; a=rsa-sha256; cv=none; b=Z6rlTr1VRz7LQjtwzG8gkHa9FoBDzyC5rLl6KW8eQtppd20xGDmgtVaZR4e5RDdROcpXsH wlKlJhb2GGVdwQU11X1Ia6htrXJLST3aaDPb1HaseJ5TsUn2xzenx0VO2ee/8QDeWisXOF RbVLu6DIsgwPyfO7fKhmKboqYlh2F3c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iXWbs2f6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668118167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h38wWhVkSIZtB2RyPJKkf5rNtE65Gqs4wgaNeAIALcc=; b=qH5fcgzu/Em0jovZttVmmE7vzNjastsFH5ICJC5zmANAL9zBdFEd1bsB0A8mVf4M5uKqX3 o7HElojS7Ay84yREcUjf2vqJXQlLUjHHYr7EP+EW0t51rD63N3cL4ozj4YySFswqqN5z/J g8c0d1w5+8J96RP98SEezugxjpjHeX0= X-Rspamd-Queue-Id: A20F640007 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iXWbs2f6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam06 X-Stat-Signature: 84bek3ftdqe3dpd6q791w9uegaks73an X-HE-Tag: 1668118167-194586 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 01:28:31PM -0800, Nadav Amit wrote: > On Nov 10, 2022, at 12:31 PM, Peter Xu wrote: > > > Ives van Hoorne from codesandbox.io reported an issue regarding possible > > data loss of uffd-wp when applied to memfds on heavily loaded systems. The > > sympton is some read page got data mismatch from the snapshot child VMs. > > symptom (if you care) Yes, but, > > Other than that LGTM this definitely matters more. :) Thanks for taking a look, Nadav. -- Peter Xu