From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6232DC4332F for ; Thu, 10 Nov 2022 22:08:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E67166B0071; Thu, 10 Nov 2022 17:08:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E16F46B0072; Thu, 10 Nov 2022 17:08:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDF658E0001; Thu, 10 Nov 2022 17:08:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BEBCB6B0071 for ; Thu, 10 Nov 2022 17:08:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8751E80BA9 for ; Thu, 10 Nov 2022 22:08:52 +0000 (UTC) X-FDA: 80118923304.25.2F1A956 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 38BB74000C for ; Thu, 10 Nov 2022 22:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668118131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=od/5bKmrXfsFZtwHFrDmanan/mLVNdHteQQ7qlODf90=; b=QowAsyruhZUY4kwtPKt/LkIiRH/QN7d5BJQXD1yWFEYLYfuXPkCEtdEPitHjwHfblm6CWt i85HI5pnKfd6s904Mg4WQqkwMh7IZdhy1I2+i/KWz/14TdfAJ2gDF9vB6Jq7Ph7t739JwW 2svzSKkdBS4auwCiquHYx6IOXLtYii4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-435-aiJFjIWBNmanR4im5K93Wg-1; Thu, 10 Nov 2022 17:08:43 -0500 X-MC-Unique: aiJFjIWBNmanR4im5K93Wg-1 Received: by mail-qv1-f70.google.com with SMTP id ng1-20020a0562143bc100b004bb706b3a27so2507575qvb.20 for ; Thu, 10 Nov 2022 14:08:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=od/5bKmrXfsFZtwHFrDmanan/mLVNdHteQQ7qlODf90=; b=H/LsETInql7LqxXm8prX+ykizl4zXaJTRE3zBy8OVZCt6yJiGyMV3on7yp+RdoZApb kub284gU3b66sClyRkgfOC6kEuaSycUp156N11fk6RFIUC+piyiy4MBq8HSeyzHUkI1I Mqxy0hgiDNNTxr6LlDsraso0O6QdY1BsDpIC8pfSiPW0RWa0tJGBXbFuYAq6wJ6WPB6o B61pxXRk5ND8zwtT1Nv66qZFIsNGvFNqjTkrCGPE1WSrlD8bQ7rEpx1qUQlEPa2Uvumk eIVSiHv3xb7U9MlOxg+At/6hem0v2P/Sm0C71Dbxr8+fOX9o+BZg9QoAEE7wDZ5volmX 7rFw== X-Gm-Message-State: ACrzQf3XtSDm2aQfMp5FDAMCwQ+Vjr5L980BVMgH9B0wzvW1p9Z9f9ps yXG/rRh+a+KDp814dMDcxCuWwC3aQtmMBh98Xu8v7KqxAXjlZmtE5pE2LMV1QkdcVV3YRkNY52Y 68+Epz5nvgCA= X-Received: by 2002:a05:620a:3cd:b0:6f8:4c19:8072 with SMTP id r13-20020a05620a03cd00b006f84c198072mr2070491qkm.601.1668118122358; Thu, 10 Nov 2022 14:08:42 -0800 (PST) X-Google-Smtp-Source: AMsMyM4c4f8EvRXK3VQAzgH4BUiGTn4Ttp5tjSkonjNIRZhtgCjwSke5s0WOfITMemRYOiXmztDuqA== X-Received: by 2002:a05:620a:3cd:b0:6f8:4c19:8072 with SMTP id r13-20020a05620a03cd00b006f84c198072mr2070481qkm.601.1668118122138; Thu, 10 Nov 2022 14:08:42 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id i5-20020a05620a404500b006fb11eee465sm342085qko.64.2022.11.10.14.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:08:41 -0800 (PST) Date: Thu, 10 Nov 2022 17:08:40 -0500 From: Peter Xu To: Ives van Hoorne Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , Axel Rasmussen , Nadav Amit , Andrew Morton , Mike Rapoport , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/migrate: Fix read-only page got writable when recover pte Message-ID: References: <20221110203132.1498183-1-peterx@redhat.com> <20221110203132.1498183-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QowAsyru; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668118132; a=rsa-sha256; cv=none; b=lMH+e9l6PJ5oFCYQOEBHeOW/vRwcKIeUV2AZbO89GDJq5NpinZq8i5vmk/I04mIg39Ye27 P3/ZLI5aT+L8NszAb7lMekVdWISMM9SWFaT5PtBp5Phq85udpKXEdhM+vEE2fwIKgKg5aZ P4pFbOHLIf6EG4FZSgnfnEc4hzlxphI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668118132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=od/5bKmrXfsFZtwHFrDmanan/mLVNdHteQQ7qlODf90=; b=t5rIiazV6AlOHG1r8DREMsipjWYTbIMZPBBZwdZ09AvYatOmquiQnNJGkGbq6ezXWgtZfQ yTbV2IzLMmgfzV25qMyWJF4T/uChkvLrhGRwAWWYkaHkeE4HMKk5GVN2MHUGzubI2sdnXp eVqbdhS0esb266+93loJFMzoN2Oly9U= X-Stat-Signature: kcs77gzjcpahowpnzp3ceyxuap5b6xzx X-Rspamd-Queue-Id: 38BB74000C X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QowAsyru; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam11 X-HE-Tag: 1668118132-393254 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 01:53:25PM -0800, Ives van Hoorne wrote: > I verified these latest changes with my initial test case, and can confirm > that I haven't been able to reproduce the problem anymore! Usually, I would > be able to reproduce the error after ~1-5 runs, given that I would fill the > page cache before the run, now I have been running the same test case for > 50+ times, and I haven't seen the error anymore. > > Thanks again Peter for taking the time to find the issue and coming up with > a fix! Thanks for the quick feedback, Ives! -- Peter Xu