From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 510EDC4332F for ; Thu, 10 Nov 2022 22:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DC186B0071; Thu, 10 Nov 2022 17:48:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98C5B8E0001; Thu, 10 Nov 2022 17:48:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 853566B0078; Thu, 10 Nov 2022 17:48:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72B536B0071 for ; Thu, 10 Nov 2022 17:48:36 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 16A01A0D5D for ; Thu, 10 Nov 2022 22:48:36 +0000 (UTC) X-FDA: 80119023432.08.60FBBCD Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf21.hostedemail.com (Postfix) with ESMTP id B55251C0002 for ; Thu, 10 Nov 2022 22:48:35 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id b1-20020a17090a7ac100b00213fde52d49so3166716pjl.3 for ; Thu, 10 Nov 2022 14:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=myDk/lYGLu7o49r3666PllQAH7/uxJEgb7b7To5JD6U=; b=Ou3dCUHB3cHz6ogbr6KnA15osAOsahg0uwLQ8OZhro5lFANuW2UnFbxtJ/vNBh8CiZ tI13ggx275xQ1OG2j5LOu7k+w9coqzmAzps2KgizvZDJUt9hJ2TIHP0cSqHyGO7EVO2h lisG6QbCT21i2+0huPRpK3VrJ966KjN3WdakH2ZUwsepsvk0fv/oQBGHtaZCCsKrzQTB Plww51rLc7cXR/0Qc9wYdzwHg5zxIZTIE52LK4FVcUc/jx+I0n6xfWG9J4Wf4Z+agTVP Aj+9lckvfvjdmalIHOsEoZdh41xGhsvHFOTh6QaXqozhEZDK92lzbBbM+K5ilx82Iu7U BHfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=myDk/lYGLu7o49r3666PllQAH7/uxJEgb7b7To5JD6U=; b=q+wOinpTpKQ6u3KlnvAVY0ptieK313EoKQ7vC8QzjW8CYmLnPPFL5q0hTAPOZ1HeRi HtArhRXWIk74xaLayx/KeK5oxTCGnq/RTDwDgDk22M8hiHzKgGh6aIIaRR8D/UFJ2O1N GFFD6oVxi51WvRkiVtiMHDAGbOeyMEfxmcwYhMXR9F8emBczFpraZ/l+mxX2+8LRbal8 /j4ty7z51zM12/Fm86eHhcg1fhuc2+R8DwqqrFIcKgQ63/C6qUrtUHwpm8ZeTyy6/7aT 1vBZvJ7eVB2/XCc33T8KShmhMLnIUntNfpWMnp0Mcmo04b6aUIoXgl0zxcoCTQpv3vQ0 bXgw== X-Gm-Message-State: ANoB5plsAqwjZU3QSrF4wUMlR2MumE/hL6FVV1wLOf4rpWS65k1z3tdy /MyyuvbjUJ0LABkPDzuOYbE= X-Google-Smtp-Source: AA0mqf4D2IAdlpJwCtBKx5pmIo5p/Y5r2PI+tyZId8kUXamyae8Zx1hu2Vj2at4GRfX8TIMB9R2zng== X-Received: by 2002:a17:90a:9486:b0:217:ff37:2fe9 with SMTP id s6-20020a17090a948600b00217ff372fe9mr1144237pjo.242.1668120514759; Thu, 10 Nov 2022 14:48:34 -0800 (PST) Received: from google.com ([2620:15c:211:201:8c0b:3260:c81c:119d]) by smtp.gmail.com with ESMTPSA id l2-20020a170902f68200b00186e2123506sm170934plg.300.2022.11.10.14.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:48:34 -0800 (PST) Date: Thu, 10 Nov 2022 14:48:32 -0800 From: Minchan Kim To: Nhat Pham Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Message-ID: References: <20221110171831.19176-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110171831.19176-1-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668120515; a=rsa-sha256; cv=none; b=jJO5rTPwQq/YiRL2tVTCMnkl2Ys36NZ1zhYl9XIYDghwfpaGQDYcb6HZ0LHMTSDiaJT25n +XN8fkfO20CAI3QEdRhEJPEuIabx0cipoxA8B5K57yuMOWUTvHdHM30pLaB7tqEH3UyCNU xLvZPt++xlXkr/vIrXASNpcJsDcegEk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ou3dCUHB; spf=pass (imf21.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668120515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=myDk/lYGLu7o49r3666PllQAH7/uxJEgb7b7To5JD6U=; b=ufNws4uDBotEMAg4SEJgsvZDGOUR6PBHtjW5u/D4AgXUqK+qqbJ4a+Gkuxh9WFvps361c4 gF0amH9kUc3w92knueW09gQ8sxmGQeETSX9q050ni4M38PI+cEGo5dfiGZQhK6i0yisuAf YqqiPWH7RfqVFggSBFHvTDYVw475TXs= X-Stat-Signature: uyewipuz4uxgxjkqyeynqxs4jqa936c5 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ou3dCUHB; spf=pass (imf21.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam10 X-Rspam-User: X-Rspamd-Queue-Id: B55251C0002 X-HE-Tag: 1668120515-734821 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001607, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 09:18:31AM -0800, Nhat Pham wrote: > > Please put the LRU logic under config ZSMALLOC_LRU since we don't need the > > additional logic to others. > > I think the existing CONFIG_ZPOOL would be a good option for this purpose. It > should disable the LRU behavior for non-zswap use case (zram for e.g). The > eviction logic is also currently defined under this. What do you think, > Minchan? That sounds good. Sergey and I are working to change zsmalloc zspage size. https://lore.kernel.org/linux-mm/20221031054108.541190-1-senozhatsky@chromium.org/ Could you send a new version once we settle those change down in Andrew's tree to minimize conflict? (Feel free to join the review/discussion if you are also interested ;-)) Thanks.