From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C16C4332F for ; Thu, 10 Nov 2022 16:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42D5B6B0072; Thu, 10 Nov 2022 11:06:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DCF78E0002; Thu, 10 Nov 2022 11:06:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CB988E0001; Thu, 10 Nov 2022 11:06:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1E9F76B0072 for ; Thu, 10 Nov 2022 11:06:43 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C2C491A0EEB for ; Thu, 10 Nov 2022 16:06:42 +0000 (UTC) X-FDA: 80118010644.15.129380A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 3BB59120015 for ; Thu, 10 Nov 2022 16:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Sh+Eq5Dk15P6ndaVpkL3ckTA6jJzcBON6KZfnjteXnU=; b=nOz95vtQlvdRV9Wyk0yMubFZo9 /ecJMZpJvGYHxyEsaydC1Mz7einS7Hc65UzuSRGjiue6CsglJ9V/oUr3TO0m/X0xOhYDdcNJUP6r7 8lLEJ44cGZ+g9TstpOa2887BrPUpc1OOGDEemN20sjoD30ikaEvs3Hgq09BfadXfGyZxemQzm3YJj lgdNA0WeHR7FEk04chP0xiNyqE343Gl0KA2Q/Z/ALVvAme2E4uvcKYmyfkGZmClV4UylqDJx2FcJa Xd1TvnXau51f4VWrdf3f+g8/GjN/ZmYQpLDHFvyCvYcOxlaQ3U96XvMWi+VizxGT4GLOW7nskO+Mo O+tK7Jmg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1otA4g-00CCCM-Sr; Thu, 10 Nov 2022 16:06:42 +0000 Date: Thu, 10 Nov 2022 16:06:42 +0000 From: Matthew Wilcox To: Rong Tao Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rongtao@cestc.cn, wuchi.zero@gmail.com Subject: Re: [PATCH] lib/radix-tree: Fix uninitialized variable compilation warning Message-ID: References: <20221109162348.3dbde3a7942c303af012276c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668096402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sh+Eq5Dk15P6ndaVpkL3ckTA6jJzcBON6KZfnjteXnU=; b=ShgINvV3uYhKZAwCtcAPYdAyhCLNlLW8Q0qtnWDGGmxHjF4k45Hhr9JLTjb/tg2OgxeImt vyiBCzI/VECyu/WhgdxcRyaj41GAnAiBtGQ5c4Uy/P1iebl03imDrwr9YXQHt603A8Pfgf 2KY/BBmIHoWTYDMHVm971mt7K+YwXQ8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nOz95vtQ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668096402; a=rsa-sha256; cv=none; b=Wo34x8lHl6QVh56Dpc0TJe0K+L3+KAHgtQQFpqe9q7xTJadvkn2YlBrBteIo2Y5u3z+Y5f 9dK93+Q6N7wzzL/djnc2D4LI2NS6kNku4Skunguke4rkxi5GsfQfIJdwwHmFRDxSqXap+h ANegNEu7PpsSIzDs3yxvs8jiNhyr1Rs= X-Rspam-User: X-Stat-Signature: waipysyxhk958rnjkg8to76eyhtcs5wt X-Rspamd-Queue-Id: 3BB59120015 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nOz95vtQ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-HE-Tag: 1668096401-334750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 01:00:42PM +0800, Rong Tao wrote: > radix_tree_load_root(root, &node, &maxindex); > - if (index > maxindex) > + if (index > maxindex || !node) > return NULL; No, stop it, you don't know what you're doing.