From: Matthew Wilcox <willy@infradead.org>
To: Rong Tao <rtoax@foxmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rongtao@cestc.cn, wuchi.zero@gmail.com
Subject: Re: [PATCH] lib/radix-tree: Fix uninitialized variable compilation warning
Date: Thu, 10 Nov 2022 16:06:42 +0000 [thread overview]
Message-ID: <Y20hkocEEoSNcSvZ@casper.infradead.org> (raw)
In-Reply-To: <tencent_B7D657EF5135C40D0303A1C3AC90CB0B9507@qq.com>
On Thu, Nov 10, 2022 at 01:00:42PM +0800, Rong Tao wrote:
> radix_tree_load_root(root, &node, &maxindex);
> - if (index > maxindex)
> + if (index > maxindex || !node)
> return NULL;
No, stop it, you don't know what you're doing.
next prev parent reply other threads:[~2022-11-10 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com>
2022-11-10 0:23 ` [PATCH] radix tree test suite: " Andrew Morton
2022-11-10 5:00 ` [PATCH] lib/radix-tree: " Rong Tao
2022-11-10 16:06 ` Matthew Wilcox [this message]
2022-11-11 2:11 ` Rong Tao
2022-11-10 16:06 ` [PATCH] radix tree test suite: " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20hkocEEoSNcSvZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rongtao@cestc.cn \
--cc=rtoax@foxmail.com \
--cc=wuchi.zero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox